From: Rob Herring <robh@kernel.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
Jeffrey Hugo <jhugo@codeaurora.org>,
Taniya Das <tdas@codeaurora.org>,
Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Harigovindan P <harigovi@codeaurora.org>,
devicetree@vger.kernel.org, Matthias Kaehlcke <mka@chromium.org>,
Kalyan Thota <kalyan_t@codeaurora.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-clk <linux-clk@vger.kernel.org>,
"Kristian H. Kristensen" <hoegsberg@chromium.org>,
Michael Turquette <mturquette@baylibre.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 11/15] dt-bindings: clock: Cleanup qcom,videocc bindings for sdm845/sc7180
Date: Fri, 31 Jan 2020 10:36:10 -0600 [thread overview]
Message-ID: <CAL_Jsq+_2E-bAbP9F6VYkWRp0crEyRGa5peuwP58-PZniVny7w@mail.gmail.com> (raw)
In-Reply-To: <20200130131220.v3.11.I27bbd90045f38cd3218c259526409d52a48efb35@changeid>
On Thu, Jan 30, 2020 at 3:13 PM Douglas Anderson <dianders@chromium.org> wrote:
>
> This makes the qcom,videocc bindings match the recent changes to the
> dispcc and gpucc.
>
> 1. Switched to using "bi_tcxo" instead of "xo".
>
> 2. Adds a description for the XO clock. Not terribly important but
> nice if it cleanly matches its cousins.
>
> 3. Updates the example to use the symbolic name for the RPMH clock and
> also show that the real devices are currently using 2 address cells
> / size cells and fixes the spacing on the closing brace.
>
> 4. Split into 2 files. In this case they could probably share one
> file, but let's be consistent.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> Changes in v3:
> - Added include file to description.
> - Split videocc bindings into 2 files.
> - Unlike in v2, use internal name instead of purist name.
>
> Changes in v2:
> - Patch ("dt-bindings: clock: Cleanup qcom,videocc") new for v2.
>
> .../bindings/clock/qcom,sc7180-videocc.yaml | 63 +++++++++++++++++++
> ...,videocc.yaml => qcom,sdm845-videocc.yaml} | 27 ++++----
> 2 files changed, 77 insertions(+), 13 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,sc7180-videocc.yaml
> rename Documentation/devicetree/bindings/clock/{qcom,videocc.yaml => qcom,sdm845-videocc.yaml} (60%)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7180-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7180-videocc.yaml
> new file mode 100644
> index 000000000000..f12ec56737e8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,sc7180-videocc.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/bindings/clock/qcom,sc7180-videocc.yaml#
'bindings/' should be removed here. I just found my check on this was
inadequate. The clock bindings seem to have the most copy-n-paste of
this.
Otherwise,
Reviewed-by: Rob Herring <robh@kernel.org>
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Video Clock & Reset Controller Binding for SC7180
> +
> +maintainers:
> + - Taniya Das <tdas@codeaurora.org>
> +
> +description: |
> + Qualcomm video clock control module which supports the clocks, resets and
> + power domains on SC7180.
> +
> + See also dt-bindings/clock/qcom,videocc-sc7180.h.
> +
> +properties:
> + compatible:
> + const: qcom,sc7180-videocc
> +
> + clocks:
> + items:
> + - description: Board XO source
> +
> + clock-names:
> + items:
> + - const: bi_tcxo
> +
> + '#clock-cells':
> + const: 1
> +
> + '#reset-cells':
> + const: 1
> +
> + '#power-domain-cells':
> + const: 1
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - '#clock-cells'
> + - '#reset-cells'
> + - '#power-domain-cells'
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,rpmh.h>
> + clock-controller@ab00000 {
> + compatible = "qcom,sc7180-videocc";
> + reg = <0 0x0ab00000 0 0x10000>;
> + clocks = <&rpmhcc RPMH_CXO_CLK>;
> + clock-names = "bi_tcxo";
> + #clock-cells = <1>;
> + #reset-cells = <1>;
> + #power-domain-cells = <1>;
> + };
> +...
> diff --git a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sdm845-videocc.yaml
> similarity index 60%
> rename from Documentation/devicetree/bindings/clock/qcom,videocc.yaml
> rename to Documentation/devicetree/bindings/clock/qcom,sdm845-videocc.yaml
> index 43cfc893a8d1..60300f5ab307 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sdm845-videocc.yaml
> @@ -1,30 +1,31 @@
> # SPDX-License-Identifier: GPL-2.0-only
> %YAML 1.2
> ---
> -$id: http://devicetree.org/schemas/bindings/clock/qcom,videocc.yaml#
> +$id: http://devicetree.org/schemas/bindings/clock/qcom,sdm845-videocc.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: Qualcomm Video Clock & Reset Controller Binding
> +title: Qualcomm Video Clock & Reset Controller Binding for SDM845
>
> maintainers:
> - Taniya Das <tdas@codeaurora.org>
>
> description: |
> Qualcomm video clock control module which supports the clocks, resets and
> - power domains.
> + power domains on SDM845.
> +
> + See also dt-bindings/clock/qcom,videocc-sdm845.h.
>
> properties:
> compatible:
> - enum:
> - - qcom,sc7180-videocc
> - - qcom,sdm845-videocc
> + const: qcom,sdm845-videocc
>
> clocks:
> - maxItems: 1
> + items:
> + - description: Board XO source
>
> clock-names:
> items:
> - - const: xo
> + - const: bi_tcxo
>
> '#clock-cells':
> const: 1
> @@ -48,15 +49,15 @@ required:
> - '#power-domain-cells'
>
> examples:
> - # Example of VIDEOCC with clock node properties for SDM845:
> - |
> + #include <dt-bindings/clock/qcom,rpmh.h>
> clock-controller@ab00000 {
> compatible = "qcom,sdm845-videocc";
> - reg = <0xab00000 0x10000>;
> - clocks = <&rpmhcc 0>;
> - clock-names = "xo";
> + reg = <0 0x0ab00000 0 0x10000>;
> + clocks = <&rpmhcc RPMH_CXO_CLK>;
> + clock-names = "bi_tcxo";
> #clock-cells = <1>;
> #reset-cells = <1>;
> #power-domain-cells = <1>;
> - };
> + };
> ...
> --
> 2.25.0.341.g760bfbb309-goog
>
next prev parent reply other threads:[~2020-01-31 16:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 21:12 [PATCH v3 00/15] clk: qcom: Fix parenting for dispcc/gpucc/videocc Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 01/15] clk: qcom: rcg2: Don't crash if our parent can't be found; return an error Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 02/15] dt-bindings: clock: Fix qcom,dispcc bindings for sdm845/sc7180 Douglas Anderson
2020-01-31 16:38 ` Rob Herring
2020-01-30 21:12 ` [PATCH v3 03/15] arm64: dts: qcom: sdm845: Add the missing clocks on the dispcc Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 04/15] clk: qcom: Get rid of fallback global names for dispcc-sc7180 Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 05/15] clk: qcom: Get rid of the test clock " Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 06/15] clk: qcom: Use ARRAY_SIZE in dispcc-sc7180 for parent clocks Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 07/15] dt-bindings: clock: Fix qcom,gpucc bindings for sdm845/sc7180/msm8998 Douglas Anderson
2020-01-31 16:43 ` Rob Herring
2020-01-31 16:48 ` Doug Anderson
[not found] ` <20200203162954.DE0AD2086A@mail.kernel.org>
2020-02-03 18:35 ` Doug Anderson
2020-01-30 21:12 ` [PATCH v3 08/15] arm64: dts: qcom: sdm845: Add missing clocks / fix names on the gpucc Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 09/15] clk: qcom: Get rid of the test clock for gpucc-sc7180 Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 10/15] clk: qcom: Use ARRAY_SIZE in gpucc-sc7180 for parent clocks Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 11/15] dt-bindings: clock: Cleanup qcom,videocc bindings for sdm845/sc7180 Douglas Anderson
2020-01-31 16:36 ` Rob Herring [this message]
2020-01-30 21:12 ` [PATCH v3 12/15] clk: qcom: Get rid of the test clock for videocc-sc7180 Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 13/15] clk: qcom: Use ARRAY_SIZE in videocc-sc7180 for parent clocks Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 14/15] arm64: dts: qcom: sdm845: Add the missing clock on the videocc Douglas Anderson
2020-01-30 21:12 ` [PATCH v3 15/15] arm64: dts: sc7180: Add clock controller nodes Douglas Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+_2E-bAbP9F6VYkWRp0crEyRGa5peuwP58-PZniVny7w@mail.gmail.com \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=harigovi@codeaurora.org \
--cc=hoegsberg@chromium.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=jhugo@codeaurora.org \
--cc=kalyan_t@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).