From: Rob Herring <robh@kernel.org>
To: Benjamin GAIGNARD <benjamin.gaignard@st.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
Fabrice GASNIER <fabrice.gasnier@st.com>,
"jic23@kernel.org" <jic23@kernel.org>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"lars@metafoo.de" <lars@metafoo.de>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>
Subject: Re: [PATCH 4/4] dt-bindings: mfd: Convert stm32 timers bindings to json-schema
Date: Wed, 6 Nov 2019 17:33:05 -0600 [thread overview]
Message-ID: <CAL_Jsq+eFew_8ULDOwL5GXUDxLRB9e+b+ZsMdWLKUO8i9Lk7AQ@mail.gmail.com> (raw)
In-Reply-To: <41c43d09-9371-8b23-a3dd-e43f5df5c5bc@st.com>
On Wed, Nov 6, 2019 at 1:57 PM Benjamin GAIGNARD
<benjamin.gaignard@st.com> wrote:
>
>
> On 11/6/19 5:15 AM, Rob Herring wrote:
> > On Thu, Oct 31, 2019 at 01:30:40PM +0100, Benjamin Gaignard wrote:
> >> Convert the STM32 timers binding to DT schema format using json-schema
> >>
> >> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> >> ---
> >> .../devicetree/bindings/mfd/st,stm32-timers.yaml | 91 ++++++++++++++++++++++
> >> .../devicetree/bindings/mfd/stm32-timers.txt | 73 -----------------
> >> 2 files changed, 91 insertions(+), 73 deletions(-)
> >> create mode 100644 Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml
> >> delete mode 100644 Documentation/devicetree/bindings/mfd/stm32-timers.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml b/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml
> >> new file mode 100644
> >> index 000000000000..3f0a65fb2bc0
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml
> >> @@ -0,0 +1,91 @@
> >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/mfd/st,stm32-timers.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: STMicroelectronics STM32 Timers bindings
> >> +
> >> +description: |
> >> + This hardware block provides 3 types of timer along with PWM functionality: \
> > Don't need the \
> ok
> >
> >> + - advanced-control timers consist of a 16-bit auto-reload counter driven by a programmable \
> >> + prescaler, break input feature, PWM outputs and complementary PWM ouputs channels. \
> >> + - general-purpose timers consist of a 16-bit or 32-bit auto-reload counter driven by a \
> >> + programmable prescaler and PWM outputs.\
> >> + - basic timers consist of a 16-bit auto-reload counter driven by a programmable prescaler.
> >> +
> >> +maintainers:
> >> + - Benjamin Gaignard <benjamin.gaignard@st.com>
> >> + - Fabrice Gasnier <fabrice.gasnier@st.com>
> >> +
> >> +allOf:
> >> + - $ref: "../pwm/st,stm32-pwm.yaml#"
> >> + - $ref: "../iio/timer/st,stm32-timer-trigger.yaml#"
> >> + - $ref: "../counter/st,stm32-timer-cnt.yaml#"
> > This works, but I prefer the child node names be listed under properties
> > here with a ref:
> >
> > counter:
> > $ref: "../counter/st,stm32-timer-cnt.yaml#"
> If I wrote everything in one file I guess what won't be needed anymore
> >
> >> +
> >> +properties:
> >> + compatible:
> >> + const: st,stm32-timers
> >> +
> >> + reg:
> >> + maxItems: 1
> >> +
> >> + clocks:
> >> + maxItems: 1
> >> +
> >> + clock-names:
> >> + items:
> >> + - const: int
> >> +
> >> + reset:
> >> + maxItems: 1
> >> +
> >> + dmas: true
> > How many?
>
> from 0 up to 8, but I don't know the syntax for that. minItems = 0 isn't
> accepted.
>
> Any hints for me ?
0 is not accepted because the property is never 0 items. 0 is not
present. So just:
minItems: 1
maxItems: 8
> >> +
> >> + dma-names: true
> > What are the names?
>
> it could be ch1 ... ch8, "trig" or "up" in any order.
Why does it need to be in any order? Normally we don't want to have that.
>
> Again I haven't be able to find a syntax that allow to list the names
> and use them in any orders.
dma-names:
items:
enum: [ ch1, ch2, ..., trig, up ]
Rob
prev parent reply other threads:[~2019-11-06 23:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 12:30 [PATCH 0/4] Convert STM32 Timer mdf bindings to yaml Benjamin Gaignard
2019-10-31 12:30 ` [PATCH 1/4] dt-bindings: counter: Convert stm32 counter bindings to json-schema Benjamin Gaignard
2019-11-06 4:10 ` Rob Herring
2019-11-06 4:16 ` Rob Herring
2019-11-06 19:58 ` Benjamin GAIGNARD
2019-10-31 12:30 ` [PATCH 2/4] dt-bindings: iio: timer: Convert stm32 IIO trigger " Benjamin Gaignard
2019-11-03 11:08 ` Jonathan Cameron
2019-11-05 10:07 ` Benjamin Gaignard
2019-11-06 4:06 ` Rob Herring
2019-11-06 19:51 ` Benjamin GAIGNARD
2019-11-06 23:35 ` Rob Herring
2019-11-09 12:43 ` Jonathan Cameron
2019-10-31 12:30 ` [PATCH 3/4] dt-bindings: pwm: Convert stm32 pwm " Benjamin Gaignard
2019-10-31 12:30 ` [PATCH 4/4] dt-bindings: mfd: Convert stm32 timers " Benjamin Gaignard
2019-11-06 4:15 ` Rob Herring
2019-11-06 19:57 ` Benjamin GAIGNARD
2019-11-06 23:33 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+eFew_8ULDOwL5GXUDxLRB9e+b+ZsMdWLKUO8i9Lk7AQ@mail.gmail.com \
--to=robh@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).