From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7312BC4338F for ; Thu, 29 Jul 2021 17:20:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5341D60C41 for ; Thu, 29 Jul 2021 17:20:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231574AbhG2RU4 (ORCPT ); Thu, 29 Jul 2021 13:20:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:38740 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229620AbhG2RUy (ORCPT ); Thu, 29 Jul 2021 13:20:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C67E760F42; Thu, 29 Jul 2021 17:20:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627579250; bh=3u51lRqQafrXq5f6IqvWMxZ1ptNInQdEddFA3TjKAb0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bbTDTTZUuX1tvZrjspUiyv7DKa8/vf8E/FZBxFhlf4W1jolNX6oBAnUQmJLMA+/HO os+AFaPTyDu57ZXYiK1ZmRz+uv4PsMw0xMU5NsT4xSr2TCKBn4DlXJQPC9aOVprzve OXGhvZsI9KJS8jfurdZYrJmlILa2SrwZumTm2BeTDTueOvNKqD7DpMpMemfTMHwQtP m7OWv5mIHK07aUFQSE73K7t6wqG3gJKYxq8Cv36//b5YyWFrVKc2ohRCANV5aEPjFA js5QvQdGh2cPcaatgPANzygIq1RoxijBd88J8YAo6KIOtXqCmuSd4gLTGtZ0TAwS1H 3ysTC+kA1fsag== Received: by mail-ej1-f48.google.com with SMTP id e19so11929870ejs.9; Thu, 29 Jul 2021 10:20:50 -0700 (PDT) X-Gm-Message-State: AOAM532WgPfHP1QJVQvUosrjizcT70WnF0mKtZUW3IjL7SbnwBIGnPIn vRUygH3UR6wGhX9Vti6hopcJNpJ8dapK/6Dmow== X-Google-Smtp-Source: ABdhPJzuipRyW+xyNT+RtqOAnbQFg0W4CvcPJqdZSA4Ju9OA/O4unHd//H8Jvub6DcKsikWuNgfrKfNfwMj6Ur9hAJQ= X-Received: by 2002:a17:906:d287:: with SMTP id ay7mr5417811ejb.360.1627579249347; Thu, 29 Jul 2021 10:20:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Rob Herring Date: Thu, 29 Jul 2021 11:20:37 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/5] DT schema changes for HiKey970 PCIe hardware to work To: Mauro Carvalho Chehab Cc: Linuxarm , mauro.chehab@huawei.com, Binghui Wang , Gustavo Pimentel , Jingoo Han , Xiaowei Song , devicetree@vger.kernel.org, linux-arm-kernel , "linux-kernel@vger.kernel.org" , PCI , linux-phy@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 29, 2021 at 5:56 AM Mauro Carvalho Chehab wrote: > > Hi Rob, > > After our discussions, I'm opting to submit first the DT bindings for the > Kirin 970 PCIe support. > > Patch 1 is there just because patch 2 needs. You already acked on it. > > Patch 5 is also there just as an example of the entire stuff added to > the DTS file. > > The core of this series are patches 2 to 4. They contain the conversion > of the kirin-pcie.txt file to the DT schema, and adds the needed > bindings. > > Currently, it generates some warnings: > > Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.example.dt.yaml: pcie@f5000000: pcie@4,0:compatible: None of ['pciclass,0604'] are valid under the given schema > From schema: Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.yaml This should be fixed now in dtschema master. > Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.example.dt.yaml: pcie@4,0: reset-gpios: [[4294967295, 1, 0]] is too short Your proposed change to pci-bus.yaml is wrong. It's requiring 4 entries. You need 'minItems: 1'. Rob