From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753998AbcLMVO3 (ORCPT ); Tue, 13 Dec 2016 16:14:29 -0500 Received: from mail.kernel.org ([198.145.29.136]:51830 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753610AbcLMVO1 (ORCPT ); Tue, 13 Dec 2016 16:14:27 -0500 MIME-Version: 1.0 In-Reply-To: References: <1481188984-43683-1-git-send-email-yao.yuan@freescale.com> <1481188984-43683-6-git-send-email-yao.yuan@freescale.com> <20161212170948.fq7v5lva4kgt6hly@rob-hp-laptop> From: Rob Herring Date: Tue, 13 Dec 2016 15:14:03 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi compatible string To: Yao Yuan Cc: Yuan Yao , "shawnguo@kernel.org" , "mark.rutland@arm.com" , "computersforpeace@gmail.com" , "dwmw2@infradead.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 12, 2016 at 8:47 PM, Yao Yuan wrote: > On Thu, Dec 13, 2016 at 05:23:02PM +0800, Rob Herring wrote: >> On Thu, Dec 08, 2016 at 05:23:04PM +0800, Yuan Yao wrote: >> > From: Yuan Yao >> >> Same problem in this subject too. >> >> > >> > new compatible string: "fsl,ls1012a-qspi". >> > >> > Signed-off-by: Yuan Yao >> > --- >> > Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 + >> > 1 file changed, 1 insertion(+) >> >> Acked-by: Rob Herring > > Thanks for your review. > And do you have any suggestion for this subject? The problem is you have a space in the compatible string: "fsl, ls1012a-qspi" rather than "fsl,ls1012a-qspi" Also, I prefer "dt/bindings: " as the beginning of binding patch subjects. Rob