From: Rob Herring <robh+dt@kernel.org>
To: Michal Simek <michal.simek@xilinx.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michal Simek <monstr@monstr.eu>, git <git@xilinx.com>,
Andre Przywara <andre.przywara@arm.com>,
devicetree@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: zynq: Add address-cells property to interrupt controllers
Date: Wed, 3 Feb 2021 08:12:08 -0600 [thread overview]
Message-ID: <CAL_Jsq+m7F+nD6VKd2L5i44hz32_-6iX3toZ0A0CBT-g7Xqu9g@mail.gmail.com> (raw)
In-Reply-To: <210b0e5a-767b-c285-62e2-23de19bd3cf1@xilinx.com>
On Wed, Feb 3, 2021 at 1:01 AM Michal Simek <michal.simek@xilinx.com> wrote:
>
>
>
> On 2/1/21 6:41 PM, Rob Herring wrote:
> > On Mon, Feb 1, 2021 at 8:27 AM Michal Simek <michal.simek@xilinx.com> wrote:
> >>
> >> The commit 3eb619b2f7d8 ("scripts/dtc: Update to upstream version
> >> v1.6.0-11-g9d7888cbf19c") updated dtc version which also contained DTC
> >> commit
> >> "81e0919a3e21 checks: Add interrupt provider test"
> >> where reasons for this checking are mentioned as
> >> "A missing #address-cells property is less critical, but creates
> >> ambiguities when used in interrupt-map properties, so warn about this as
> >> well now."
> >>
> >> Add address-cells property to gic and gpio nodes to get rid of this warning.
> >> The similar change has been done for ZynqMP too.
> >
> > FYI, we're going to make this check dependent on having an
> > interrupt-map property. So adding these isn't necessary.
>
> Good to know. Is there going to be report if interrupt-map doesn't
> exist? Which can end up with reverting these changes?
You mean a warning if '#address-cells' is present and interrupt-map is
not? No, that would cause lots of warnings.
Rob
next prev parent reply other threads:[~2021-02-03 14:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 14:27 [PATCH] ARM: dts: zynq: Add address-cells property to interrupt controllers Michal Simek
2021-02-01 17:41 ` Rob Herring
2021-02-03 7:00 ` Michal Simek
2021-02-03 14:12 ` Rob Herring [this message]
2021-02-03 14:15 ` Michal Simek
2021-02-03 14:43 ` Andre Przywara
2021-02-03 16:49 ` Rob Herring
2021-02-03 18:03 ` Rob Herring
2021-02-04 20:09 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+m7F+nD6VKd2L5i44hz32_-6iX3toZ0A0CBT-g7Xqu9g@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).