From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACDAEC4338F for ; Tue, 24 Aug 2021 11:52:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C9FC611F0 for ; Tue, 24 Aug 2021 11:52:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236196AbhHXLxF (ORCPT ); Tue, 24 Aug 2021 07:53:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:55106 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234787AbhHXLxD (ORCPT ); Tue, 24 Aug 2021 07:53:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4DF9C6128A; Tue, 24 Aug 2021 11:52:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629805939; bh=O1ixU2ieIhwaFgCZmeCH2BZ+CyopQlNCl/awFjtVHh8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=t9hr8TQoCJOSpNRpgJP/tYu+ZI6gtSXvyqLNkJHo5SPswX5KIKQkGA/PlQQXHgAPN 6rPKtjJZGJb2SIh2saGr1H5vP4CX7IT///a+PH/oAFoaQN3SdviyOOMHozx24OOGxb 6v35eeV0ydf0JGFhEX01Ss3ypIXJjp//CIUjYeSzR0n20iDtt6q2OLPgJ5zABtCcMZ e0KE+R1pniubnwvw5dbYPwMlvPQq0It9sLcAWn0+A462Kob68mO+XN2+rmEDAr0aH2 gv6bZg7/vTnaJBSLgrarmVw1zNMiE4VY7ZC+D4evUoEqMmCkplHEwYtNKrOhn6wFoN FtKwn5MdIfiSQ== Received: by mail-ej1-f48.google.com with SMTP id u3so43829734ejz.1; Tue, 24 Aug 2021 04:52:19 -0700 (PDT) X-Gm-Message-State: AOAM533p11vzrZIqmzh3gqrFBgdkTT0NYjQ+ptuFVebThzwGhQbuhU6f 6rGmHLuo/9MlVmacc8yw1bwENqnI0IhIrBugnw== X-Google-Smtp-Source: ABdhPJxFjBECFa74niCFa1H+pxp2iB1O2hLOjmxYyU/UW1TxNB1QOPcrS0GS5+3AZT1dnONH/hA/Jt7T0hwx8JGN0Mo= X-Received: by 2002:a17:906:ff41:: with SMTP id zo1mr10121788ejb.525.1629805937919; Tue, 24 Aug 2021 04:52:17 -0700 (PDT) MIME-Version: 1.0 References: <20210820074726.2860425-1-joel@jms.id.au> <20210820074726.2860425-2-joel@jms.id.au> In-Reply-To: From: Rob Herring Date: Tue, 24 Aug 2021 06:52:06 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for LiteETH To: Joel Stanley Cc: "David S . Miller" , Jakub Kicinski , Karol Gugala , Mateusz Holenko , devicetree , Networking , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 23, 2021 at 10:52 PM Joel Stanley wrote: > > On Mon, 23 Aug 2021 at 18:44, Rob Herring wrote: > > > > On Fri, Aug 20, 2021 at 05:17:25PM +0930, Joel Stanley wrote: > > > > + > > > + interrupts: > > > + maxItems: 1 > > > + > > > > > + rx-fifo-depth: true > > > + tx-fifo-depth: true > > > > Needs a vendor prefix, type, description and constraints. > > These are the standard properties from the ethernet-controller.yaml. I > switched the driver to using those once I discovered they existed (v1 > defined these in terms of slots, whereas the ethernet-controller > bindings use bytes). Indeed (grepping the wrong repo didn't work too well :) ). Still, I'd assume there's some valid range for this h/w you can define? Or 0 - 2^32 is valid? Rob