From: Rob Herring <robh@kernel.org>
To: "Ramuthevar,Vadivel MuruganX"
<vadivel.muruganx.ramuthevar@linux.intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
cheol.yong.kim@intel.com, qi-ming.wu@intel.com,
peter.harliman.liem@intel.com
Subject: Re: [PATCH v10 1/2] dt-bindings: phy: intel-emmc-phy: Add YAML schema for LGM eMMC PHY
Date: Mon, 13 Jan 2020 11:55:55 -0600 [thread overview]
Message-ID: <CAL_Jsq+qcR=3y1TQ+qrbfNW=_3kJ92eZP5eYvGYgteYWHyDVPw@mail.gmail.com> (raw)
In-Reply-To: <20191217015658.23017-2-vadivel.muruganx.ramuthevar@linux.intel.com>
On Mon, Dec 16, 2019 at 7:57 PM Ramuthevar,Vadivel MuruganX
<vadivel.muruganx.ramuthevar@linux.intel.com> wrote:
>
> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>
> Add a YAML schema to use the host controller driver with the
> eMMC PHY on Intel's Lightning Mountain SoC.
>
> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> ---
> .../bindings/phy/intel,lgm-emmc-phy.yaml | 56 ++++++++++++++++++++++
> 1 file changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
>
> diff --git a/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml b/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
> new file mode 100644
> index 000000000000..ff7959c21af0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/intel,lgm-emmc-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Intel Lightning Mountain(LGM) eMMC PHY Device Tree Bindings
> +
> +maintainers:
> + - Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> +
> +description: |+
> + Bindings for eMMC PHY on Intel's Lightning Mountain SoC, syscon
> + node is used to reference the base address of eMMC phy registers.
> +
> + The eMMC PHY node should be the child of a syscon node with the
> + required property:
> +
> + - compatible: Should be one of the following:
> + "intel,lgm-syscon", "syscon"
> + - reg:
> + maxItems: 1
> +
> +properties:
> + compatible:
> + const: intel,lgm-emmc-phy
> +
> + "#phy-cells":
> + const: 0
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> +required:
> + - "#phy-cells"
> + - compatible
> + - reg
> + - clocks
> +
> +examples:
> + - |
> + sysconf: chiptop@e0200000 {
> + compatible = "intel,lgm-syscon", "syscon";
> + reg = <0xe0200000 0x100>;
> +
> + emmc-phy: emmc-phy@a8 {
This fails in linux-next. Please run 'make dt_binding_check' and fix:
Error: Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.example.dts:21.19-20
syntax error
FATAL ERROR: Unable to parse input tree
The problem is labels can't have '-'.
Rob
next prev parent reply other threads:[~2020-01-13 17:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 1:56 [PATCH v10 0/2] phy: intel-lgm-emmc: Add support for eMMC PHY Ramuthevar,Vadivel MuruganX
2019-12-17 1:56 ` [PATCH v10 1/2] dt-bindings: phy: intel-emmc-phy: Add YAML schema for LGM " Ramuthevar,Vadivel MuruganX
2019-12-18 14:46 ` Rob Herring
2020-01-13 17:55 ` Rob Herring [this message]
2020-01-14 2:56 ` Ramuthevar, Vadivel MuruganX
2019-12-17 1:56 ` [PATCH v10 2/2] phy: intel-lgm-emmc: Add support for " Ramuthevar,Vadivel MuruganX
2020-01-06 7:24 ` [PATCH v10 0/2] " Kishon Vijay Abraham I
2020-01-06 8:01 ` Ramuthevar, Vadivel MuruganX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_Jsq+qcR=3y1TQ+qrbfNW=_3kJ92eZP5eYvGYgteYWHyDVPw@mail.gmail.com' \
--to=robh@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.harliman.liem@intel.com \
--cc=qi-ming.wu@intel.com \
--cc=vadivel.muruganx.ramuthevar@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).