From: Rob Herring <robh+dt@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Alexandru Tachici <alexandru.tachici@analog.com>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: iio: adc: ad7124: add config nodes
Date: Mon, 8 Feb 2021 10:06:39 -0600 [thread overview]
Message-ID: <CAL_Jsq+zXzqkMbq5x6GCdE_175MpTGHw3kfOKaPpuaWuAtMF-Q@mail.gmail.com> (raw)
In-Reply-To: <20210206152643.53b0e01b@archlinux>
On Sat, Feb 6, 2021 at 9:26 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Thu, 4 Feb 2021 13:35:51 +0200
> <alexandru.tachici@analog.com> wrote:
>
> > From: Alexandru Tachici <alexandru.tachici@analog.com>
> >
> > Document use of configurations in device-tree bindings.
> >
> > Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>
>
> Ignoring discussing in my reply to the cover letter...
>
> This is a breaking change as described. We can't move properties
> around without some sort of fullback for them being in the old
> location.
>
> > ---
> > .../bindings/iio/adc/adi,ad7124.yaml | 72 +++++++++++++++----
> > 1 file changed, 57 insertions(+), 15 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7124.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7124.yaml
> > index fb3d0dae9bae..330064461d0a 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7124.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7124.yaml
> > @@ -62,20 +62,19 @@ required:
> > - interrupts
> >
> > patternProperties:
> > - "^channel@([0-9]|1[0-5])$":
> > - $ref: "adc.yaml"
> > + "^config@(2[0-7])$":
> > type: object
> > description: |
> > - Represents the external channels which are connected to the ADC.
> > + Represents a channel configuration.
> > + See Documentation/devicetree/bindings/iio/adc/adc.txt.
>
> adc.yaml now.
>
>
> >
> > properties:
> > reg:
> > description: |
> > - The channel number. It can have up to 8 channels on ad7124-4
> > - and 16 channels on ad7124-8, numbered from 0 to 15.
> > + The config number. It can have up to 8 configuration.
> > items:
> > - minimum: 0
> > - maximum: 15
> > + minimum: 20
> > + maximum: 27
>
> Number then 0-7 please rather than 20-27.
That doesn't work. It would be creating 2 address spaces at one level
with channel@0 and config@0. The way to address this is add a
'configs' node with config@N children.
My question here though is where does 20-27 come from. I suspect it's
made up which isn't good either. Addresses should also be rooted in
something in the h/w.
Rob
next prev parent reply other threads:[~2021-02-08 18:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 11:35 [PATCH v2 0/2] iio: adc: ad7124: allow 16 channels alexandru.tachici
2021-02-04 11:35 ` [PATCH v2 1/2] " alexandru.tachici
2021-02-06 15:36 ` Jonathan Cameron
2021-02-04 11:35 ` [PATCH v2 2/2] dt-bindings: iio: adc: ad7124: add config nodes alexandru.tachici
2021-02-04 15:20 ` Rob Herring
2021-02-06 15:26 ` Jonathan Cameron
2021-02-08 16:06 ` Rob Herring [this message]
2021-02-06 15:30 ` [PATCH v2 0/2] iio: adc: ad7124: allow 16 channels Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+zXzqkMbq5x6GCdE_175MpTGHw3kfOKaPpuaWuAtMF-Q@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=alexandru.tachici@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).