From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753812AbdLDQXk (ORCPT ); Mon, 4 Dec 2017 11:23:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:40224 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753111AbdLDQXg (ORCPT ); Mon, 4 Dec 2017 11:23:36 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C1522199D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh+dt@kernel.org X-Google-Smtp-Source: AGs4zMY57sxlGCbKF9+fPz1+YgUXYhRMafYrBpmZ55nkcBuudmtrdugLcxkAYQ4XMJVHKJTrPGiUcLxBYjeh/tZqT7s= MIME-Version: 1.0 In-Reply-To: <1512188864-773-5-git-send-email-okaya@codeaurora.org> References: <1512188864-773-1-git-send-email-okaya@codeaurora.org> <1512188864-773-5-git-send-email-okaya@codeaurora.org> From: Rob Herring Date: Mon, 4 Dec 2017 10:23:14 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V5 4/7] OF: properties: Implement get_match_data() callback To: Sinan Kaya Cc: "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" , Timur Tabi , "devicetree@vger.kernel.org" , linux-arm-msm , "linux-arm-kernel@lists.infradead.org" , Frank Rowand , open list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 1, 2017 at 10:27 PM, Sinan Kaya wrote: > Now that we have a get_match_data() callback as part of the firmware node, > implement the OF specific piece for it. > > Signed-off-by: Sinan Kaya > --- > drivers/of/property.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/of/property.c b/drivers/of/property.c > index 264c355..adcde1a 100644 > --- a/drivers/of/property.c > +++ b/drivers/of/property.c > @@ -981,6 +981,22 @@ static int of_fwnode_graph_parse_endpoint(const struct fwnode_handle *fwnode, > return 0; > } > > +void *of_fwnode_get_match_data(const struct fwnode_handle *fwnode, > + const struct device_driver *drv) > +{ > + const struct device_node *node = to_of_node(fwnode); > + const struct of_device_id *match; > + > + if (!node) > + return NULL; of_match_node checks this. > + > + match = of_match_node(drv->of_match_table, node); > + if (!match) > + return NULL; > + > + return (void *)match->data; Don't need a cast here. of_device_get_match_data() already does most of this, but getting a device ptr from fwnode_handle may not be possible? Rob