From: Rob Herring <robh+dt@kernel.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: "Clemens Gruber" <clemens.gruber@pqgruber.com>,
"Linux PWM List" <linux-pwm@vger.kernel.org>,
"Sven Van Asbroeck" <TheSven73@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 4/8] dt-bindings: pwm: Support new PWM_USAGE_POWER flag
Date: Fri, 16 Apr 2021 10:39:12 -0500 [thread overview]
Message-ID: <CAL_JsqJ3MU+iCr+R784r7UkPEsmDUgsgL-Qvi7edKnpe3T8M5g@mail.gmail.com> (raw)
In-Reply-To: <YHmXPyf+XjgJs3C8@orome.fritz.box>
On Fri, Apr 16, 2021 at 8:54 AM Thierry Reding <thierry.reding@gmail.com> wrote:
>
> On Mon, Apr 12, 2021 at 03:27:41PM +0200, Clemens Gruber wrote:
> > Add the flag and corresponding documentation for PWM_USAGE_POWER.
> >
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
> > ---
> > Documentation/devicetree/bindings/pwm/pwm.txt | 3 +++
> > include/dt-bindings/pwm/pwm.h | 1 +
> > 2 files changed, 4 insertions(+)
>
> Rob, what are your thoughts on this? I've been thinking about this some
> more and I'm having second thoughts about putting this into device tree
> because it doesn't actually describe a property of the PWM hardware but
> rather a use-case specific hint. It's a bit of a gray area because this
> is just part of the PWM specifier which already has use-case specific
> "configuration", such as the period and the polarity.
I'm pretty neutral. My main hesitation from what I've followed is
'power' seems a bit indirect. A PWM signal doesn't have a 'power' any
more than a GPIO signal does.
> Perhaps a better place for this is within the PWM API? We could add the
> same information into struct pwm_state and then consumers that don't
> care about specifics of the signal (such as pwm-backlight) can set that
> flag when they request a state to be applied.
Yeah, seems like this is fairly well tied to the class of consumer.
Rob
next prev parent reply other threads:[~2021-04-16 15:39 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 13:27 [PATCH v8 1/8] pwm: pca9685: Switch to atomic API Clemens Gruber
2021-04-12 13:27 ` [PATCH v8 2/8] pwm: pca9685: Support hardware readout Clemens Gruber
2021-04-12 16:21 ` Uwe Kleine-König
2021-04-12 13:27 ` [PATCH v8 3/8] pwm: pca9685: Improve runtime PM behavior Clemens Gruber
2021-04-12 13:27 ` [PATCH v8 4/8] dt-bindings: pwm: Support new PWM_USAGE_POWER flag Clemens Gruber
2021-04-12 16:27 ` Uwe Kleine-König
2021-04-12 16:46 ` Clemens Gruber
2021-04-13 11:38 ` Uwe Kleine-König
2021-04-13 11:41 ` Thierry Reding
2021-04-13 11:51 ` Thierry Reding
2021-04-13 17:56 ` Uwe Kleine-König
2021-04-15 16:27 ` Thierry Reding
2021-04-16 9:32 ` Uwe Kleine-König
2021-04-16 10:45 ` Thierry Reding
2021-04-18 13:30 ` Uwe Kleine-König
2021-04-16 13:55 ` Thierry Reding
2021-04-16 15:39 ` Rob Herring [this message]
2021-04-16 15:54 ` Clemens Gruber
2021-04-17 15:44 ` Uwe Kleine-König
2021-04-12 13:27 ` [PATCH v8 5/8] pwm: core: " Clemens Gruber
2021-04-12 13:27 ` [PATCH v8 6/8] pwm: pca9685: " Clemens Gruber
2021-04-12 16:30 ` Uwe Kleine-König
2021-04-12 17:11 ` Clemens Gruber
2021-04-13 10:34 ` Uwe Kleine-König
2021-04-12 13:27 ` [PATCH v8 7/8] pwm: pca9685: Restrict period change for enabled PWMs Clemens Gruber
2021-04-17 15:46 ` Uwe Kleine-König
2021-04-12 13:27 ` [PATCH v8 8/8] pwm: pca9685: Add error messages for failed regmap calls Clemens Gruber
2021-04-17 15:47 ` Uwe Kleine-König
2021-04-12 16:18 ` [PATCH v8 1/8] pwm: pca9685: Switch to atomic API Uwe Kleine-König
2021-04-12 16:39 ` Clemens Gruber
2021-04-12 20:10 ` Uwe Kleine-König
2021-04-13 12:11 ` Clemens Gruber
2021-04-13 12:17 ` Clemens Gruber
2021-04-13 12:37 ` Thierry Reding
2021-04-13 13:06 ` Clemens Gruber
2021-04-13 19:38 ` Uwe Kleine-König
2021-04-14 12:09 ` Clemens Gruber
2021-04-14 19:21 ` Uwe Kleine-König
2021-04-14 19:45 ` Clemens Gruber
2021-04-15 6:48 ` Uwe Kleine-König
2021-04-17 15:37 ` Uwe Kleine-König
2021-04-17 16:40 ` Clemens Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJ3MU+iCr+R784r7UkPEsmDUgsgL-Qvi7edKnpe3T8M5g@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=TheSven73@gmail.com \
--cc=clemens.gruber@pqgruber.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).