From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14B75C433E0 for ; Mon, 1 Feb 2021 18:57:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC9DE64E2E for ; Mon, 1 Feb 2021 18:57:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232375AbhBAS5T (ORCPT ); Mon, 1 Feb 2021 13:57:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:36818 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232235AbhBAS5L (ORCPT ); Mon, 1 Feb 2021 13:57:11 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4477A64E31; Mon, 1 Feb 2021 18:56:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612205790; bh=Fl3Npf+4pVvNh31RXdPU8dppcbyE9HjVP7yvitbpn4g=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=U8WNAvciv/P2kJz7GaZrM/Pg2nPahp9pPbQPyB9ZjyivmN3KcvwNAR+S7+v6ICxg4 SFKio0B4h/2MqVwcMZ+SnSzki0337HqV1SCYyQBlwBrt0mEulo4AKIuZGU7tpzOSMs 4FHWrIL8Jql6anPO7p1NA7D/+sf8sjUGxdaWtYDg22BQAwL3wUJrp6Kaj683tPdF06 QFBPhanrAdp0hOyVuLfcoinugPlRTld5TcQs7gB4pUXRVN3tpzJ5K/hRFrpDgjYDKw lZ98A3OxXLbINNsTJsdQYemhnDwnK16IAUffggLeIEl3UiHQ2RZ5kvLjCjpTGRfD4v /wauWqWFM8Orw== Received: by mail-ej1-f44.google.com with SMTP id rv9so26004581ejb.13; Mon, 01 Feb 2021 10:56:30 -0800 (PST) X-Gm-Message-State: AOAM531vStl/NU5B4vtNwOWrQht75mpSXK1biXuGvuw6T5orD8aVeyPu FiuDnjW1pFNP54687osmbv8uJ/yCEj/p+LLsRA== X-Google-Smtp-Source: ABdhPJxqcJ2ZL6F2eAzG2R/j7txAlsnr/4awa7SBSOph3dZPuXrRGALcN4hda5NsXyK5yi82Kn0svJRpym9dDzklP/U= X-Received: by 2002:a17:907:16a2:: with SMTP id hc34mr786372ejc.108.1612205788803; Mon, 01 Feb 2021 10:56:28 -0800 (PST) MIME-Version: 1.0 References: <20210111142309.193441-1-maxime@cerno.tech> <20210111142309.193441-14-maxime@cerno.tech> In-Reply-To: <20210111142309.193441-14-maxime@cerno.tech> From: Rob Herring Date: Mon, 1 Feb 2021 12:56:17 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 13/15] dt-binding: display: bcm2711-hdmi: Add CEC and hotplug interrupts To: Maxime Ripard Cc: Eric Anholt , Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie , Dave Stevenson , "linux-kernel@vger.kernel.org" , dri-devel , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , Hans Verkuil , Mauro Carvalho Chehab , linux-arm-kernel , Linux Media Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2021 at 8:27 AM Maxime Ripard wrote: > > The CEC and hotplug interrupts were missing when that binding was > introduced, let's add them in now that we've figured out how it works. > > Signed-off-by: Maxime Ripard > --- > .../bindings/display/brcm,bcm2711-hdmi.yaml | 20 ++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > index 7ce06f9f9f8e..6e8ac910bdd8 100644 > --- a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > @@ -53,6 +53,24 @@ properties: > - const: audio > - const: cec > > + interrupts: > + items: > + - description: CEC TX interrupt > + - description: CEC RX interrupt > + - description: CEC stuck at low interrupt > + - description: Wake-up interrupt > + - description: Hotplug connected interrupt > + - description: Hotplug removed interrupt > + > + interrupt-names: > + items: > + - const: cec-tx > + - const: cec-rx > + - const: cec-low > + - const: wakeup > + - const: hpd-connected > + - const: hpd-removed > + > ddc: > allOf: > - $ref: /schemas/types.yaml#/definitions/phandle > @@ -90,7 +108,7 @@ required: > - resets > - ddc > > -additionalProperties: false > +unevaluatedProperties: false /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml: 'additionalProperties' is a required property And you missed the DT list, so no checks ran. Rob