From: Rob Herring <robh@kernel.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Michael Neuling <mikey@neuling.org>,
Al Viro <viro@zeniv.linux.org.uk>,
johan Hovold <johan@kernel.org>,
Peter Hurley <peter@hurleysoftware.com>,
Wang YanQing <udknight@gmail.com>,
Alexander Popov <alex.popov@linux.com>,
Mikulas Patocka <mpatocka@redhat.com>,
Dmitry Vyukov <dvyukov@google.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: tty crash in tty_ldisc_receive_buf()
Date: Fri, 7 Apr 2017 09:03:28 -0500 [thread overview]
Message-ID: <CAL_JsqJ4U8B=E7AiJ_+SSKKKFcWLEx0uD2+Dkp67CLKRX-PCDg@mail.gmail.com> (raw)
In-Reply-To: <1491527002.4166.148.camel@kernel.crashing.org>
On Thu, Apr 6, 2017 at 8:03 PM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> On Thu, 2017-04-06 at 08:28 -0500, Rob Herring wrote:
>>
>> Can you try this one [1].
>>
>> Rob
>>
>> [1] https://lkml.org/lkml/2017/3/23/569
>
> Unless I missed something, that patch doesn't change barriers or
> locking, so I don't see how it could fix anything ...
Only because that's a code path that I changed recently and the
locking and ordering appears to be tricky.
> Mind you we haven't quite figured out exactly what's happening here.
Is this with a serial port? There were some changes to serial_core close in 4.9.
Rob
next prev parent reply other threads:[~2017-04-07 14:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 7:04 tty crash in tty_ldisc_receive_buf() Michael Neuling
2017-04-06 7:16 ` Benjamin Herrenschmidt
2017-04-06 13:28 ` Rob Herring
2017-04-07 0:47 ` Michael Neuling
2017-04-07 1:03 ` Benjamin Herrenschmidt
2017-04-07 14:03 ` Rob Herring [this message]
2017-04-07 23:21 ` Benjamin Herrenschmidt
2017-04-07 1:24 ` Wang YanQing
2017-04-07 2:06 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqJ4U8B=E7AiJ_+SSKKKFcWLEx0uD2+Dkp67CLKRX-PCDg@mail.gmail.com' \
--to=robh@kernel.org \
--cc=alex.popov@linux.com \
--cc=benh@kernel.crashing.org \
--cc=dvyukov@google.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikey@neuling.org \
--cc=mpatocka@redhat.com \
--cc=peter@hurleysoftware.com \
--cc=udknight@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).