From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751650AbcBLThH (ORCPT ); Fri, 12 Feb 2016 14:37:07 -0500 Received: from mail.kernel.org ([198.145.29.136]:54123 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751136AbcBLThE (ORCPT ); Fri, 12 Feb 2016 14:37:04 -0500 MIME-Version: 1.0 In-Reply-To: <56BE1BC8.5020604@synopsys.com> References: <20160212163636.GA31045@rob-hp-laptop> <56BE1BC8.5020604@synopsys.com> From: Rob Herring Date: Fri, 12 Feb 2016 13:36:39 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 3/3] add support for DWC UFS Host Controller To: Joao Pinto Cc: vinayak holikatti , julian.calaby@gmail.com, Akinobu Mita , hch@infradead.org, Arnd Bergmann , Mark Rutland , Gilad Broner , Subhash Jadavani , CARLOS.PALMINHA@synopsys.com, Ian Campbell , "linux-kernel@vger.kernel.org" , linux-scsi@vger.kernel.org, "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 12, 2016 at 11:52 AM, Joao Pinto wrote: > Hi Rob, > > On 2/12/2016 4:36 PM, Rob Herring wrote: >> On Thu, Feb 11, 2016 at 12:13:06PM +0000, Joao Pinto wrote: >>> +Required properties: >>> +- compatible : compatible string ("snps,ufshcd-1.0", "snps,ufshcd-1.1" >>> + or "snps,ufshcd-2.0") >> >> History has taught us this needs to have a vendor specific compatible >> string as well. Don't necessarily have to define it now, but just state >> a vendor string is needed too. > > The compatibility string already as the "snps" which is the acronym for Synopsys > which is the HW Controller vendor. Isn't this enough? Go look drivers for any licensed IP: DW PCIe, DW GMAC, USB EHCI controllers (pretty much all licensed IP), etc. They all have variations either from versions of the IP, configuration of the IP, "enhancements" by the licensee, integration quirks, or all of the above. Rob