From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31C38C54FCF for ; Mon, 23 Mar 2020 21:16:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 096AE2070A for ; Mon, 23 Mar 2020 21:16:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584998189; bh=lAcPaGMeuTbQ0e60tGnw6ov4e5Q5aILJQN/wYj3AAMk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=Srt5okW/ex6BuK2YIgQiBzqQZLA70aiq/hkv8N6msj/TYx2oCGi++PaThk2Yj+oBb IyhgygvbWNW/balA0chVf7jaDUO7WAgCwg7HfJeHqQ2Ls6tThqIUBi+iQkp4Cjh9HU 8p/Gqtn2z/lriCdfy3Dmw9zLEvBuW4vW6b4OXFNg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727092AbgCWVQ2 (ORCPT ); Mon, 23 Mar 2020 17:16:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:33282 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726203AbgCWVQ1 (ORCPT ); Mon, 23 Mar 2020 17:16:27 -0400 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E43AD2073E; Mon, 23 Mar 2020 21:16:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584998187; bh=lAcPaGMeuTbQ0e60tGnw6ov4e5Q5aILJQN/wYj3AAMk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=z5xnYgUgdU2DIBDs8HEZaSJH752225z4W2JUWCZZIukzeTeclguBbUyeCUXDTX9I8 56K0xXKFuMxB2oxCqLne3IK+sazlamo7gKkDX4NAYNCTIwlU+bNmXO0p1L/aH5bs+1 CFPOr47ciju93GlG08d1OyFZizI1aN3zdH+eNNxc= Received: by mail-qt1-f180.google.com with SMTP id f20so13149902qtq.6; Mon, 23 Mar 2020 14:16:26 -0700 (PDT) X-Gm-Message-State: ANhLgQ1+8lGd7B0mnyiOmqvoggfla72NQPnqp9c/0D/Lol8BN2BPjJfy lRGWyAiiokq0/hMdw1pIryXDSfx+69F03WXlhg== X-Google-Smtp-Source: ADFU+vum708OpcpjRaJMVDkorGVUHHFISsRaDWFsZpbGSzR6ZkKzsCsNyMn7et2Npg4zVfxkp3GAuYA09s21/oTFXis= X-Received: by 2002:aed:3461:: with SMTP id w88mr23486218qtd.143.1584998186039; Mon, 23 Mar 2020 14:16:26 -0700 (PDT) MIME-Version: 1.0 References: <8a0cfe9e3018f7996c1563035bee76048941beb4.1583412540.git.amit.kucheria@linaro.org> <20200311144933.GA21587@bogus> In-Reply-To: From: Rob Herring Date: Mon, 23 Mar 2020 15:16:14 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 3/3] dt-bindings: thermal: Add yaml bindings for thermal zones To: Amit Kucheria Cc: LKML , linux-arm-msm , Stephen Boyd , Matthias Kaehlcke , Daniel Lezcano , Zhang Rui , Linux PM list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 23, 2020 at 2:46 PM Amit Kucheria wrote: > > Hi Rob, > > Thanks for the review. > > On Wed, Mar 11, 2020 at 8:19 PM Rob Herring wrote: > > > > On Thu, Mar 05, 2020 at 06:26:43PM +0530, Amit Kucheria wrote: > > > As part of moving the thermal bindings to YAML, split it up into 3 > > > bindings: thermal sensors, cooling devices and thermal zones. > > > > > > The thermal-zone binding is a software abstraction to capture the > > > properties of each zone - how often they should be checked, the > > > temperature thresholds (trips) at which mitigation actions need to be > > > taken and the level of mitigation needed at those thresholds. [...] > > > + trips: > > > + type: object > > > + description: > > > + This node describes a set of points in the temperature domain at > > > + which the thermal framework needs to takes action. The actions to > > > + be taken are defined in another node called cooling-maps. > > > + > > > + patternProperties: > > > + "^[a-zA-Z][a-zA-Z0-9,+\\._]{0,63}$": > > > > Drop ',', '+', '.', and ideally '_'. Probably need to add '-'. > > Dropping underscore flags a lot of DTs in dtbs_check. Do you want me > to go fix them or can we live with the underscore. Is there some > document I should read on why underscore isn't desirable? Just convention. dtc will warn (with W=2), but we probably should document that better. Anyways, fine to leave '_' here. > > > + /* ... */ > > > + > > > + gpu-thermal-top { > > > > This one is not going to match (which should cause an error). > > Good catch. Unfortunately, this isn't getting caught. Nor is the > 12-char limitation before -thermal in the thermal zone name. I can't > figure out why. That's because this schema has to be included by another schema which matches on a parent node containing 'thermal-zones'. If 'thermal-zones' can be at the root node, then you should rework this such that you have $nodename: {const: thermal-zones} as a top-level property. Rob