From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F131C11D1D for ; Thu, 20 Feb 2020 19:41:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 087D6206F4 for ; Thu, 20 Feb 2020 19:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582227664; bh=0wre2PhbpSA1aEnoeMZ1bcwtIXAHkDXm1zKnDVREcMk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=fj9vLDkDlNmkp3Ylbj6SfQxXhYDcoq9+OMA668utytaR1eBzKxqpKtHXi9v07M3/k dnC1MgNMgCCv04dGtVVq4haT4FqUnyfXIyWYD6Y3LeN6huGRFbJ08XU8b+Emfmzfw7 iLOzu8H2ORz8bSo7p0nouHoECFAYmzfcBoVwqHNE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728969AbgBTTlC (ORCPT ); Thu, 20 Feb 2020 14:41:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:41910 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728248AbgBTTlC (ORCPT ); Thu, 20 Feb 2020 14:41:02 -0500 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 69AC8206F4; Thu, 20 Feb 2020 19:41:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582227661; bh=0wre2PhbpSA1aEnoeMZ1bcwtIXAHkDXm1zKnDVREcMk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=onGUmZ4W5YgNq6a6cohwh4PcfU3bSROgWlTISRwk6Tu4qja+yGJdoTcfTIuItS4X0 6/noPkMXCG2AWjgYUOGkW9pJOBQCNtOmEfYnV9poABQ5qG7X3jEsN2ArrSIhZNy2U4 fDOntJCGfiV/LN5jbMQQCuHJNcVw1mjFRCTOtOpM= Received: by mail-qt1-f178.google.com with SMTP id t13so3761767qto.3; Thu, 20 Feb 2020 11:41:01 -0800 (PST) X-Gm-Message-State: APjAAAU/a8+ebsvRPsXIsIQ8/vMtJYEadx2WXuwrthzMCQ/j91qIkw8j W+zjOIFPQlu1AZ0cXJ/ms/mizOIeWLpdQmEg2g== X-Google-Smtp-Source: APXvYqzDn8h46fe/CUa7KJYYUBSmCXArXpHfC06sW0cJBJhvkkTyV8xOPINS5zIjiic0Sfqc+1Sca27kEmFwAHiwRwU= X-Received: by 2002:ac8:6747:: with SMTP id n7mr28142441qtp.224.1582227660541; Thu, 20 Feb 2020 11:41:00 -0800 (PST) MIME-Version: 1.0 References: <20200219074314.22829-1-j-keerthy@ti.com> <20200219074314.22829-2-j-keerthy@ti.com> <20200219145227.GA1317@bogus> <55b68963-b931-bf67-482e-146e42af4298@ti.com> In-Reply-To: <55b68963-b931-bf67-482e-146e42af4298@ti.com> From: Rob Herring Date: Thu, 20 Feb 2020 13:40:49 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/4] dt-bindings: thermal: k3: Add VTM bindings documentation To: Keerthy Cc: Zhang Rui , Daniel Lezcano , Amit Kucheria , Tero Kristo , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:THERMAL" , Mark Rutland Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 19, 2020 at 10:13 PM Keerthy wrote: > > > > On 19/02/20 8:22 pm, Rob Herring wrote: > > On Wed, Feb 19, 2020 at 01:13:11PM +0530, Keerthy wrote: > >> Add VTM bindings documentation. In the Voltage Thermal > >> Management Module(VTM), K3 AM654 supplies a voltage > >> reference and a temperature sensor feature that are gathered in the band > >> gap voltage and temperature sensor (VBGAPTS) module. The band > >> gap provides current and voltage reference for its internal > >> circuits and other analog IP blocks. The analog-to-digital > >> converter (ADC) produces an output value that is proportional > >> to the silicon temperature. > >> > >> Signed-off-by: Keerthy > >> --- > >> > >> Changes in v3: > >> > >> * Fixed errors seen with: > >> dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/thermal/ti,am654-thermal.yaml > >> > >> .../bindings/thermal/ti,am654-thermal.yaml | 57 +++++++++++++++++++ > >> 1 file changed, 57 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/thermal/ti,am654-thermal.yaml > >> > >> diff --git a/Documentation/devicetree/bindings/thermal/ti,am654-thermal.yaml b/Documentation/devicetree/bindings/thermal/ti,am654-thermal.yaml > >> new file mode 100644 > >> index 000000000000..b6dc95c3acab > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/thermal/ti,am654-thermal.yaml > >> @@ -0,0 +1,57 @@ > >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/thermal/ti,am654-thermal.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: Texas Instruments AM654 VTM (DTS) binding > >> + > >> +maintainers: > >> + - Keerthy > >> + > >> +properties: > >> + compatible: > >> + const: ti,am654-vtm > >> + > >> + reg: > >> + maxItems: 1 > >> + > >> + power-domains: > >> + maxItems: 1 > >> + description: phandle to the associated power domain > > > > No need to redefine a standard property description. > > Okay. > > > > >> + > >> + "#thermal-sensor-cells": > >> + const: 1 > >> + > >> +required: > >> + - "#thermal-sensor-cells" > >> + - compatible > >> + - reg > >> + - power-domains > >> + > >> +additionalProperties: false > >> + > >> +examples: > >> + - | > >> + #include > >> + vtm: wkup_vtm0@42050000 { > > > > thermal-sensor@... > > > > Use generic node names and don't use '_' in node names > > vtm stands for voltage thermal manager and comprises of multiple > sensors. This is similar to omap bandgap. Should i replace vtm with more > generic name like thermal? as used in: 'vtm' is a label and source construct only (until you do overlays), so I don't care what you put really. Rob