From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78CC6C00449 for ; Fri, 5 Oct 2018 18:32:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 357ED21477 for ; Fri, 5 Oct 2018 18:32:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="OiZ+idpX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 357ED21477 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728639AbeJFBcr (ORCPT ); Fri, 5 Oct 2018 21:32:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:41706 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728044AbeJFBcr (ORCPT ); Fri, 5 Oct 2018 21:32:47 -0400 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 83E50214C1; Fri, 5 Oct 2018 18:32:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1538764371; bh=L7aZR9bc4bx416Kcx3JUEW4vGf0RwmDJdJ0uKLgpASM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=OiZ+idpX4QxLI1Wnukl67lLVJZRlzobgRIT3DdYu+vZpOcs+5F4sbx5yBgYS1iHme qrKrX42KtQbvdMmuvtM3FC1z33iXHocjtp5JJwmaQ2uEqeghyI/Ow14oZdRDPERZXf QOPeCZQqc88ZZ4+irO2SbHAu3S4ATdnGgSP7AOGM= Received: by mail-qt1-f174.google.com with SMTP id l9-v6so14825972qtf.5; Fri, 05 Oct 2018 11:32:51 -0700 (PDT) X-Gm-Message-State: ABuFfogpo9puoqE1EtWkRk/29BkV7q/mD5cJ8pt5+nq79YD12Oroggku K/w6BioRG8mkZNFH8Zoonkf3MzldY0fk91SxvA== X-Google-Smtp-Source: ACcGV63HX2zbcJlDZAtDgJDXMEzwREemvWoN9VcT34aMnZvXQt0FQ7Z1xKkSE7QN8Ct0AKR4OfbEHGIsu7eP+q5/xEY= X-Received: by 2002:ac8:148b:: with SMTP id l11-v6mr10739551qtj.27.1538764370602; Fri, 05 Oct 2018 11:32:50 -0700 (PDT) MIME-Version: 1.0 References: <20181005165848.3474-1-robh@kernel.org> <20181005165848.3474-20-robh@kernel.org> <20181005180725.GH5626@piout.net> In-Reply-To: <20181005180725.GH5626@piout.net> From: Rob Herring Date: Fri, 5 Oct 2018 13:32:38 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 19/36] dt-bindings: arm: Convert Atmel board/soc bindings to json-schema To: Alexandre Belloni Cc: "linux-kernel@vger.kernel.org" , devicetree@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linuxppc-dev , Grant Likely , Kumar Gala , Frank Rowand , Mark Rutland , Linus Walleij , Olof Johansson , Arnd Bergmann , Mark Brown , Tom Rini , Pantelis Antoniou , Geert Uytterhoeven , Jonathan Cameron , Bjorn Andersson , Nicolas Ferre Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 5, 2018 at 1:07 PM Alexandre Belloni wrote: > > Hello, > > On 05/10/2018 11:58:31-0500, Rob Herring wrote: > > diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml > > new file mode 100644 > > index 000000000000..f788315b94fa > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml > > @@ -0,0 +1,132 @@ > > +# SPDX-License-Identifier: None > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/bindings/arm/atmel-at91.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Atmel AT91 device tree bindings. > > + > > +maintainers: > > + - Alexandre Belloni > > + - Jean-Christophe PLAGNIOL-VILLARD > > Jean-Christophe has not been active for years, I'd mention Ludovic > instead. Will update. I generated these out of git log. I didn't use get_maintainers.pl because it seems lots of files don't have maintainers listed (other than Mark and me) and I didn't want to be it. > > > +description: | > > + Boards with a SoC of the Atmel AT91 or SMART family shall have the following > > + > > +properties: > > + $nodename: > > + const: '/' > > + compatible: > > + oneOf: > > + - items: > > + - const: atmel,at91rm9200 > > + - items: > > + - enum: > > + - olimex,sam9-l9260 > > + - enum: > > + - atmel,at91sam9260 > > + - atmel,at91sam9261 > > + - atmel,at91sam9263 > > + - atmel,at91sam9g20 > > + - atmel,at91sam9g45 > > + - atmel,at91sam9n12 > > + - atmel,at91sam9rl > > + - atmel,at91sam9xe > > + - const: atmel,at91sam9 > > + > > + - items: > > + - enum: > > + - atmel,at91sam9g15 > > + - atmel,at91sam9g25 > > + - atmel,at91sam9g35 > > + - atmel,at91sam9x25 > > + - atmel,at91sam9x35 > > + - const: atmel,at91sam9x5 > > + - const: atmel,at91sam9 > > + > > + - items: > > + - const: atmel,sama5d27 > > + - const: atmel,sama5d2 > > + - const: atmel,sama5 > > + > > + - description: Nattis v2 board with Natte v2 power board > > + items: > > + - const: axentia,nattis-2 > > + - const: axentia,natte-2 > > + - const: axentia,linea > > Shouldn't we have the board specific compatibles in a separate file to > avoid mixing everything with the SoC compatibles? You can't validate it that way. I have to say "must be compatible A, B, C and in that order" and you can't if A, B, and C are in different files. We could do board vendor files, but then we have to duplicate the SoC compatibles. I don't think there's any board vendor with enough boards to justify that. The only place I've found that the compatible lists get kind of messy is when platforms have a variable number of compatible strings. We generally have not split things this way for most platforms except i.MX which this series changes. Looks like I forgot to remove the axentia.txt for Atmel. Rob