From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754944AbdKIXGt (ORCPT ); Thu, 9 Nov 2017 18:06:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:57774 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537AbdKIXGr (ORCPT ); Thu, 9 Nov 2017 18:06:47 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86DC621986 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh+dt@kernel.org X-Google-Smtp-Source: AGs4zMbHCfkOqvgw6BsZggzVEqdlBZ60B92JEGyyic8xuPZTSbUD5UP0bXJdZc994qX5p4SQVI4xxbFoBn8Pp71l1Mc= MIME-Version: 1.0 In-Reply-To: References: <1509859853-27473-1-git-send-email-yamada.masahiro@socionext.com> <1509859853-27473-2-git-send-email-yamada.masahiro@socionext.com> <20171106095139.GG15260@jhogan-linux> From: Rob Herring Date: Thu, 9 Nov 2017 17:06:25 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] MIPS: dts: remove bogus bcm96358nb4ser.dtb from dtb-y entry To: Masahiro Yamada Cc: James Hogan , "devicetree@vger.kernel.org" , Linux Kbuild mailing list , Mark Rutland , Pantelis Antoniou , linux-arm-kernel , Arnd Bergmann , Linux Kernel Mailing List , Michal Marek , Sam Ravnborg , Ralf Baechle , Linux-MIPS , Kevin Cernekee , Florian Fainelli Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 8, 2017 at 6:38 PM, Masahiro Yamada wrote: > 2017-11-09 9:11 GMT+09:00 Masahiro Yamada : >> 2017-11-09 1:51 GMT+09:00 Rob Herring : >>> On Mon, Nov 6, 2017 at 5:00 AM, Masahiro Yamada >>> wrote: >>>> 2017-11-06 19:41 GMT+09:00 James Hogan : >>>>> Hi, >>>>> >>>>> On Sun, Nov 05, 2017 at 11:11:38PM +0900, Masahiro Yamada wrote: >>>>>> +CC Ralf Baechle >>>>>> +CC linux-mips@linux-mips.org >>>>>> +CC Kevin Cernekee >>>>>> +CC Florian Fainelli >>>>>> >>>>>> >>>>>> I missed to CC MIPS maintainers. >>>>> >>>>> Yes, please resend the patch so it lands in patchwork.linux-mips.org. >>>> >>>> >>>> This is a part of clean-up series of DT building. >>>> >>>> I want Acked-by from MIPS maintainers >>>> so that the whole series can go to a different tree. >>>> (DT or Kbuild). >>>> >>>> >>>> Sam addressed more clean-up candidates in MIPS Makefiles >>>> https://patchwork.kernel.org/patch/10041879/ >>>> >>>> So, I will probably end up with touching those Makefiles more. >>>> >>>> All patches must go to the same tree. >>>> >>>> >>>>>> 2017-11-05 14:30 GMT+09:00 Masahiro Yamada : >>>>>> > arch/mips/boot/dts/brcm/bcm96358nb4ser.dts does not exist, so >>>>>> > we cannot build bcm96358nb4ser.dtb . >>>>> >>>>> This appears to be due to the file being renamed in commit 695835511f96 >>>>> ("MIPS: BMIPS: rename bcm96358nb4ser to bcm6358-neufbox4-sercom"). >>>>> Please can you update the commit message when you resend to mention the >>>>> cause of the problem. >>>>> >>>>> You could also add the following if you like while you're at it: >>>>> >>>>> Fixes: 695835511f96 ("MIPS: BMIPS: rename bcm96358nb4ser to bcm6358-neufbox4-sercom") >>>>> Cc: # 4.9+ >>> >>> I think this one can be applied independently and we'd want it to if >>> we tag for stable. So I think it can go thru the MIPS tree. >>> >> >> >> As I said to MIPS folks, this patch must go before 2/2. >> >> You picked up only 2/2, so your dt/kbuild branch is broken. >> >> >> make ARCH=mips allyesconfig >> && make ARCH=mips CROSS_COMPILE=mips-linux- dtbs >> >> >> will produce the following error. >> >> >> make[2]: *** No rule to make target >> 'arch/mips/boot/dts/brcm/bcm96358nb4ser.dtb', needed by '__build'. >> Stop. >> scripts/Makefile.build:570: recipe for target 'arch/mips/boot/dts/brcm' failed >> make[1]: *** [arch/mips/boot/dts/brcm] Error 2 >> arch/mips/Makefile:413: recipe for target 'dtbs' failed >> make: *** [dtbs] Error 2 >> > > > Looking into it, probably > bmips_dtb_defconfig was already broken regardless my patches. > > But, I am not comfortable with breaking all{yes,mod}config > because they are often used for build test. > > > I hope you can apply this in the order as I sent, > with the following tag. > > Fixes: 695835511f96 ("MIPS: BMIPS: rename bcm96358nb4ser to > bcm6358-neufbox4-sercom") > Cc: # 4.9+ Okay, now applied. Rob