From: Rob Herring <robh@kernel.org>
To: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Russell King <linux@armlinux.org.uk>,
Olof Johansson <olof@lixom.net>, Lee Jones <lee.jones@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/7] includes: dt-bindings: Rename STM32F429 pinctrl DT bindings
Date: Wed, 14 Jun 2017 08:05:52 -0500 [thread overview]
Message-ID: <CAL_JsqJHFmamtr_o852fsbzq2S6V0i+xWi62=3HJ0w5F=3SG6g@mail.gmail.com> (raw)
In-Reply-To: <832cd436-0704-3709-ba2c-2c1f6db48615@st.com>
On Wed, Jun 7, 2017 at 11:35 AM, Alexandre Torgue
<alexandre.torgue@st.com> wrote:
> Hi Rob,
>
> Gentle ping.
>
> On 04/12/2017 03:31 PM, Alexandre Torgue wrote:
>>
>> Hi Rob,
>>
>> On 04/10/2017 10:27 PM, Rob Herring wrote:
>>>
>>> On Fri, Apr 07, 2017 at 02:43:00PM +0200, Alexandre TORGUE wrote:
>>>>
>>>> STM32F4 MCU series is composed of several SOC (STM32F429, STM32F469,
>>>> ...).
>>>> Most of muxing definition are identical. So to avoid to duplicate
>>>> bindings
>>>> definition, this patch create common definitions.
>>>
>>>
>>> This is a lot of churn. Some confirmation that the resultant dtb is the
>>> same before and after would be nice. Perhaps the script you used to
>>> convert this as well.
>>
>>
>> I tried to use fdtdump but it seems bugged. So I used directly dtc
>> binary to (re)generate dts files (before and after apply the series) and
>> I compared "pinmux" field in both case.
>>
>> Example on stm32f469-disco:
>>
>> ./scripts/dtc/dtc -I dtb -O dts -o stm32f469-disco-after.dts
>> stm32f469-disco-after.dtb
>>
>> ./scripts/dtc/dtc -I dtb -O dts -o stm32f469-disco-before.dts
>> stm32f469-disco-before.dtb
>>
>> cat stm32f469-disco-after.dts | grep pinmux
>> cat stm32f469-disco-before.dts | grep pinmux
>>
>
> Do you agree with verifications ?
I would expect you do "diff -u stm32f469-disco-before.dts
stm32f469-disco-after.dts".
Rob
next prev parent reply other threads:[~2017-06-14 13:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 12:42 [PATCH v2 0/7] Add STM32F469 pinctrl and fix issues in STM32 pinctrl Alexandre TORGUE
2017-04-07 12:42 ` [PATCH v2 1/7] pinctrl: stm32: add possibility to use gpio-ranges to declare bank range Alexandre TORGUE
2017-04-24 12:20 ` Linus Walleij
2017-04-07 12:42 ` [PATCH v2 2/7] Documentation: dt: Remove bindings for STM32 pinctrl Alexandre TORGUE
2017-04-10 20:20 ` Rob Herring
2017-04-12 13:24 ` Alexandre Torgue
2017-04-24 12:25 ` Linus Walleij
2017-04-07 12:43 ` [PATCH v2 3/7] includes: dt-bindings: Rename STM32F429 pinctrl DT bindings Alexandre TORGUE
2017-04-10 20:27 ` Rob Herring
2017-04-12 13:31 ` Alexandre Torgue
2017-06-07 16:35 ` Alexandre Torgue
2017-06-14 13:05 ` Rob Herring [this message]
2017-04-07 12:43 ` [PATCH v2 4/7] pinctrl: stm32: Add STM32F469 MCU support Alexandre TORGUE
2017-04-24 12:27 ` Linus Walleij
2017-04-07 12:43 ` [PATCH v2 5/7] Documentation: dt: Add new compatible to STM32 pinctrl driver bindings Alexandre TORGUE
2017-04-10 20:30 ` Rob Herring
2017-04-24 12:29 ` Linus Walleij
2017-04-07 12:43 ` [PATCH v2 6/7] ARM: Kconfig: Introduce MACH_STM32F469 flag Alexandre TORGUE
2017-04-24 12:30 ` Linus Walleij
2017-04-24 16:06 ` Alexandre Torgue
2017-04-07 12:43 ` [PATCH v2 7/7] ARM: dts: stm32: create dedicated files for pinctrl definitions Alexandre TORGUE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqJHFmamtr_o852fsbzq2S6V0i+xWi62=3HJ0w5F=3SG6g@mail.gmail.com' \
--to=robh@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).