From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934845AbcLMVJu (ORCPT ); Tue, 13 Dec 2016 16:09:50 -0500 Received: from mail.kernel.org ([198.145.29.136]:51082 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752343AbcLMVJs (ORCPT ); Tue, 13 Dec 2016 16:09:48 -0500 MIME-Version: 1.0 In-Reply-To: References: <20161209062833.5768-1-woogyom.kim@gmail.com> <20161209062833.5768-3-woogyom.kim@gmail.com> <20161212172511.5nj7whzytpkmrk7z@rob-hp-laptop> From: Rob Herring Date: Tue, 13 Dec 2016 15:09:23 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/4] dt-bindings: mfd: Remove TPS65217 interrupts To: Milo Kim Cc: Arnd Bergmann , Benoit Cousson , Tony Lindgren , Lee Jones , Sebastian Reichel , Dmitry Torokhov , linux-omap , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 12, 2016 at 5:24 PM, Milo Kim wrote: > On 12/13/2016 02:25 AM, Rob Herring wrote: >> >> On Fri, Dec 09, 2016 at 03:28:31PM +0900, Milo Kim wrote: >>> >>> Interrupt numbers are from the datasheet, so no need to keep them in >>> the ABI. Use the number in the DT file. >> >> I don't see the purpose of ripping this out. The headers have always >> been for convienence, not whether the values come from the datasheet or >> not. > > > My understanding is it's a same rule as other interrupt controllers. Oh yes, that's true. We never use defines for interrupts. In that case: Acked-by: Rob Herring Rob