From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26AD0C433E0 for ; Wed, 23 Dec 2020 17:55:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6C0A20E65 for ; Wed, 23 Dec 2020 17:55:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727591AbgLWRzV (ORCPT ); Wed, 23 Dec 2020 12:55:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:60102 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726396AbgLWRzU (ORCPT ); Wed, 23 Dec 2020 12:55:20 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id CDF56222BB; Wed, 23 Dec 2020 17:54:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1608746080; bh=oPqcaaIT1m4gIwPH079KHo8KUmZzg7kgDIJDYuGMcvY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bGpft4Kpb7t5T4fX8lhByN60ObxwL55nWpJzhHIelAITSWX0bvXmtegxYSTJN4Zxl T4sw2s1rmwoiwLPiUIW7JGyIM7tfyWPnaZisRDvAs56K9bnVV2r258Zllrq3efIw60 Xqk7ptA15HCr4vleatHRwHYA+XPQo+P9s0tUyVvqfM28vAKVchNYK9O9jkO7C/YG3J N3N0SD38qtziXLRLBOdDTI40f9Ewmzt3R/AhxsHnnvnilbxQYSPWroVyn6u2P8sFfD AHY6JNQEDjZCOeioDkjceA8EfiEeZB5mmjnxg6UiXX0BLHhkUQ1hp7GaO94jA5tBIo 4fWkBpGhcIocg== Received: by mail-ej1-f50.google.com with SMTP id qw4so223776ejb.12; Wed, 23 Dec 2020 09:54:39 -0800 (PST) X-Gm-Message-State: AOAM533Ut4SxzECyeT7Irb9wI1UpolSpZIkcrMPdrYgXBjbjJfDL0aSh XEYerjstm6eVqVJ00yWnDMjwnOmvxmDlY8/b9g== X-Google-Smtp-Source: ABdhPJz3x4J2zw5Y7TPch4DTKXpgAX9t6V701Sxc80NsHgTOESjuz9DoVFaywy8F4VyXHmox/Q09SCSZQsxP2YotFOM= X-Received: by 2002:a17:906:4146:: with SMTP id l6mr25366789ejk.341.1608746078387; Wed, 23 Dec 2020 09:54:38 -0800 (PST) MIME-Version: 1.0 References: <20201222040645.1323611-1-robh@kernel.org> <20201222063908.GB3463004@ravnborg.org> In-Reply-To: <20201222063908.GB3463004@ravnborg.org> From: Rob Herring Date: Wed, 23 Dec 2020 10:54:26 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] dt-bindings: Drop redundant maxItems/items To: Sam Ravnborg Cc: devicetree@vger.kernel.org, Linux-ALSA , Greg Kroah-Hartman , Linux USB List , "linux-kernel@vger.kernel.org" , dri-devel , Jassi Brar , Vinod Koul , Mark Brown , Laurent Pinchart , "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 21, 2020 at 11:39 PM Sam Ravnborg wrote: > > Hi Rob, > > On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote: > > 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is > > preferred for a single entry while greater than 1 should have an 'items' > > list. > > > > A meta-schema check for this is pending once these existing cases are > > fixed. > > > > Cc: Laurent Pinchart > > Cc: Vinod Koul > > Cc: Mark Brown > > Cc: Greg Kroah-Hartman > > Cc: Jassi Brar > > Cc: dri-devel@lists.freedesktop.org > > Cc: dmaengine@vger.kernel.org > > Cc: alsa-devel@alsa-project.org > > Cc: linux-usb@vger.kernel.org > > Signed-off-by: Rob Herring > > With one comment below, > Acked-by: Sam Ravnborg > > > --- > > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > index 737c1f47b7de..54c361d4a7af 100644 > > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > @@ -74,11 +74,8 @@ properties: > > > > phys: > > maxItems: 1 > > - items: > > - - description: phandle + phy specifier pair. > > The description may help some people, so keeping the > description and deleting maxItems would maybe be better. Do we really want to describe 'phys' hundreds of times? No. The question I ask on the descriptions is could it be generated instead. Rob