From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754572AbbLFUkZ (ORCPT ); Sun, 6 Dec 2015 15:40:25 -0500 Received: from mail.kernel.org ([198.145.29.136]:41677 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754448AbbLFUkX (ORCPT ); Sun, 6 Dec 2015 15:40:23 -0500 MIME-Version: 1.0 In-Reply-To: <1448864059-12319-1-git-send-email-yamada.masahiro@socionext.com> References: <1448864059-12319-1-git-send-email-yamada.masahiro@socionext.com> From: Rob Herring Date: Sun, 6 Dec 2015 14:40:01 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] of/address: replace printk(KERN_ERR ...) with pr_err(...) To: Masahiro Yamada Cc: "devicetree@vger.kernel.org" , Frank Rowand , "linux-kernel@vger.kernel.org" , Grant Likely Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 30, 2015 at 12:14 AM, Masahiro Yamada wrote: > A trivial change suggested by checkpatch.pl. You might as well all levels while you are at it. Looks like that is only one more: drivers/of/address.c: printk(KERN_DEBUG "%s", s); Rob > > Signed-off-by: Masahiro Yamada > --- > > drivers/of/address.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/address.c b/drivers/of/address.c > index cd53fe4..5289c80 100644 > --- a/drivers/of/address.c > +++ b/drivers/of/address.c > @@ -596,7 +596,7 @@ static u64 __of_translate_address(struct device_node *dev, > pbus = of_match_bus(parent); > pbus->count_cells(dev, &pna, &pns); > if (!OF_CHECK_COUNTS(pna, pns)) { > - printk(KERN_ERR "prom_parse: Bad cell count for %s\n", > + pr_err("prom_parse: Bad cell count for %s\n", > of_node_full_name(dev)); > break; > } > -- > 1.9.1 >