From: Rob Herring <robh+dt@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Frank Rowand <frowand.list@gmail.com>,
Grant Likely <grant.likely@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Subject: Re: [PATCH][RESEND v2] of: add missing const for of_parse_phandle_with_args() in !CONFIG_OF
Date: Wed, 8 Jun 2016 08:42:49 -0500 [thread overview]
Message-ID: <CAL_JsqJObynzqD1Ezo+7=cP8TPDnd1MDLYyoeE8At9mGsY1tFw@mail.gmail.com> (raw)
In-Reply-To: <87r3cf7z5a.wl%kuninori.morimoto.gx@renesas.com>
On Thu, Jun 2, 2016 at 10:09 PM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
> Hi Rob
>
> Should I re-send this patch ?
> It still no response...
Sorry, for the delay. Now applied.
Rob
>
>> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>>
>> commit 93c667ca2598bd84f1bd3f2fa176af69707699fe
>> ("of: *node argument to of_parse_phandle_with_args should be const")
>> changed to const for struct device node *np,
>> but it cares CONFIG_OF case only, !CONFIG_OF case need it too.
>>
>> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>> ---
>> include/linux/of.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/of.h b/include/linux/of.h
>> index 7fcb681..4f2ce1b 100644
>> --- a/include/linux/of.h
>> +++ b/include/linux/of.h
>> @@ -585,7 +585,7 @@ static inline struct device_node *of_parse_phandle(const struct device_node *np,
>> return NULL;
>> }
>>
>> -static inline int of_parse_phandle_with_args(struct device_node *np,
>> +static inline int of_parse_phandle_with_args(const struct device_node *np,
>> const char *list_name,
>> const char *cells_name,
>> int index,
>> --
>> 1.9.1
>>
prev parent reply other threads:[~2016-06-08 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 1:15 [PATCH][RESEND v2] of: add missing const for of_parse_phandle_with_args() in !CONFIG_OF Kuninori Morimoto
2016-06-03 3:09 ` Kuninori Morimoto
2016-06-08 13:42 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqJObynzqD1Ezo+7=cP8TPDnd1MDLYyoeE8At9mGsY1tFw@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=g.liakhovetski@gmx.de \
--cc=grant.likely@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).