From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756480AbcLNQtY (ORCPT ); Wed, 14 Dec 2016 11:49:24 -0500 Received: from mail.kernel.org ([198.145.29.136]:45544 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753753AbcLNQtW (ORCPT ); Wed, 14 Dec 2016 11:49:22 -0500 MIME-Version: 1.0 In-Reply-To: <20161214163253.GA25341@nathan3500-linux-VM> References: <1480693329-22265-1-git-send-email-nathan.sullivan@ni.com> <20161209211828.dykl2l4kmthqgq6e@rob-hp-laptop> <20161214163253.GA25341@nathan3500-linux-VM> From: Rob Herring Date: Wed, 14 Dec 2016 10:48:58 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] MIPS: NI 169445 board support To: Nathan Sullivan Cc: Ralf Baechle , Mark Rutland , Linux-MIPS , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 14, 2016 at 10:32 AM, Nathan Sullivan wrote: > On Fri, Dec 09, 2016 at 03:18:28PM -0600, Rob Herring wrote: >> On Fri, Dec 02, 2016 at 09:42:09AM -0600, Nathan Sullivan wrote: >> > Support the National Instruments 169445 board. >> > >> > Signed-off-by: Nathan Sullivan >> > --- >> > "gpio: mmio: add support for NI 169445 NAND GPIO" and >> > "devicetree: add vendor prefix for National Instruments" are required for the >> > NAND on this board to work. >> > + ahb@0 { >> > + compatible = "simple-bus"; >> > + #address-cells = <1>; >> > + #size-cells = <1>; >> > + ranges; >> >> If everything is under 0x1f3xxxxx, then add in the ranges here (and the >> unit address). >> > > I noticed that some systems call out their axi/ahb busses, some do not. Would > you prefer that I remove the bus entirely? Definitely not. IMO, not having a bus node is an error. Rob