From: Rob Herring <robh+dt@kernel.org>
To: Kevin Tang <kevin3.tang@gmail.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>, Sean Paul <sean@poorly.run>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Mark Rutland <mark.rutland@arm.com>,
Orson Zhai <orsonzhai@gmail.com>,
Lyra Zhang <zhang.lyra@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/6] dt-bindings: display: add Unisoc's drm master bindings
Date: Tue, 1 Dec 2020 10:36:54 -0700 [thread overview]
Message-ID: <CAL_JsqJQE0-ScESutDd950GEac+w0KhzGcLv+_jb1xuVs6DQXw@mail.gmail.com> (raw)
In-Reply-To: <CAFPSGXZLXh__GuXT2NPqF0jpO2DnMAhz+NtE721EZfMCSKLBjQ@mail.gmail.com>
On Tue, Dec 1, 2020 at 12:36 AM Kevin Tang <kevin3.tang@gmail.com> wrote:
>
> Hi Rob
>
> Rob Herring <robh+dt@kernel.org> 于2020年12月1日周二 上午4:29写道:
> >
> > On Mon, Nov 30, 2020 at 7:28 AM Kevin Tang <kevin3.tang@gmail.com> wrote:
> > >
> > > From: Kevin Tang <kevin.tang@unisoc.com>
> >
> > Once again, DT patches must Cc the DT list if you want them reviewed.
> Ok, i will add DT list to my Cc list.
> >
> > >
> > > The Unisoc DRM master device is a virtual device needed to list all
> > > DPU devices or other display interface nodes that comprise the
> > > graphics subsystem
> > >
> > > Cc: Orson Zhai <orsonzhai@gmail.com>
> > > Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> > > Signed-off-by: Kevin Tang <kevin.tang@unisoc.com>
> > > ---
> > > .../display/sprd/sprd,display-subsystem.yaml | 39 ++++++++++++++++++++++
> > > 1 file changed, 39 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/display/sprd/sprd,display-subsystem.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/sprd/sprd,display-subsystem.yaml b/Documentation/devicetree/bindings/display/sprd/sprd,display-subsystem.yaml
> > > new file mode 100644
> > > index 0000000..9487a39
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/display/sprd/sprd,display-subsystem.yaml
> > > @@ -0,0 +1,39 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/display/sprd/sprd,display-subsystem.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Unisoc DRM master device
> > > +
> > > +maintainers:
> > > + - Kevin Tang <kevin.tang@unisoc.com>
> > > +
> > > +description: |
> > > + The Unisoc DRM master device is a virtual device needed to list all
> > > + DPU devices or other display interface nodes that comprise the
> > > + graphics subsystem.
> > > +
> > > +properties:
> > > + compatible:
> > > + const: sprd,display-subsystem
> >
> > As I said before, we try to avoid these virtual nodes. Make the DRM
> > driver bind to the DPU node.
> >
> > The case where this might be needed is if you have h/w that's a
> > mixture of shared and discrete blocks. I don't see anything here
> > matching that.
>
> This is how I understand this sentence: "h/w that's a mixture of shared and discrete blocks"
> We have multiple display controllers and corresponding physical interfaces, typical dual-screen display scenario
> E.g:
> 1. dpu0 and dpu1 both binding to DSI for dual mipi-dsi display;
> 2. dpu0 binding to DSI for primary display, and dpu1 binding to DP for external display;
>
> It looks like this:
> dpu0------>MIPI-DSI------>DPHY/CPHY Combo------>Panel0
> ^
> ----------------|
> |
> dpu1------>DisplayPort------>PHY------>Panel1
>
> For DTS like this:
> display-subsystem {
> compatible = "sprd,display-subsystem";
> ports = <&dpu0_out>, <&dpu1_out>;
> };
Yeah, this would be one such case. Just make this scenario clear in
commit message.
Rob
next prev parent reply other threads:[~2020-12-01 17:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 14:28 [PATCH 0/6] Add Unisoc's drm kms module Kevin Tang
2020-11-30 14:28 ` [PATCH 1/6] dt-bindings: display: add Unisoc's drm master bindings Kevin Tang
2020-11-30 20:29 ` Rob Herring
[not found] ` <CAFPSGXZLXh__GuXT2NPqF0jpO2DnMAhz+NtE721EZfMCSKLBjQ@mail.gmail.com>
2020-12-01 17:36 ` Rob Herring [this message]
2020-11-30 14:28 ` [PATCH 2/6] drm/sprd: add Unisoc's drm kms master Kevin Tang
2020-11-30 14:28 ` [PATCH 3/6] dt-bindings: display: add Unisoc's dpu bindings Kevin Tang
2020-11-30 14:28 ` [PATCH 4/6] drm/sprd: add Unisoc's drm display controller driver Kevin Tang
2020-11-30 14:28 ` [PATCH 5/6] dt-bindings: display: add Unisoc's mipi dsi&dphy bindings Kevin Tang
2020-11-30 20:31 ` Rob Herring
[not found] ` <CAFPSGXYwHyF7xEpc-OiVtpSOKiorRO=jGGftKArK-NeGDGMvdw@mail.gmail.com>
2020-12-01 17:34 ` Rob Herring
2020-11-30 14:28 ` [PATCH 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver Kevin Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJQE0-ScESutDd950GEac+w0KhzGcLv+_jb1xuVs6DQXw@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kevin3.tang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=orsonzhai@gmail.com \
--cc=sean@poorly.run \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).