From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4B08C433E4 for ; Mon, 22 Mar 2021 17:36:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82D3561998 for ; Mon, 22 Mar 2021 17:36:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231593AbhCVRgV (ORCPT ); Mon, 22 Mar 2021 13:36:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:48082 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231365AbhCVRgP (ORCPT ); Mon, 22 Mar 2021 13:36:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0770361994; Mon, 22 Mar 2021 17:36:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616434575; bh=VdW4om2AyPCfqy4wAovCR7HUVEe2frovxQ0Cc8nEk7s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Mh9yoSTNMWrpBFxp7mRAqgfTfZOlph3dYZnhso+XBF99dtzEHkgBu1YOy2DccLzzn fUylSmXKjiXNkdvZx/WKnjEV+5GnHZAVRPf8FAuQ+FX2zNlEFwMnVuBx3/7QcHBGRR VmCt4+L4cInUjBNq78zxXp4FBDQOleC4/KxA9aQVsnHM3Zt5q+sPQ+9++fOCLAChGA ZrbBCoyVviPqoFFBHsivxNrK5fArDQmqAhFcrkwkX3XZuyzri6iX5TjfgUyKO2BGWn +jNA3cIftCwjS8BGd8BxZpoBiA5+h4IHlX0hKg0akAFueiGgUW8oqUusCrgeyLdw+R NAjf6bEHS7S5w== Received: by mail-ed1-f45.google.com with SMTP id z1so20406691edb.8; Mon, 22 Mar 2021 10:36:14 -0700 (PDT) X-Gm-Message-State: AOAM531IT0C8EmZXdUdl2/O0RfqM2n+Belt7+onRvizq6QDIQphW2JSP Rz4HTlybecblpmqZzlLW4FYCCmlGZgWGlIDeSg== X-Google-Smtp-Source: ABdhPJx2NmuQG0Y5DzdS5+450riDgemRYrFCSvVWhwcs0YPSA/NP54tZmFoCyKBJEdQ1WhL/o13t1FITdk/T511dQts= X-Received: by 2002:aa7:c403:: with SMTP id j3mr718221edq.137.1616434573540; Mon, 22 Mar 2021 10:36:13 -0700 (PDT) MIME-Version: 1.0 References: <1599734644-4791-1-git-send-email-sagar.kadam@sifive.com> <1599734644-4791-3-git-send-email-sagar.kadam@sifive.com> <20200922203429.GA3188204@bogus> In-Reply-To: From: Rob Herring Date: Mon, 22 Mar 2021 11:36:01 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 2/3] dt-bindings: riscv: convert plic bindings to json-schema To: Geert Uytterhoeven Cc: Sagar Kadam , Linux PWM List , Linux Kernel Mailing List , linux-riscv , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-clk , Michael Turquette , Stephen Boyd , Paul Walmsley , Palmer Dabbelt , Thomas Gleixner , Jason Cooper , Marc Zyngier , Thierry Reding , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Lee Jones , Albert Ou , Yash Shah Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 22, 2021 at 9:38 AM Geert Uytterhoeven wrote: > > Hi Sagar, Rob, > > (replying to an old email, as this one seems to be the most appropriate) > > On Tue, Sep 22, 2020 at 10:34 PM Rob Herring wrote: > > On Thu, Sep 10, 2020 at 04:14:03PM +0530, Sagar Kadam wrote: > > > Convert device tree bindings for SiFive's PLIC to YAML format > > > > > > Signed-off-by: Sagar Kadam > > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > > > > + > > > + '#address-cells': > > > + const: 0 > > > + description: Should be <0> or more. > > > > Drop. 'or more' is wrong. If there's a case with more, it will need to > > be documented. > > Why do we have the "'#address-cells': const: 0" at all... > > > > +required: > > > + - compatible > > > + - '#address-cells' > > ... and why is it required? It is only required if an 'interrupt-map' points to this node. Currently dtc is warning if it is missing always, but there are plans to relax dtc to only warn when 'interrupt-map' is present. Of course, if you had 'interrupt-map' in an overlay, you'd want #address-cells in the base dt and there's no other way to check that than making it required. Rob