From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D878AC35E0E for ; Tue, 25 Feb 2020 20:35:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B0D6721744 for ; Tue, 25 Feb 2020 20:35:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582662920; bh=IlMHPJZoi6qlavWG4Ahbm3IprtnpXIxML8X3NnRiesw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=z5PEJU+CHSb27ZkCkhmfwmFmN2dBE+jq8E/ee1kitxSOtWBwonlMQI5AbFCftlCCK tdkP73Wtp/ZmrL/VWqCTWZ4ThavrbLKDPeNNaKYsRUTpP1i4rhUCkH8EUSYniprMXD mBt5gbGOA4tdZiGWp0cYCKqAB1cyjSRzRanUPDCc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730837AbgBYUfT (ORCPT ); Tue, 25 Feb 2020 15:35:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:54950 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728471AbgBYUfS (ORCPT ); Tue, 25 Feb 2020 15:35:18 -0500 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4BFD7222C2; Tue, 25 Feb 2020 20:35:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582662918; bh=IlMHPJZoi6qlavWG4Ahbm3IprtnpXIxML8X3NnRiesw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=M/zmMhCkKG5ZR2aALAAcDqwXx55QaZ79a6R/kP7ncLhvfpPHN14IL07ANpCOk/KqL osvvkEIyAzlIUNoWzB9MFSu4Mzp/XQ0NZA31wZHfw19OqWb3jgSh+XeQHJsnDnOcTS kP8Q5MyOjKWvQsQjsJ4mhFk7dYdaIU4SDmwTej1w= Received: by mail-qt1-f171.google.com with SMTP id n17so639642qtv.2; Tue, 25 Feb 2020 12:35:18 -0800 (PST) X-Gm-Message-State: APjAAAX1TllHXwqZ854CKUUURj5Y1mwvS1MphfaBl0YTkxR+I5G+6ERy ZUJsqVg6At8emjo32/T1hkz6J7oH2uZToZHifA== X-Google-Smtp-Source: APXvYqxghQYLQ6PnllHaIfdR/E6y+DaIAu6c0wU88JtyBWhTwo7n81Ke2zCDhWVpQ1z8bFO/Ygmz9cAyLAvnFp0aF5U= X-Received: by 2002:ac8:1415:: with SMTP id k21mr568504qtj.300.1582662917307; Tue, 25 Feb 2020 12:35:17 -0800 (PST) MIME-Version: 1.0 References: <20200207052627.130118-1-drinkcat@chromium.org> In-Reply-To: <20200207052627.130118-1-drinkcat@chromium.org> From: Rob Herring Date: Tue, 25 Feb 2020 14:35:05 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 0/7] Add dts for mt8183 GPU (and misc panfrost patches) To: Nicolas Boichat Cc: David Airlie , Daniel Vetter , Mark Rutland , Matthias Brugger , Tomeu Vizoso , Steven Price , Alyssa Rosenzweig , Liam Girdwood , Mark Brown , dri-devel , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "moderated list:ARM/Mediatek SoC support" , Hsin-Yi Wang , Ulf Hansson Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 6, 2020 at 11:26 PM Nicolas Boichat wrote: > > Hi! > > Follow-up on the v3: https://patchwork.kernel.org/cover/11331343/. > > The main purpose of this series is to upstream the dts change and the > binding document, but I wanted to see how far I could probe the GPU, to > check that the binding is indeed correct. The rest of the patches are > RFC/work-in-progress, but I think some of them could already be picked up. > > So this is tested on MT8183 with a chromeos-4.19 kernel, and a ton of > backports to get the latest panfrost driver (I should probably try on > linux-next at some point but this was the path of least resistance). > > I tested it as a module as it's more challenging (originally probing would > work built-in, on boot, but not as a module, as I didn't have the power > domain changes, and all power domains are on by default during boot). > > Probing logs looks like this, currently. They look sane. > [ 501.319728] panfrost 13040000.gpu: clock rate = 511999970 > [ 501.320041] panfrost 13040000.gpu: Linked as a consumer to regulator.14 > [ 501.320102] panfrost 13040000.gpu: Linked as a consumer to regulator.31 > [ 501.320651] panfrost 13040000.gpu: Linked as a consumer to genpd:0:13040000.gpu > [ 501.320954] panfrost 13040000.gpu: Linked as a consumer to genpd:1:13040000.gpu > [ 501.321062] panfrost 13040000.gpu: Linked as a consumer to genpd:2:13040000.gpu > [ 501.321734] panfrost 13040000.gpu: mali-g72 id 0x6221 major 0x0 minor 0x3 status 0x0 > [ 501.321741] panfrost 13040000.gpu: features: 00000000,13de77ff, issues: 00000000,00000400 > [ 501.321747] panfrost 13040000.gpu: Features: L2:0x07120206 Shader:0x00000000 Tiler:0x00000809 Mem:0x1 MMU:0x00002830 AS:0xff JS:0x7 > [ 501.321752] panfrost 13040000.gpu: shader_present=0x7 l2_present=0x1 > [ 501.324951] [drm] Initialized panfrost 1.1.0 20180908 for 13040000.gpu on minor 2 > > Some more changes are still required to get devfreq working, and of course > I do not have a userspace driver to test this with. > > I believe at least patches 1, 2, and 3 can be merged. 4 and 5 are mostly > useful in conjunction with 6 and 7 (which are not ready yet), so I'll let > maintainers decide. I've applied 3, 4, and 5 to drm-misc-next. Patch 2 should go via Mediatek tree. Rob