From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754074AbcFTVUS (ORCPT ); Mon, 20 Jun 2016 17:20:18 -0400 Received: from mail.kernel.org ([198.145.29.136]:50018 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752697AbcFTVUK (ORCPT ); Mon, 20 Jun 2016 17:20:10 -0400 MIME-Version: 1.0 In-Reply-To: <1466112442-31105-2-git-send-email-daniel.lezcano@linaro.org> References: <1466112442-31105-1-git-send-email-daniel.lezcano@linaro.org> <1466112442-31105-2-git-send-email-daniel.lezcano@linaro.org> From: Rob Herring Date: Mon, 20 Jun 2016 16:03:30 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V2 01/63] of: Add a new macro to declare_of for one parameter function returning a value To: Daniel Lezcano Cc: Thomas Gleixner , "linux-kernel@vger.kernel.org" , Frank Rowand , Grant Likely , "open list:OPEN FIRMWARE AND..." Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 16, 2016 at 4:26 PM, Daniel Lezcano wrote: > The macro OF_DECLARE_1 expect a void (*func)(struct device_node *) while the > OF_DECLARE_2 expect a int (*func)(struct device_node *, struct device_node *). > > The second one allows to pass an init function returning a value, which make > possible to call the functions in the table and check the return value in order > to catch at a higher level the errors and handle them from there instead of > doing a panic in each driver (well at least this is the case for the clkevt). > > Unfortunately the OF_DECLARE_1 does not allow that and that lead to some code > duplication and crappyness in the drivers. > > The OF_DECLARE_1 is used by all the clk drivers and the clocksource/clockevent > drivers. It is not possible to do the change in one shot as we have to change > all the init functions. > > The OF_DECLARE_2 specifies an init function prototype with two parameters with > the node and its parent. The latter won't be used, ever, in the timer drivers. > > Introduce a OF_DECLARE_1_RET macro to be used, and hopefully we can smoothly > and iteratively change the users of OF_DECLARE_1 to use the new macro instead. > > Signed-off-by: Daniel Lezcano > --- > include/linux/of.h | 3 +++ > 1 file changed, 3 insertions(+) Acked-by: Rob Herring