From: Rob Herring <robh@kernel.org>
To: Ikjoon Jang <ikjn@chromium.org>
Cc: Linux Input <linux-input@vger.kernel.org>,
devicetree@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Nicolas Boitchat <drinkcat@chromium.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: input: Add DT bindings for Whiskers switch
Date: Tue, 29 Oct 2019 16:18:37 -0500 [thread overview]
Message-ID: <CAL_JsqJkFND8JP1bG6jbk9E365MpoNOHn1s9=SG-mFjwBa6Gvg@mail.gmail.com> (raw)
In-Reply-To: <CAATdQgDxC_1EH4cBqf7deEqRjtRU1s4o=L8vOztvVZ7NS_q9Mw@mail.gmail.com>
On Tue, Oct 29, 2019 at 2:23 AM Ikjoon Jang <ikjn@chromium.org> wrote:
>
> On Sat, Oct 26, 2019 at 3:41 AM Rob Herring <robh@kernel.org> wrote:
> >
> > On Wed, Oct 23, 2019 at 10:43:48AM +0800, Ikjoon Jang wrote:
> > > Add the DT binding document for Hammer's TABLET_MODE switch.
> >
> > This doesn't have any properties. Why does it need to be in DT? Just
> > have the EC driver instantiate it.
> >
> > >
> > > Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
> > > ---
> > > .../devicetree/bindings/input/cros-cbas.yaml | 22 +++++++++++++++++++
> > > 1 file changed, 22 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/input/cros-cbas.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/input/cros-cbas.yaml b/Documentation/devicetree/bindings/input/cros-cbas.yaml
> > > new file mode 100644
> > > index 000000000000..3bc989c6a295
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/input/cros-cbas.yaml
> > > @@ -0,0 +1,22 @@
> > > +# SPDX-License-Identifier: GPL-2.0
> >
> > (GPL-2.0-only OR BSD-2-Clause) for new bindings please.
>
> This will be GPL-2.0-only in next patch.
That's not what I said. Dual licensed please:
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>
> >
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/input/cros-cbas.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: ChromeOS Hammer's Base Attached Switch
> > > +
> > > +maintainers:
> > > + - Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > +
> > > +description:
> > > + This device is used to signal when a detachable base is attached to a
> > > + Chrome OS tablet. The node for this device must be under a cros-ec node
> > > + like google,cros-ec-spi or google,cros-ec-i2c.
> >
> > This should probably just be part of an EC schema where it can be
> > enforced that this is a child node. It could be either embedded into it
> > or referenced. I'd lean toward the former given this is only a
> > compatible string...
>
> Sorry for basic questions here but I'm a bit confused,
> "embedding" means that cros-ec.txt should be converted
> into json schema first and embed this child bindings into there?
Right.
> Many Chrome OS tablets have a switch exposed by 'cros-ec-keyb' device
> which is directly controlled by EC. But this 'cros_cbas' switch device is for
> other types of tablets which need additional logics on EC and HID.
>
> Currently it doesn't need to have other properties, but maybe it could require
> additional properties or device links in the future, plus this device
> is not just
> a EC subdevice, so I'd prefer this to be a separate binding.
But in the description you say it is a child device.
Rob
prev parent reply other threads:[~2019-10-29 21:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 2:43 [PATCH v3 1/2] dt-bindings: input: Add DT bindings for Whiskers switch Ikjoon Jang
2019-10-25 19:41 ` Rob Herring
2019-10-25 20:45 ` Dmitry Torokhov
2019-10-29 7:22 ` Ikjoon Jang
2019-10-29 21:18 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqJkFND8JP1bG6jbk9E365MpoNOHn1s9=SG-mFjwBa6Gvg@mail.gmail.com' \
--to=robh@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=drinkcat@chromium.org \
--cc=ikjn@chromium.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).