From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754874AbcH2RhL (ORCPT ); Mon, 29 Aug 2016 13:37:11 -0400 Received: from mail.kernel.org ([198.145.29.136]:33634 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbcH2RhK (ORCPT ); Mon, 29 Aug 2016 13:37:10 -0400 MIME-Version: 1.0 In-Reply-To: <20160816150056.GD18731@ak-desktop.emea.nsn-net.net> References: <20160816150056.GD18731@ak-desktop.emea.nsn-net.net> From: Rob Herring Date: Mon, 29 Aug 2016 12:36:41 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [BISECTED REGRESSION] v4.8-rc: DT/OCTEON driver probing broken To: Aaro Koskinen Cc: Kefeng Wang , "devicetree@vger.kernel.org" , Linux-MIPS , Ralf Baechle , David Daney , "linux-kernel@vger.kernel.org" , Thorsten Leemhuis Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 16, 2016 at 10:00 AM, Aaro Koskinen wrote: > Hi, > > Commit 44a7185c2ae6 ("of/platform: Add common method to populate default > bus") added new arch_initcall of_platform_default_populate_init() that > will be called before device_initcall octeon_publish_devices(). Now the > of_platform_bus_probe() called in octeon_publish_devices() is apparently > doing nothing: > > [ 52.331353] calling octeon_publish_devices+0x0/0x14 @ 1 > [ 52.331358] OF: of_platform_bus_probe() > [ 52.331362] OF: starting at: / > [ 52.331378] OF: of_platform_bus_create() - skipping /soc@0, already populated > [ 52.331394] initcall octeon_publish_devices+0x0/0x14 returned 0 after 29 usecs > > This also means that USB etc. won't get probed. > > Any ideas what would be the proper fix for this? Changing > octeon_publish_devices() to arch_initcall seems to work but that may be > a bit hackish... Also, there might be also other MIPS boards affected > (arch/mips/netlogic/xlp/dt.c, arch/mips/mti-malta/malta-dt.c). Can you try reverting this hunk. I don't think it should be needed and it is preventing /soc@0 children from being probed. If things still don't work, then it should purely be a probe ordering problem. I have some better fixes in mind, but not for 4.8. So if this doesn't work, then the same fix as PPC is fine. diff --git a/drivers/of/platform.c b/drivers/of/platform.c index 16e8daf..c559ef8 100644 --- a/drivers/of/platform.c +++ b/drivers/of/platform.c @@ -363,6 +363,12 @@ static int of_platform_bus_create(struct device_node *bus, return 0; } + if (of_node_check_flag(bus, OF_POPULATED_BUS)) { + pr_debug("%s() - skipping %s, already populated\n", + __func__, bus->full_name); + return 0; + } + auxdata = of_dev_lookup(lookup, bus); if (auxdata) { bus_id = auxdata->name; Rob