From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F16E5C47089 for ; Thu, 27 May 2021 12:52:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D707E610A2 for ; Thu, 27 May 2021 12:52:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236007AbhE0MyP (ORCPT ); Thu, 27 May 2021 08:54:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:33526 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235734AbhE0MyO (ORCPT ); Thu, 27 May 2021 08:54:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F193B613E3; Thu, 27 May 2021 12:52:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622119961; bh=KGKc5qTJru05K3irLK2cGRBe4SX+5pRyHRDPOJWvDGc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bfaVJXjELEf7LLxaXkgdVJHahVBB+ju++zovmbaa0+chX90t79PPMqqz3n6f4kmL8 S0bBw1BolgUc05EHIJEjjj5hD5ORLlqPGq+1UnxN05FAL5rRi7YDKfpgsyqH/c71ch UaOtWPYzinuNcOC6J82vpAHsTad9pIffAnEV82Zo0Kp8QRD76ogQzaavy88ajyNcYI PZW9egfAiKsmOKkxs11hjbUnklHxvyDVx8jPRrqCMO5cSmOC1GBfnu1QyeP9GnPJ6L Ia6ljoNDZnZQDyHETvm+NEAdoXN1zkfEW2vwk0HDruwdm4RYgyrq0OdA2y9a4R6931 FwGlYVnkEZSyQ== Received: by mail-ej1-f46.google.com with SMTP id l1so7857223ejb.6; Thu, 27 May 2021 05:52:40 -0700 (PDT) X-Gm-Message-State: AOAM532uuWcVZkQweZCDr+Chkb9BWvRjHlwNKjnYG07XhXVjb8/6Y/TJ Pi+3XJhrM99ytM3lfXm4SgS7xOER9WBAtdAEWA== X-Google-Smtp-Source: ABdhPJxM9eAon4T+vscvp97uksDQ/yJYoFEbWoPuaJhe1RTrL2fLQKbAHlmkb+5lsjgn3fQ8A9nGVGaYIexET+dYCe8= X-Received: by 2002:a17:906:1d0a:: with SMTP id n10mr3605862ejh.341.1622119959571; Thu, 27 May 2021 05:52:39 -0700 (PDT) MIME-Version: 1.0 References: <20210527121029.583611-1-kyletso@google.com> In-Reply-To: From: Rob Herring Date: Thu, 27 May 2021 07:52:24 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] dt-bindings: connector: Replace BIT macro with generic bit ops To: Greg KH Cc: Kyle Tso , Heikki Krogerus , Badhri Jagan Sridharan , "linux-kernel@vger.kernel.org" , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 27, 2021 at 7:41 AM Greg KH wrote: > > On Thu, May 27, 2021 at 08:10:29PM +0800, Kyle Tso wrote: > > BIT macro is not defined. Replace it with generic bit operations. > > > > Fixes: 630dce2810b9 ("dt-bindings: connector: Add SVDM VDO properties") > > Signed-off-by: Kyle Tso > > --- > > Changes since v1: > > - re-word the commit message > > > > include/dt-bindings/usb/pd.h | 20 ++++++++++---------- > > 1 file changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/include/dt-bindings/usb/pd.h b/include/dt-bindings/usb/pd.h > > index fef3ef65967f..cb70b4ceedde 100644 > > --- a/include/dt-bindings/usb/pd.h > > +++ b/include/dt-bindings/usb/pd.h > > @@ -163,10 +163,10 @@ > > #define UFP_VDO_VER1_2 2 > > > > /* Device Capability */ > > -#define DEV_USB2_CAPABLE BIT(0) > > -#define DEV_USB2_BILLBOARD BIT(1) > > -#define DEV_USB3_CAPABLE BIT(2) > > -#define DEV_USB4_CAPABLE BIT(3) > > +#define DEV_USB2_CAPABLE (1 << 0) > > +#define DEV_USB2_BILLBOARD (1 << 1) > > +#define DEV_USB3_CAPABLE (1 << 2) > > +#define DEV_USB4_CAPABLE (1 << 3) > > Why not just include the proper .h file instead? Because the DT headers can't depend on kernel headers as they get used separately. Rob