From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 396A8C32771 for ; Mon, 26 Sep 2022 16:18:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236479AbiIZQSd (ORCPT ); Mon, 26 Sep 2022 12:18:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236211AbiIZQRy (ORCPT ); Mon, 26 Sep 2022 12:17:54 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D98FCF0895; Mon, 26 Sep 2022 08:07:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 57791B80AD4; Mon, 26 Sep 2022 15:07:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01C4FC433B5; Mon, 26 Sep 2022 15:06:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664204819; bh=lkdXtsR+D9e0XZ8MbC6ZfL77jSptLwDUTwJEoZqNsNE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=lAQ69Y/rtyIr+QSfvDG9Kv28y3+GGJLJUFUoCEzcWZtxn3xlued9i3NPs+NYy3sHv srf0jN7iXOxLuuOZhbG/wjbn5dSKPXPxreDlVppO1QMSwb7GLgb4GGKRtlHjy6juzd nDgiwZb/7Kx8ylOHuL2tSCTmX6oUZPA9q2sPu7JiHif86hVglj/6b7kDSgtyMo2aeL 0khbv0TX0sCZJHsF3fa82+Mip/RnnOtmZQlWZGUbFKyXdPODMRQIcImUzuSzpzAgfW lXHHS1q4gUd0RKXvvRo5Y7z2EzWvMh7rrEblC3hJ29o+GlcuSSqXgFM6ErdYm6UJy5 b+/SpL1wjpbnw== Received: by mail-vs1-f45.google.com with SMTP id 129so6821782vsi.10; Mon, 26 Sep 2022 08:06:58 -0700 (PDT) X-Gm-Message-State: ACrzQf3WS2jh4ex1ISVC+nOyS6EKyK6mJjnEj+MQfe5uO1L1wk1chWuh /VuVhRxbgyL2IUrCIqZCxKXAddqtvzL0DxDuxg== X-Google-Smtp-Source: AMsMyM6zXYIh7xV3Gqi/rq72oSjh7Ix4NEn30sPfktNCnXp2Z5fbbOdTSZxoEP8BiRL9Oc5jsWEDopMeu02sKX2u8AY= X-Received: by 2002:a67:c088:0:b0:39b:1bb3:bdd1 with SMTP id x8-20020a67c088000000b0039b1bb3bdd1mr7845774vsi.85.1664204817888; Mon, 26 Sep 2022 08:06:57 -0700 (PDT) MIME-Version: 1.0 References: <9bf36f09bc5f002f2b09b7cc26edccf109516465.1663926551.git.chiaen_wu@richtek.com> <20220924155525.5663bed8@jic23-huawei> In-Reply-To: From: Rob Herring Date: Mon, 26 Sep 2022 10:06:46 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v12 3/5] iio: adc: mt6370: Add MediaTek MT6370 support To: Lee Jones Cc: Jonathan Cameron , ChiaEn Wu , pavel@ucw.cz, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, lars@metafoo.de, andriy.shevchenko@linux.intel.com, chiaen_wu@richtek.com, alice_chen@richtek.com, cy_huang@richtek.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, szunichen@gmail.com, AngeloGioacchino Del Regno , Andy Shevchenko , Jonathan Cameron Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 26, 2022 at 2:46 AM Lee Jones wrote: > > On Sat, 24 Sep 2022, Jonathan Cameron wrote: > > > On Fri, 23 Sep 2022 10:51:24 +0800 > > ChiaEn Wu wrote: > > > > > From: ChiaEn Wu > > > > > > MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger > > > with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight > > > driver, display bias voltage supply, one general purpose LDO, and the > > > USB Type-C & PD controller complies with the latest USB Type-C and PD > > > standards. > > > > > > Add support for the MT6370 ADC driver for system monitoring, including > > > charger current, voltage, and temperature. > > > > > > Reviewed-by: AngeloGioacchino Del Regno > > > Reviewed-by: Andy Shevchenko > > > Acked-by: Jonathan Cameron > > > Signed-off-by: ChiaEn Wu > > > > This will have to either wait for next cycle, or go through mfd because > > of the dt-bindings include which is in the mfd tree. > > > > Please make those dependencies clear in new versions. > > If the bindings come together in -next, then subsequently in Mainline, > it shouldn't really matter. Except that the bindings haven't come together and at this point may not for 6.1. linux-next has been warning for weeks because the child device schemas haven't been applied. I've said it before, all the schemas for MFD devices need to be applied together. Or at least the MFD schema needs to get applied last. Furthermore, subsequent versions of this don't get tested and we end up with more warnings[1]. It's only your IIO tree that the DT > tooling with complain about, right? And the MFD tree... Please apply the LED bindings (patches 1 and 2) so we can get the existing warnings fixed and address any new warnings. Rob [1] https://lore.kernel.org/all/CAL_Jsq+Zkgfq0q_XgpLEjHLPGSuG06L6y5YbzbiberNMWtAuJw@mail.gmail.com/