From: Rob Herring <robh+dt@kernel.org>
To: Saravana Kannan <saravanak@google.com>
Cc: Frank Rowand <frowand.list@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-omap <linux-omap@vger.kernel.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Tony Lindgren <tony@atomide.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Android Kernel Team <kernel-team@android.com>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] of: platform: Batch fwnode parsing in the init_machine() path
Date: Fri, 2 Oct 2020 09:07:55 -0500 [thread overview]
Message-ID: <CAL_JsqKOUkKBKyxPtZ+BFXPiOfm2uPXhgJPxKP=WS-qX6kSB0w@mail.gmail.com> (raw)
In-Reply-To: <20201001225952.3676755-1-saravanak@google.com>
On Thu, Oct 1, 2020 at 5:59 PM Saravana Kannan <saravanak@google.com> wrote:
>
> When commit 93d2e4322aa7 ("of: platform: Batch fwnode parsing when
> adding all top level devices") optimized the fwnode parsing when all top
> level devices are added, it missed out optimizing this for platform
> where the top level devices are added through the init_machine() path.
>
> This commit does the optimization for all paths by simply moving the
> fw_devlink_pause/resume() inside of_platform_default_populate().
>
> Reported-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> ---
> drivers/of/platform.c | 19 +++++++++++++++----
> 1 file changed, 15 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> index 071f04da32c8..79972e49b539 100644
> --- a/drivers/of/platform.c
> +++ b/drivers/of/platform.c
> @@ -501,8 +501,21 @@ int of_platform_default_populate(struct device_node *root,
> const struct of_dev_auxdata *lookup,
> struct device *parent)
> {
> - return of_platform_populate(root, of_default_bus_match_table, lookup,
> - parent);
> + int ret;
> +
> + /*
> + * fw_devlink_pause/resume() are only safe to be called around top
> + * level device addition due to locking constraints.
> + */
> + if (!root)
> + fw_devlink_pause();
> +
> + ret = of_platform_populate(root, of_default_bus_match_table, lookup,
> + parent);
of_platform_default_populate() vs. of_platform_populate() is just a
different match table. I don't think the behavior should otherwise be
different.
There's also of_platform_probe() which has slightly different matching
behavior. It should not behave differently either with respect to
devlinks.
Rob
next prev parent reply other threads:[~2020-10-02 14:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAGETcx8owDP_Bu4oNCyHEsME8XpKygxghm8+yNc2RyMA4wyjCA@mail.gmail.com>
2020-10-01 22:59 ` [PATCH v1] of: platform: Batch fwnode parsing in the init_machine() path Saravana Kannan
2020-10-01 23:19 ` Laurent Pinchart
2020-10-02 11:40 ` Grygorii Strashko
2020-10-02 15:03 ` Grygorii Strashko
2020-10-02 17:48 ` Saravana Kannan
2020-10-02 18:11 ` Grygorii Strashko
2020-10-02 14:07 ` Rob Herring [this message]
2020-10-02 17:51 ` Saravana Kannan
2020-10-02 17:54 ` Laurent Pinchart
2020-10-02 17:58 ` Saravana Kannan
2020-10-02 18:27 ` Laurent Pinchart
2020-10-02 18:35 ` Grygorii Strashko
2020-10-02 19:56 ` Saravana Kannan
2020-10-03 0:13 ` Laurent Pinchart
2020-10-27 3:29 ` Saravana Kannan
2020-10-28 7:34 ` Tomi Valkeinen
2020-10-02 20:29 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKOUkKBKyxPtZ+BFXPiOfm2uPXhgJPxKP=WS-qX6kSB0w@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=grygorii.strashko@ti.com \
--cc=kernel-team@android.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=rjw@rjwysocki.net \
--cc=saravanak@google.com \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).