From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0FA7C43461 for ; Fri, 4 Sep 2020 14:30:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56FF6206B7 for ; Fri, 4 Sep 2020 14:30:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599229850; bh=3S93tF/ignIiM43QgnWujtoIATS7BPwQ6dqnISHKtyA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=CufgNjT8JGLVYm0HUOIqk/tmhslZvJJj47b7oS4PaQZPUgSXvB76A63mcLHv9dk+0 /VXifcQj/i0HxWtuhuPJYWCLH4vFcT1wD+38LILrYgN3cetpASAaEp7maPsZ5jDvju tT/emVqKLZfYntW0QUA9Apkdqo/hisbA3Og2Cuto= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730510AbgIDOar (ORCPT ); Fri, 4 Sep 2020 10:30:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:38850 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728983AbgIDOaB (ORCPT ); Fri, 4 Sep 2020 10:30:01 -0400 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 483C320829; Fri, 4 Sep 2020 14:30:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599229800; bh=3S93tF/ignIiM43QgnWujtoIATS7BPwQ6dqnISHKtyA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=XV8ablvO+fK4xp0xfyjNshid/tVnEyWkQtkPPPQfeOF4f87nnqaEtvL5J755xhn5Y T5s0H9LmmJLHzNgJaQS/q8PEa6Ex55mnbh205MBq8BwCISmLTIVUN/06P5Lsh1rmmP yVYluI8pZ0Mpv/+/QxVc9jIlMf3kVUZD1gFBL/Jg= Received: by mail-ot1-f46.google.com with SMTP id g10so6004397otq.9; Fri, 04 Sep 2020 07:30:00 -0700 (PDT) X-Gm-Message-State: AOAM530AW4cqcRMIU7ePwSlzwDFWbMBtrueGzo9sh0y8ixvNppfbL1pP VC4DM44osg+2FGyTtOohiIQsfcH/NqTaYelZbA== X-Google-Smtp-Source: ABdhPJy0LBatfFdNSWrwrnthwVqtmbC3ydSQ8JsKPP8Rsx3nxJylJbVfefD5DwCJwyvZvCLpFqLpQJtRkwEJ4gGjHPs= X-Received: by 2002:a9d:7f84:: with SMTP id t4mr5794412otp.192.1599229799600; Fri, 04 Sep 2020 07:29:59 -0700 (PDT) MIME-Version: 1.0 References: <20200829111800.2786-1-krzk@kernel.org> <20200829111800.2786-6-krzk@kernel.org> <20200903164117.GA2922218@bogus> In-Reply-To: From: Rob Herring Date: Fri, 4 Sep 2020 08:29:47 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 6/7] dt-bindings: i2c: imx: Use unevaluatedProperties To: Krzysztof Kozlowski Cc: Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Anson Huang , Wolfram Sang , Dong Aisheng , linux-clk , devicetree@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "linux-kernel@vger.kernel.org" , Linux I2C Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 3, 2020 at 2:36 PM Krzysztof Kozlowski wrote: > > On Thu, 3 Sep 2020 at 18:41, Rob Herring wrote: > > > > On Sat, Aug 29, 2020 at 01:17:59PM +0200, Krzysztof Kozlowski wrote: > > > Additional properties actually might appear (e.g. power-domains or child > > > nodes) so use unevaluatedProperties to fix dtbs_check warnings like: > > > > > > arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: i2c@30a20000: > > > '#address-cells', '#size-cells', 'pmic@25' do not match any of the regexes: 'pinctrl-[0-9]+' > > > > > > Signed-off-by: Krzysztof Kozlowski > > > --- > > > Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > NAK. See https://lore.kernel.org/r/CAL_JsqKPXJxsHPS34_TCf9bwgKxZNSV4mvQR-WKRnknQVtGGxQ@mail.gmail.com/ > > I can reference the generic i2c-controller schema and add missing > properties but what to do with children (pmic@25 and many other)? I > see that all of the other I2C controller dtschema files solve it by > skipping "additionalProperties: false". Is this the way to go with I2C > controllers? If there's a $ref to the i2c schema, then using unevaluatedProperties is correct. Rob