From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94216C6778C for ; Fri, 6 Jul 2018 17:48:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 473DA224C6 for ; Fri, 6 Jul 2018 17:48:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="LXpK5wED" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 473DA224C6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934100AbeGFRr5 (ORCPT ); Fri, 6 Jul 2018 13:47:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:40364 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932895AbeGFRry (ORCPT ); Fri, 6 Jul 2018 13:47:54 -0400 Received: from mail-it0-f47.google.com (mail-it0-f47.google.com [209.85.214.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CEDBE23D31; Fri, 6 Jul 2018 17:47:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1530899273; bh=FMJyOP6As4ZVE9ypEpNhGLXtuBo57jhDwJanAu4kkgA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=LXpK5wEDQI2botX03Zv47c9PBvOrY0vBqGRMmPxPjW1dmVaoDwfxNcJk7CTVvglgB 6tNptXpYgapDAcM+eEn5EDAIn2xRenjm7cUGYKya1gT9Xq6xmbf0HW4CDGVTlVq79R SUcC3GxePteS/XMPRjaU8s94vkicqVbBqsP8a5aE= Received: by mail-it0-f47.google.com with SMTP id u4-v6so17559460itg.0; Fri, 06 Jul 2018 10:47:53 -0700 (PDT) X-Gm-Message-State: APt69E25WawSQndfoZAOM6A6NNF5LQ7YcrEmgJauXYc86arOrR43E1ol mABpMUUopRgm2FBsTd4wutUEaDEJv8cwatvISg== X-Google-Smtp-Source: AAOMgpcs/He7fNCDsTLCAGOvA+SOuoSlmdghgGbLmoz5j6AJMA8KBqO73C2G4EDJAZ0cBbbxoJL08U4FvhSWIVkYv1A= X-Received: by 2002:a02:9936:: with SMTP id r51-v6mr9293063jaj.46.1530899273203; Fri, 06 Jul 2018 10:47:53 -0700 (PDT) MIME-Version: 1.0 References: <43e3ae530334efab3fa0151430879f03731e9daa.1530533998.git.amit.kucheria@linaro.org> <20180703162619.GA17238@rob-hp-laptop> <20180705203712.GA29531@rob-hp-laptop> In-Reply-To: From: Rob Herring Date: Fri, 6 Jul 2018 11:47:41 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 4/6] thermal: tsens: Add support for SDM845 To: Amit Kucheria Cc: "linux-kernel@vger.kernel.org" , Rajendra Nayak , linux-arm-msm , Bjorn Andersson , Eduardo Valentin , Siddartha Mohanadoss , Vivek Gautam , Andy Gross , Zhang Rui , Mark Rutland , Kees Cook , "open list:THERMAL" , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 5, 2018 at 11:13 PM Amit Kucheria wrote: > > On Fri, Jul 6, 2018 at 2:07 AM Rob Herring wrote: > > > > On Wed, Jul 04, 2018 at 10:56:26PM +0530, Amit Kucheria wrote: > > > On Tue, Jul 3, 2018 at 9:56 PM, Rob Herring wrote: > > > > On Mon, Jul 02, 2018 at 06:14:07PM +0530, Amit Kucheria wrote: > > > >> SDM845 uses v2.4.0 of the TSENS IP block but the get_temp() function > > > >> appears to be identical across v2.x.y in code seen so far. We use the > > > >> generic get_temp() function. > > > >> > > > >> Signed-off-by: Amit Kucheria > > > >> --- > > > >> Documentation/devicetree/bindings/thermal/qcom-tsens.txt | 2 ++ > > > >> drivers/thermal/qcom/tsens-v2.c | 6 +++++- > > > >> drivers/thermal/qcom/tsens.c | 6 ++++++ > > > >> drivers/thermal/qcom/tsens.h | 5 ++++- > > > >> 4 files changed, 17 insertions(+), 2 deletions(-) > > > >> > > > >> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt > > > >> index 06195e8..075182e 100644 > > > >> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt > > > >> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt > > > >> @@ -5,6 +5,8 @@ Required properties: > > > >> - "qcom,msm8916-tsens" : For 8916 Family of SoCs > > > >> - "qcom,msm8974-tsens" : For 8974 Family of SoCs > > > >> - "qcom,msm8996-tsens" : For 8996 Family of SoCs > > > >> + - "qcom,tsens-v2.4.0" : For SDM845 Family of SoCs > > > >> + - "qcom,tsens-v2" : Generic fallback binding for any Soc using 2.x.y version of the tsens IP > > > > > > > > You need to show what are valid combinations of compatibles. Does v2 > > > > apply to 8996? One valid combination per line. > > > > > > I've restructured qcom-tsens.txt to look like this: > > > > > > -----%<------- > > > > > > * QCOM SoC Temperature Sensor (TSENS) > > > > > > Required properties: > > > - compatible: must be one of the following: > > > - "qcom,msm8916-tsens" (MSM8916) > > > - "qcom,msm8974-tsens" (MSM8974) > > > - "qcom,msm8996-tsens" (MSM8996) > > > - "qcom,tsens-", "qcom,tsens-v2" (TSENS IP version and a > > > generic v2 property as fallback except for MSM8996) > > > > > > Examples with ip_version are: > > > - "qcom,tsens-v2.4.0", "qcom,tsens-v2" (SDM845) > > > - "qcom,tsens-v2.2.1", "qcom,tsens-v2" (MSM8998) > > > > > > -----%<------- > > > > > > 8996 would end up being something like this if needed, though we're > > > stuck with "qcom,msm8996-tsens": > > > "qcom,msm8996-tsens", "qcom,tsens-v2.1.0", "qcom,tsens-v2" (MSM8996) > > > > 3 versions here for 3 SoCs. I'm not getting that convinced version > > numbers really are better. I would assume that other QCom IP blocks > > Yeah, it is a bit unfortunate that the 3-4 SoCs we're focusing on > getting supported upstream have different versions of the TSENS IP. > The other goal of this work was to make the upstream driver > feature-complete so we can make a case to switch to it in the > downstream trees, even on platforms that aren't being active > upstreamed. They'll still need to keep around those SoC-specific > one-liner patches in the downstream trees. Why? They can just use the "v2" fallback (which was sufficient for your original version). That's not my recommendation, but what do I care for downstream. Only upstream needs the specific strings to appease the annoying DT maintainers. Plus, if it's not upstream, it doesn't exist. :) > > have versions too, but pretty much *every* *other* binding uses SoC names. > > Why is this one special? > > I'm not an expert on all QC IPs, but this one _seems_ to be reused a > lot more than others. > > > The other problem with versions is the mapping > > of versions to SoCs most likely can't be validated outside of QCom > > unless there's a version register. > > There is in fact a HW version register that I was hoping to add > support for later. Yes, you should rely on that as much as possible. But I have seen h/w designers forget to update revision registers or there can be integration differences even if the IP version is the same. > > So, sorry to go in circles, but can you go back to qcom,-tsens. You > > can keep qcom,tsens-v2 as a fallback. > > OK. > > > Yes, it's annoying to have to update bindings for new SoCs. But it's > > trivial one line patches. Look at Renesas bindings. Maybe adding new > > ones will be scriptable once we move to json-schema binding docs. > > I did look at the Renesas RCar bindings when restructuring the > documentation. They seem to have settled upon a 3-level fallback: > "soc-specific", "generic-no TZ", "generic-TZ". But > drivers/thermal/rcar_thermal.c seems to be compatible with only one > soc-specific property (thermal-r8a77995) and all other SoCs seem to be > just relying the fallbacks. > > Anyways, I'll respin. > > Thanks. > > Regards, > Amit