From: Rob Herring <robh+dt@kernel.org>
To: Frank Rowand <frowand.list@gmail.com>
Cc: Stephen Boyd <stephen.boyd@linaro.org>,
Michal Marek <mmarek@suse.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] of: Add unit tests for applying overlays
Date: Tue, 25 Jul 2017 15:36:29 -0500 [thread overview]
Message-ID: <CAL_JsqKZ5JcunaY9K5MEjyS-sxargKtJq11x+DVMwHs8WrnH+Q@mail.gmail.com> (raw)
In-Reply-To: <1493165394-29367-3-git-send-email-frowand.list@gmail.com>
On Tue, Apr 25, 2017 at 7:09 PM, <frowand.list@gmail.com> wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> Existing overlay unit tests examine individual pieces of the overlay
> code. The new tests target the entire process of applying an overlay.
>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
[...]
> @@ -1261,6 +1263,8 @@ void __init unflatten_device_tree(void)
>
> /* Get pointer to "/chosen" and "/aliases" nodes for use everywhere */
> of_alias_scan(early_init_dt_alloc_memory_arch);
> +
> + unittest_unflatten_overlay_base();
This breaks on systems that don't boot with FDT and call
unflatten_device_tree, namely x86 and UML (UML needs a few hacks to
work) which was a feature of the unittest. Considering applying
overlays on x86 is something we'll want to support, the unittest
should support that case.
Rob
next prev parent reply other threads:[~2017-07-25 20:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 0:09 [PATCH v4 0/2] of: Add unit tests for applying overlays frowand.list
2017-04-26 0:09 ` [PATCH v4 1/2] of: per-file dtc compiler flags frowand.list
2017-04-27 15:09 ` Masahiro Yamada
2017-04-27 22:25 ` Rob Herring
2017-04-26 0:09 ` [PATCH v4 2/2] of: Add unit tests for applying overlays frowand.list
2017-04-27 22:26 ` Rob Herring
2017-04-28 11:25 ` Geert Uytterhoeven
2017-04-28 15:24 ` Frank Rowand
2017-04-28 16:13 ` Geert Uytterhoeven
2017-07-25 20:36 ` Rob Herring [this message]
2017-07-27 23:46 ` Frank Rowand
2017-10-13 23:08 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKZ5JcunaY9K5MEjyS-sxargKtJq11x+DVMwHs8WrnH+Q@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=stephen.boyd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).