From: Rob Herring <robh+dt@kernel.org>
To: Giulio Benetti <giulio.benetti@micronovasrl.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Mark Rutland <mark.rutland@arm.com>,
"open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
<linux-rtc@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] rtc: ds1307: add calibration of_ for mt41txx chips.
Date: Tue, 8 May 2018 12:40:25 -0500 [thread overview]
Message-ID: <CAL_JsqKa7AF4x5440aVtCsCcvbTS85o-dRT8+Ka6QB=8zK2NzA@mail.gmail.com> (raw)
In-Reply-To: <20180508145611.49072-3-giulio.benetti@micronovasrl.com>
On Tue, May 8, 2018 at 9:56 AM, Giulio Benetti
<giulio.benetti@micronovasrl.com> wrote:
> m41txx chips can hold a calibration value to get really near to real
> tick value.
Typo in the subject.
> Add calibration property(ranging between (-31) and 31), so on every probe
> calibration value will be written to rtc.
> This is because ic could loose supply due to low battery.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
> .../devicetree/bindings/rtc/rtc-ds1307.txt | 2 ++
Put all the binding changes in separate patch (or maybe 2: new
compatible and new properties).
> drivers/rtc/rtc-ds1307.c | 33 +++++++++++++++++++
> 2 files changed, 35 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/rtc/rtc-ds1307.txt b/Documentation/devicetree/bindings/rtc/rtc-ds1307.txt
> index ce6469c1a516..d3d70a5495c5 100644
> --- a/Documentation/devicetree/bindings/rtc/rtc-ds1307.txt
> +++ b/Documentation/devicetree/bindings/rtc/rtc-ds1307.txt
> @@ -34,6 +34,8 @@ Optional properties:
> - trickle-diode-disable : ds1339, ds1340 and ds 1388 only
> Do not use internal trickle charger diode
> Should be given if internal trickle charger diode should be disabled
> +- calibration: m41t0, m41t00, m41t11 only
Needs a vendor prefix.
Calibration of what and what are the units?
> + Set calibration value to correct external bias, ranging between (-31) and 31.
>
> Example:
> rtc1: ds1339@68 {
next prev parent reply other threads:[~2018-05-08 17:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 14:56 [PATCH 1/4] rtc: ds1307: fix data pointer to m41t0 Giulio Benetti
2018-05-08 14:56 ` [PATCH 2/4] rtc: ds1307: support m41t11 variant Giulio Benetti
2018-05-08 14:56 ` [PATCH 3/4] rtc: ds1307: add calibration of_ for mt41txx chips Giulio Benetti
2018-05-08 17:40 ` Rob Herring [this message]
2018-05-09 18:33 ` Giulio Benetti
2018-05-08 19:19 ` Alexandre Belloni
2018-05-09 18:31 ` Giulio Benetti
2018-05-08 14:56 ` [PATCH 4/4] rtc: ds1307: add frequency-test property to check calibration on m41txx Giulio Benetti
2018-05-08 17:44 ` Rob Herring
2018-05-09 18:32 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKa7AF4x5440aVtCsCcvbTS85o-dRT8+Ka6QB=8zK2NzA@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=giulio.benetti@micronovasrl.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).