From: Rob Herring <robh@kernel.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
Maciej Purski <m.purski@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jon Hunter <jonathanh@nvidia.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Lucas Stach <l.stach@pengutronix.de>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-tegra@vger.kernel.org,
linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v1 05/11] dt-bindings: regulator: Change regulator-coupled-max-spread property
Date: Wed, 17 Oct 2018 08:33:20 -0500 [thread overview]
Message-ID: <CAL_JsqKiMVNB+d3n_HJ_Mq+6wi95DS6GvZ=u0vdyAKm9E4jkdQ@mail.gmail.com> (raw)
In-Reply-To: <6e9e90a1-0580-cc20-f7f9-69fefae0b3dd@gmail.com>
On Wed, Oct 17, 2018 at 8:32 AM Dmitry Osipenko <digetx@gmail.com> wrote:
>
> On 10/17/18 4:25 PM, Rob Herring wrote:
> > On Fri, Oct 05, 2018 at 06:36:32PM +0300, Dmitry Osipenko wrote:
> >> Redefine binding for regulator-coupled-max-spread property in a way that
> >> max-spread values are defined per regulator couple instead of defining
> >> single max-spread for the whole group of coupled regulators.
> >>
> >> With that change the following regulators coupling configuration will be
> >> possible:
> >>
> >> regA: regulatorA {
> >> regulator-coupled-with = <®B ®C>;
> >> regulator-coupled-max-spread = <100000 300000>;
> >> };
> >>
> >> regB: regulatorB {
> >> regulator-coupled-with = <®A ®C>;
> >> regulator-coupled-max-spread = <100000 200000>;
> >> };
> >>
> >> regC: regulatorC {
> >> regulator-coupled-with = <®A ®B>;
> >> regulator-coupled-max-spread = <300000 200000>;
> >> };
> >>
> >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> >> ---
> >> Documentation/devicetree/bindings/regulator/regulator.txt | 5 +++--
> >> 1 file changed, 3 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt
> >> index a7cd36877bfe..9b525b657fca 100644
> >> --- a/Documentation/devicetree/bindings/regulator/regulator.txt
> >> +++ b/Documentation/devicetree/bindings/regulator/regulator.txt
> >> @@ -76,8 +76,9 @@ Optional properties:
> >> - regulator-coupled-with: Regulators with which the regulator
> >> is coupled. The linkage is 2-way - all coupled regulators should be linked
> >> with each other. A regulator should not be coupled with its supplier.
> >> -- regulator-coupled-max-spread: Max spread between voltages of coupled regulators
> >> - in microvolts.
> >> +- regulator-coupled-max-spread: Array of maximum spread between voltages of
> >> + coupled regulators in microvolts, each value in the array relates to the
> >> + corresponding couple specified by the regulator-coupled-with property.
> >
> > Is this in use already? How is a single entry handled?
>
> No, it is not in use yet. Only some of the prerequisite patches were applied.
Please make that clear in the commit message.
next prev parent reply other threads:[~2018-10-17 13:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 15:36 [PATCH v1 00/11] Continuing the work on coupled regulators Dmitry Osipenko
2018-10-05 15:36 ` [PATCH v1 01/11] regulator: core: Add voltage balancing mechanism Dmitry Osipenko
2018-10-05 15:36 ` [PATCH v1 02/11] regulator: core: Change voltage setting path Dmitry Osipenko
2018-10-05 15:36 ` [PATCH v1 03/11] regulator: core: Mutually resolve regulators coupling Dmitry Osipenko
2018-10-05 15:36 ` [PATCH v1 04/11] regulator: core: Don't allow to get regulator until all couples resolved Dmitry Osipenko
2018-10-05 15:36 ` [PATCH v1 05/11] dt-bindings: regulator: Change regulator-coupled-max-spread property Dmitry Osipenko
2018-10-17 13:25 ` Rob Herring
2018-10-17 13:32 ` Dmitry Osipenko
2018-10-17 13:33 ` Rob Herring [this message]
2018-10-17 13:36 ` Dmitry Osipenko
2018-10-17 13:27 ` Rob Herring
2018-10-17 13:31 ` Rob Herring
2018-10-05 15:36 ` [PATCH v1 06/11] regulator: core: Limit regulators coupling to a single couple Dmitry Osipenko
2018-10-05 15:36 ` [PATCH v1 07/11] dt-bindings: regulator: Document new regulator-max-step-microvolt property Dmitry Osipenko
2018-10-17 13:33 ` Rob Herring
2018-10-05 15:36 ` [PATCH v1 08/11] regulator: core: Add new max_uV_step constraint Dmitry Osipenko
2018-10-05 15:36 ` [PATCH v1 09/11] regulator: core: Decouple regulators on regulator_unregister() Dmitry Osipenko
2018-10-05 15:36 ` [PATCH v1 10/11] regulator: core: Use ww_mutex for regulators locking Dmitry Osipenko
2018-11-08 13:07 ` Mark Brown
2018-11-08 16:53 ` Dmitry Osipenko
2018-10-05 15:36 ` [PATCH v1 11/11] regulator: core: Properly handle case where supply is the couple Dmitry Osipenko
2018-10-08 17:58 ` [PATCH v1 00/11] Continuing the work on coupled regulators Tony Lindgren
2018-10-09 8:52 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKiMVNB+d3n_HJ_Mq+6wi95DS6GvZ=u0vdyAKm9E4jkdQ@mail.gmail.com' \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=m.purski@samsung.com \
--cc=pdeschrijver@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).