From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07B13C43463 for ; Fri, 18 Sep 2020 16:08:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD99A206A4 for ; Fri, 18 Sep 2020 16:08:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600445286; bh=HsD1zmlNgcDp2ntiGGXDt1Iu4ADx6rxNh/Bto2esBP8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=QsHh37maS91HZ4soRTVd298tNfjcGtVXbZN4sU8twP3x0R/oRSZ3TgHDXPBYioyyQ j5ABZlnbD4kW+as/STyzdNiE08bACTU7q1Di/GaxEEdiYBMXnYL6YH5pnXcQPWWvHa XRoieSdqnpagtLUiSn76ae3ceVm6M3xA2iVy6Gxo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726371AbgIRQIG (ORCPT ); Fri, 18 Sep 2020 12:08:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:55374 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725955AbgIRQIF (ORCPT ); Fri, 18 Sep 2020 12:08:05 -0400 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 06D37238E6; Fri, 18 Sep 2020 16:08:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600445284; bh=HsD1zmlNgcDp2ntiGGXDt1Iu4ADx6rxNh/Bto2esBP8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=emUrEqNiAaIypaaqR0DFyojY3bKTuLzedv4LJNpN6r92gOZux9m/t+i1gDj1JpGUw XdzfnJhSce31jn8yRunVP1TffGoAH3jyT3yCKqPfFryCodyr5Ku1NvsvKOnpWwHFs+ 9mXeIHyvZEiaP3nGp2V20W14pf9i4HBfMJMoBQV8= Received: by mail-ot1-f51.google.com with SMTP id u25so5877282otq.6; Fri, 18 Sep 2020 09:08:04 -0700 (PDT) X-Gm-Message-State: AOAM533VSNj/ijoXeEHV4diRaslxHgYQJaDG1LQjeSCoSjFU+0cEtVnv oXZfNFot6kvZII9E/Dc75CcNNHuM3pyBL6RUNA== X-Google-Smtp-Source: ABdhPJwgdQQ94kk1CAJVTaLgyAzK5jSLiZzPbGFE5cSpTlp+14Bb87D1OUAiLGeIZ3x+kwKNZ39GOoJ1D5VzhOMWVEw= X-Received: by 2002:a05:6830:1008:: with SMTP id a8mr21705872otp.107.1600445283255; Fri, 18 Sep 2020 09:08:03 -0700 (PDT) MIME-Version: 1.0 References: <20200905080920.13396-1-yong.wu@mediatek.com> <20200905080920.13396-2-yong.wu@mediatek.com> <20200914232204.GA457962@bogus> <1600148980.25043.11.camel@mhfsdcap03> In-Reply-To: <1600148980.25043.11.camel@mhfsdcap03> From: Rob Herring Date: Fri, 18 Sep 2020 10:07:51 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 01/23] dt-bindings: iommu: mediatek: Convert IOMMU to DT schema To: Yong Wu Cc: Joerg Roedel , Matthias Brugger , Robin Murphy , Will Deacon , Evan Green , Tomasz Figa , "moderated list:ARM/Mediatek SoC support" , srv_heupstream , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-arm-kernel , Linux IOMMU , Youlin Pei , Nicolas Boichat , Anan Sun , Chao Hao , Ming-Fan Chen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 14, 2020 at 11:51 PM Yong Wu wrote: > > On Mon, 2020-09-14 at 17:22 -0600, Rob Herring wrote: > > On Sat, Sep 05, 2020 at 04:08:58PM +0800, Yong Wu wrote: > > > Convert MediaTek IOMMU to DT schema. > > > > > > Signed-off-by: Yong Wu > > > --- > > [...] > > > > +properties: > > > + compatible: > > > + enum: > > > + - mediatek,mt2701-m4u #mt2701 generation one HW > > > + - mediatek,mt2712-m4u #mt2712 generation two HW > > > + - mediatek,mt6779-m4u #mt6779 generation two HW > > > + - mediatek,mt7623-m4u, mediatek,mt2701-m4u #mt7623 generation one HW > > > > This is not right. > > > > items: > > - const: mediatek,mt7623-m4u > > - const: mediatek,mt2701-m4u > > > > And that has to be under a 'oneOf' with the rest of this. > > Thanks for the review. Is this OK? > > compatible: > oneOf: > - const: mediatek,mt2701-m4u # mt2701 generation one HW > - const: mediatek,mt2712-m4u # mt2712 generation two HW > - const: mediatek,mt6779-m4u # mt6779 generation two HW > - const: mediatek,mt8173-m4u # mt8173 generation two HW > - const: mediatek,mt8183-m4u # mt8183 generation two HW > - const: mediatek,mt8192-m4u # mt8192 generation two HW It is correct, but I prefer all these to be a single enum. So 'oneOf' would have 2 entries. > - description: mt7623 generation one HW > items: > - const: mediatek,mt7623-m4u > - const: mediatek,mt2701-m4u > > > > > > + - mediatek,mt8173-m4u #mt8173 generation two HW > > > + - mediatek,mt8183-m4u #mt8183 generation two HW > > > + > > > + reg: > > > + maxItems: 1 > > [snip]