From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92D4AC432C3 for ; Fri, 15 Nov 2019 14:43:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4886D2073A for ; Fri, 15 Nov 2019 14:43:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573829019; bh=TvjmPbrp9BWrn+9y0+bfbfF5m/J6b8e+uQ2yLwpf2i0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=xVEZvJls5hwA2AKbBSuZig6BvOs1diymmlAxQr+hDa4gGLl+SoUMgewk7AL+3BQby uCuHrocNnkWz1I3ZOuqb9F4vD9R+iTB3KmNl6qmv2CwXl/EaSS4JU6dF/lpKwuW8HP ZEu9teXzctvcicm8GZP7ZwmnoKFc2W+M/zTB5Zu4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727718AbfKOOni (ORCPT ); Fri, 15 Nov 2019 09:43:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:52844 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727496AbfKOOnh (ORCPT ); Fri, 15 Nov 2019 09:43:37 -0500 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4F88D20740; Fri, 15 Nov 2019 14:43:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573829015; bh=TvjmPbrp9BWrn+9y0+bfbfF5m/J6b8e+uQ2yLwpf2i0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=mQyYv95Ywe4x/yf8EcL1x79G4wjQZeJHF1HIaDziwKDKQgFp70Rp6kSDTrrJ45wHa eWN6uhO7ug047ehMhs63zwz8FsSW6z9SeZwaTXTZlGGthy8u83tfx/uWao6Kaaf5Hh n/dCYUC15BnjMhXmHjbuRuWWvHpzvmA8Kg5237Uo= Received: by mail-qk1-f176.google.com with SMTP id 71so8278298qkl.0; Fri, 15 Nov 2019 06:43:35 -0800 (PST) X-Gm-Message-State: APjAAAWrfgqEg9lmGTzxdSL0rZWf6pZn6wFqTLUbaWlo7Ux0dGwRtsrv tZ7iu9NGGu9fsYLmWhKaCm6L1Hdv6fKZXzBHyQ== X-Google-Smtp-Source: APXvYqxwKGFKHMevZAqbw8Avn2idnyny64iNvpRi6bpC5V1DoCaf1cg+4MpEBw3gUpc+Ba3NPL8Ap0gTg3UcGJaZTIs= X-Received: by 2002:a37:4904:: with SMTP id w4mr11817399qka.119.1573829014200; Fri, 15 Nov 2019 06:43:34 -0800 (PST) MIME-Version: 1.0 References: <20191111090230.3402-1-chunyan.zhang@unisoc.com> <20191111090230.3402-6-chunyan.zhang@unisoc.com> <20191114210516.GB16668@bogus> In-Reply-To: From: Rob Herring Date: Fri, 15 Nov 2019 08:43:22 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 5/5] arm64: dts: Add Unisoc's SC9863A SoC support To: Chunyan Zhang Cc: Chunyan Zhang , Mark Rutland , DTML , Linux Kernel Mailing List , Orson Zhai , Baolin Wang , Arnd Bergmann Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 15, 2019 at 2:59 AM Chunyan Zhang wrote: > > On Fri, 15 Nov 2019 at 05:05, Rob Herring wrote: > > > > On Mon, Nov 11, 2019 at 05:02:30PM +0800, Chunyan Zhang wrote: > > > > > > Add basic DT to support Unisoc's SC9863A, with this patch, > > > the board sp9863a-1h10 can run into console. > > > > > > Signed-off-by: Chunyan Zhang > > > --- > > > arch/arm64/boot/dts/sprd/Makefile | 3 +- > > > arch/arm64/boot/dts/sprd/sc9863a.dtsi | 536 ++++++++++++++++++++= ++ > > > arch/arm64/boot/dts/sprd/sharkl3.dtsi | 188 ++++++++ > > > arch/arm64/boot/dts/sprd/sp9863a-1h10.dts | 40 ++ > > > 4 files changed, 766 insertions(+), 1 deletion(-) > > > create mode 100644 arch/arm64/boot/dts/sprd/sc9863a.dtsi > > > create mode 100644 arch/arm64/boot/dts/sprd/sharkl3.dtsi > > > create mode 100644 arch/arm64/boot/dts/sprd/sp9863a-1h10.dts > > > > > > diff --git a/arch/arm64/boot/dts/sprd/Makefile b/arch/arm64/boot/dts/= sprd/Makefile > > > index 2bdc23804f40..f4f1f5148cc2 100644 > > > --- a/arch/arm64/boot/dts/sprd/Makefile > > > +++ b/arch/arm64/boot/dts/sprd/Makefile > > > @@ -1,3 +1,4 @@ > > > # SPDX-License-Identifier: GPL-2.0 > > > dtb-$(CONFIG_ARCH_SPRD) +=3D sc9836-openphone.dtb \ > > > - sp9860g-1h10.dtb > > > + sp9860g-1h10.dtb \ > > > + sp9863a-1h10.dtb > > > diff --git a/arch/arm64/boot/dts/sprd/sc9863a.dtsi b/arch/arm64/boot/= dts/sprd/sc9863a.dtsi > > > new file mode 100644 > > > index 000000000000..578d71a932d9 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/sprd/sc9863a.dtsi > > > @@ -0,0 +1,536 @@ > > > +// SPDX-License-Identifier: GPL-2.0-only > > > +/* > > > + * Unisoc SC9863A SoC DTS file > > > + * > > > + * Copyright (C) 2019, Unisoc Inc. > > > + */ > > > + > > > +#include > > > +#include "sharkl3.dtsi" > > > + > > > +/ { > > > + cpus { > > > + #address-cells =3D <2>; > > > + #size-cells =3D <0>; > > > + > > > + cpu-map { > > > + cluster0 { > > > + core0 { > > > + cpu =3D <&CPU0>; > > > + }; > > > + core1 { > > > + cpu =3D <&CPU1>; > > > + }; > > > + core2 { > > > + cpu =3D <&CPU2>; > > > + }; > > > + core3 { > > > + cpu =3D <&CPU3>; > > > + }; > > > + }; > > > + > > > + cluster1 { > > > + core0 { > > > + cpu =3D <&CPU4>; > > > + }; > > > + core1 { > > > + cpu =3D <&CPU5>; > > > + }; > > > + core2 { > > > + cpu =3D <&CPU6>; > > > + }; > > > + core3 { > > > + cpu =3D <&CPU7>; > > > + }; > > > + }; > > > + }; > > > + > > > + CPU0: cpu@0 { > > > + device_type =3D "cpu"; > > > + compatible =3D "arm,cortex-a55"; > > > + reg =3D <0x0 0x0>; > > > + enable-method =3D "psci"; > > > + cpu-idle-states =3D <&CORE_PD>; > > > + }; > > > + > > > + CPU1: cpu@100 { > > > > Your numbering seems odd. This follows the MPIDR reg? Normally a cluste= r > > would share the same number in one of the bytes. > > We're using A55, and the spec says that bit[15:8] identifies > individual cores within the local DynamIQ=E2=84=A2 cluster Okay. > Also, we only support one cluster. cpu-map shows 2 clusters. > > > > > > + device_type =3D "cpu"; > > > + compatible =3D "arm,cortex-a55"; > > > + reg =3D <0x0 0x100>; > > > + enable-method =3D "psci"; > > > + cpu-idle-states =3D <&CORE_PD>; > > > + }; > > > + > > > + CPU2: cpu@200 { > > > + device_type =3D "cpu"; > > > + compatible =3D "arm,cortex-a55"; > > > + reg =3D <0x0 0x200>; > > > + enable-method =3D "psci"; > > > + cpu-idle-states =3D <&CORE_PD>; > > > + }; > > > + > > > + CPU3: cpu@300 { > > > + device_type =3D "cpu"; > > > + compatible =3D "arm,cortex-a55"; > > > + reg =3D <0x0 0x300>; > > > + enable-method =3D "psci"; > > > + cpu-idle-states =3D <&CORE_PD>; > > > + }; > > > + > > > + CPU4: cpu@400 { > > > + device_type =3D "cpu"; > > > + compatible =3D "arm,cortex-a55"; > > > + reg =3D <0x0 0x400>; > > > + enable-method =3D "psci"; > > > + cpu-idle-states =3D <&CORE_PD>; > > > + }; > > > + > > > + CPU5: cpu@500 { > > > + device_type =3D "cpu"; > > > + compatible =3D "arm,cortex-a55"; > > > + reg =3D <0x0 0x500>; > > > + enable-method =3D "psci"; > > > + cpu-idle-states =3D <&CORE_PD>; > > > + }; > > > + > > > + CPU6: cpu@600 { > > > + device_type =3D "cpu"; > > > + compatible =3D "arm,cortex-a55"; > > > + reg =3D <0x0 0x600>; > > > + enable-method =3D "psci"; > > > + cpu-idle-states =3D <&CORE_PD>; > > > + }; > > > + > > > + CPU7: cpu@700 { > > > + device_type =3D "cpu"; > > > + compatible =3D "arm,cortex-a55"; > > > + reg =3D <0x0 0x700>; > > > + enable-method =3D "psci"; > > > + cpu-idle-states =3D <&CORE_PD>; > > > + }; > > > + }; > > > + > > > + idle-states { > > > + entry-method =3D "arm,psci"; > > > + CORE_PD: core_pd { > > > + compatible =3D "arm,idle-state"; > > > + entry-latency-us =3D <4000>; > > > + exit-latency-us =3D <4000>; > > > + min-residency-us =3D <10000>; > > > + local-timer-stop; > > > + arm,psci-suspend-param =3D <0x00010000>; > > > + }; > > > + }; > > > + > > > + gic: interrupt-controller@14000000 { > > > > Should go under a bus node. > > I didn't get your point, can you give me more details about this? Memory mapped peripherals should go under a 'simple-bus' node rather than be at the top level. > > > + compatible =3D "arm,gic-v3"; > > > + #interrupt-cells =3D <3>; > > > + #address-cells =3D <2>; > > > + #size-cells =3D <2>; > > > + ranges; > > > + redistributor-stride =3D <0x0 0x20000>; /* 128KB stri= de */ > > > + #redistributor-regions =3D <1>; > > > + interrupt-controller; > > > + reg =3D <0x0 0x14000000 0 0x20000>, /* GICD */ > > > + <0x0 0x14040000 0 0x100000>; /* GICR */ > > > + interrupts =3D ; > > > + > > > + v2m_0: v2m@0 { > > > + compatible =3D "arm,gic-v2m-frame"; > > > > This is a GICv2 thing... > > Will remove it. > > > > > > + msi-controller; > > > > Goes in the parent. Please run your dts file with > > 'make W=3D12 dtbs_check' and fix the warnings. > > Ok (sorry for missing to do this check) > > > > > > + reg =3D <0 0 0 0x1000>; > > > + }; > > > + }; > > > + > > > + psci { > > > + compatible =3D "arm,psci-0.2"; > > > + method =3D "smc"; > > > + }; > > > + > > > + timer { > > > + compatible =3D "arm,armv8-timer"; > > > + interrupts =3D , /* Phy= sical Secure PPI */ > > > + , /* Physi= cal Non-Secure PPI */ > > > + , /* Virtu= al PPI */ > > > + ; /* Hiper= visor PPI */ > > > + }; > > > + > > > + pmu { > > > + compatible =3D "arm,armv8-pmuv3"; > > > + interrupts =3D , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + ; > > > + }; > > > + > > > + soc { > > > + funnel@10001000 { > > > + compatible =3D "arm,coresight-dynamic-funnel", = "arm,primecell"; > > > + reg =3D <0 0x10001000 0 0x1000>; > > > + clocks =3D <&ext_26m>; > > > + clock-names =3D "apb_pclk"; > > > + > > > + out-ports { > > > + port { > > > + funnel_soc_out_port: endpoint { > > > + remote-endpoint =3D <&e= tb_in>; > > > + }; > > > + }; > > > + }; > > > + > > > + in-ports { > > > + #address-cells =3D <1>; > > > + #size-cells =3D <0>; > > > + > > > + port@0 { > > > + reg =3D <0>; > > > + funnel_soc_in_port: endpoint { > > > + remote-endpoint =3D > > > + <&funnel_ca55_out_port>= ; > > > + }; > > > + }; > > > + }; > > > + }; > > > + > > > + etb@10003000 { > > > + compatible =3D "arm,coresight-tmc", "arm,primec= ell"; > > > + reg =3D <0 0x10003000 0 0x1000>; > > > + clocks =3D <&ext_26m>; > > > + clock-names =3D "apb_pclk"; > > > + > > > + in-ports { > > > + port { > > > + etb_in: endpoint { > > > + remote-endpoint =3D > > > + <&funnel_soc_out_port>; > > > + }; > > > + }; > > > + }; > > > + }; > > > + > > > + funnel@12001000 { > > > + compatible =3D "arm,coresight-dynamic-funnel", = "arm,primecell"; > > > + reg =3D <0 0x12001000 0 0x1000>; > > > + clocks =3D <&ext_26m>; > > > + clock-names =3D "apb_pclk"; > > > + > > > + out-ports { > > > + port { > > > + funnel_little_out_port: endpoin= t { > > > + remote-endpoint =3D > > > + <&etf_little_in>; > > > + }; > > > + }; > > > + }; > > > + > > > + in-ports { > > > + #address-cells =3D <1>; > > > + #size-cells =3D <0>; > > > + > > > + port@0 { > > > + reg =3D <0>; > > > + funnel_little_in_port0: endpoin= t { > > > + remote-endpoint =3D <&e= tm0_out>; > > > + }; > > > + }; > > > + > > > + port@1 { > > > + reg =3D <1>; > > > + funnel_little_in_port1: endpoin= t { > > > + remote-endpoint =3D <&e= tm1_out>; > > > + }; > > > + }; > > > + > > > + port@2 { > > > + reg =3D <2>; > > > + funnel_little_in_port2: endpoin= t { > > > + remote-endpoint =3D <&e= tm2_out>; > > > + }; > > > + }; > > > + > > > + port@3 { > > > + reg =3D <3>; > > > + funnel_little_in_port3: endpoin= t { > > > + remote-endpoint =3D <&e= tm3_out>; > > > + }; > > > + }; > > > + }; > > > + }; > > > + > > > + etf@12002000 { > > > + compatible =3D "arm,coresight-tmc", "arm,primec= ell"; > > > + reg =3D <0 0x12002000 0 0x1000>; > > > + clocks =3D <&ext_26m>; > > > + clock-names =3D "apb_pclk"; > > > + > > > + out-ports { > > > + port { > > > + etf_little_out: endpoint { > > > + remote-endpoint =3D > > > + <&funnel_ca55_in_port0>= ; > > > + }; > > > + }; > > > + }; > > > + > > > + in-port { > > > + port { > > > + etf_little_in: endpoint { > > > + remote-endpoint =3D > > > + <&funnel_little_out_por= t>; > > > + }; > > > + }; > > > + }; > > > + }; > > > + > > > + etf@12003000 { > > > + compatible =3D "arm,coresight-tmc", "arm,primec= ell"; > > > + reg =3D <0 0x12003000 0 0x1000>; > > > + clocks =3D <&ext_26m>; > > > + clock-names =3D "apb_pclk"; > > > + > > > + out-ports { > > > + port { > > > + etf_big_out: endpoint { > > > + remote-endpoint =3D > > > + <&funnel_ca55_in_port1>= ; > > > + }; > > > + }; > > > + }; > > > + > > > + in-ports { > > > + port { > > > + etf_big_in: endpoint { > > > + remote-endpoint =3D > > > + <&funnel_big_out_port>; > > > + }; > > > + }; > > > + }; > > > + }; > > > + > > > + funnel@12004000 { > > > + compatible =3D "arm,coresight-dynamic-funnel", = "arm,primecell"; > > > + reg =3D <0 0x12004000 0 0x1000>; > > > + clocks =3D <&ext_26m>; > > > + clock-names =3D "apb_pclk"; > > > + > > > + out-ports { > > > + port { > > > + funnel_ca55_out_port: endpoint = { > > > + remote-endpoint =3D > > > + <&funnel_soc_in_port>; > > > + }; > > > + }; > > > + }; > > > + > > > + in-ports { > > > + #address-cells =3D <1>; > > > + #size-cells =3D <0>; > > > + > > > + port@0 { > > > + reg =3D <0>; > > > + funnel_ca55_in_port0: endpoint = { > > > + remote-endpoint =3D > > > + <&etf_little_out>; > > > + }; > > > + }; > > > + > > > + port@1 { > > > + reg =3D <1>; > > > + funnel_ca55_in_port1: endpoint = { > > > + remote-endpoint =3D > > > + <&etf_big_out>; > > > + }; > > > + }; > > > + }; > > > + }; > > > + > > > + funnel@12005000 { > > > + compatible =3D "arm,coresight-dynamic-funnel", = "arm,primecell"; > > > + reg =3D <0 0x12005000 0 0x1000>; > > > + clocks =3D <&ext_26m>; > > > + clock-names =3D "apb_pclk"; > > > + > > > + out-ports { > > > + port { > > > + funnel_big_out_port: endpoint { > > > + remote-endpoint =3D > > > + <&etf_big_in>; > > > + }; > > > + }; > > > + }; > > > + > > > + in-ports { > > > + #address-cells =3D <1>; > > > + #size-cells =3D <0>; > > > + > > > + port@0 { > > > + reg =3D <0>; > > > + funnel_big_in_port0: endpoint { > > > + remote-endpoint =3D <&e= tm4_out>; > > > + }; > > > + }; > > > + > > > + port@1 { > > > + reg =3D <1>; > > > + funnel_big_in_port1: endpoint { > > > + remote-endpoint =3D <&e= tm5_out>; > > > + }; > > > + }; > > > + > > > + port@2 { > > > + reg =3D <2>; > > > + funnel_big_in_port2: endpoint { > > > + remote-endpoint =3D <&e= tm6_out>; > > > + }; > > > + }; > > > + > > > + port@3 { > > > + reg =3D <3>; > > > + funnel_big_in_port3: endpoint { > > > + remote-endpoint =3D <&e= tm7_out>; > > > + }; > > > + }; > > > + }; > > > + }; > > > + > > > + etm@13040000 { > > > + compatible =3D "arm,coresight-etm4x", "arm,prim= ecell"; > > > + reg =3D <0 0x13040000 0 0x1000>; > > > + cpu =3D <&CPU0>; > > > + clocks =3D <&ext_26m>; > > > + clock-names =3D "apb_pclk"; > > > + > > > + out-ports { > > > + port { > > > + etm0_out: endpoint { > > > + remote-endpoint =3D > > > + <&funnel_little_in_port= 0>; > > > + }; > > > + }; > > > + }; > > > + }; > > > + > > > + etm@13140000 { > > > + compatible =3D "arm,coresight-etm4x", "arm,prim= ecell"; > > > + reg =3D <0 0x13140000 0 0x1000>; > > > + cpu =3D <&CPU1>; > > > + clocks =3D <&ext_26m>; > > > + clock-names =3D "apb_pclk"; > > > + > > > + out-ports { > > > + port { > > > + etm1_out: endpoint { > > > + remote-endpoint =3D > > > + <&funnel_little_in_port= 1>; > > > + }; > > > + }; > > > + }; > > > + }; > > > + > > > + etm@13240000 { > > > + compatible =3D "arm,coresight-etm4x", "arm,prim= ecell"; > > > + reg =3D <0 0x13240000 0 0x1000>; > > > + cpu =3D <&CPU2>; > > > + clocks =3D <&ext_26m>; > > > + clock-names =3D "apb_pclk"; > > > + > > > + out-ports { > > > + port { > > > + etm2_out: endpoint { > > > + remote-endpoint =3D > > > + <&funnel_little_in_port= 2>; > > > + }; > > > + }; > > > + }; > > > + }; > > > + > > > + etm@13340000 { > > > + compatible =3D "arm,coresight-etm4x", "arm,prim= ecell"; > > > + reg =3D <0 0x13340000 0 0x1000>; > > > + cpu =3D <&CPU3>; > > > + clocks =3D <&ext_26m>; > > > + clock-names =3D "apb_pclk"; > > > + > > > + out-ports { > > > + port { > > > + etm3_out: endpoint { > > > + remote-endpoint =3D > > > + <&funnel_little_in_port= 3>; > > > + }; > > > + }; > > > + }; > > > + }; > > > + > > > + etm@13440000 { > > > + compatible =3D "arm,coresight-etm4x", "arm,prim= ecell"; > > > + reg =3D <0 0x13440000 0 0x1000>; > > > + cpu =3D <&CPU4>; > > > + clocks =3D <&ext_26m>; > > > + clock-names =3D "apb_pclk"; > > > + > > > + out-ports { > > > + port { > > > + etm4_out: endpoint { > > > + remote-endpoint =3D > > > + <&funnel_big_in_port0>; > > > + }; > > > + }; > > > + }; > > > + }; > > > + > > > + etm@13540000 { > > > + compatible =3D "arm,coresight-etm4x", "arm,prim= ecell"; > > > + reg =3D <0 0x13540000 0 0x1000>; > > > + cpu =3D <&CPU5>; > > > + clocks =3D <&ext_26m>; > > > + clock-names =3D "apb_pclk"; > > > + > > > + out-ports { > > > + port { > > > + etm5_out: endpoint { > > > + remote-endpoint =3D > > > + <&funnel_big_in_port1>; > > > + }; > > > + }; > > > + }; > > > + }; > > > + > > > + etm@13640000 { > > > + compatible =3D "arm,coresight-etm4x", "arm,prim= ecell"; > > > + reg =3D <0 0x13640000 0 0x1000>; > > > + cpu =3D <&CPU6>; > > > + clocks =3D <&ext_26m>; > > > + clock-names =3D "apb_pclk"; > > > + > > > + out-ports { > > > + port { > > > + etm6_out: endpoint { > > > + remote-endpoint =3D > > > + <&funnel_big_in_port2>; > > > + }; > > > + }; > > > + }; > > > + }; > > > + > > > + etm@13740000 { > > > + compatible =3D "arm,coresight-etm4x", "arm,prim= ecell"; > > > + reg =3D <0 0x13740000 0 0x1000>; > > > + cpu =3D <&CPU7>; > > > + clocks =3D <&ext_26m>; > > > + clock-names =3D "apb_pclk"; > > > + > > > + out-ports { > > > + port { > > > + etm7_out: endpoint { > > > + remote-endpoint =3D > > > + <&funnel_big_in_port3>; > > > + }; > > > + }; > > > + }; > > > + }; > > > + }; > > > +}; > > > diff --git a/arch/arm64/boot/dts/sprd/sharkl3.dtsi b/arch/arm64/boot/= dts/sprd/sharkl3.dtsi > > > new file mode 100644 > > > index 000000000000..3ef233f70dc4 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/sprd/sharkl3.dtsi > > > @@ -0,0 +1,188 @@ > > > +// SPDX-License-Identifier: GPL-2.0-only > > > +/* > > > + * Unisoc Sharkl3 platform DTS file > > > + * > > > + * Copyright (C) 2019, Unisoc Inc. > > > + */ > > > + > > > +/ { > > > + interrupt-parent =3D <&gic>; > > > + #address-cells =3D <2>; > > > + #size-cells =3D <2>; > > > + > > > + soc: soc { > > > + compatible =3D "simple-bus"; > > > + #address-cells =3D <2>; > > > + #size-cells =3D <2>; > > > + ranges; > > > + > > > + ap_ahb_regs: syscon@20e00000 { > > > + compatible =3D "syscon"; > > > + reg =3D <0 0x20e00000 0 0x10000>; > > > + }; > > > + > > > + pub_apb_regs: syscon@300e0000 { > > > + compatible =3D "syscon"; > > > > "syscon" should also have a specific compatible. What are all these > > blocks? Looks like placeholders. If so, just drop them. > > The purppse is to make these addresses mapped for many peripharls > whose some controller registers are in the same address base with one > of syscons listed here. > Under those peripharl device nodes there's a property refer to syscon, li= ke > https://elixir.bootlin.com/linux/v5.4-rc7/source/arch/arm64/boot/dts/sprd= /sc9860.dtsi#L227 Okay, but you should have a specific compatible for each block in addition to 'syscon'. Also, do you really have 64KB of registers in each block? Define what's actually there at least down to a page size to avoid unnecessary mappings. > In this way, devices can use the virtual address base which were > mapped by syscon driver. > > You can also refer to the commit massage in the patch-set: > https://lkml.org/lkml/2019/11/14/368 I agree with what Arnd said there. I don't really want to see syscon extended. It's use is really for cases where we don't have another binding defined. For example, one could define a clock controller block a syscon and then do all clock control with drivers directly accessing the clock registers, but we don't do that because we have a clock binding. If your syscon accesses are much more than needing to access a register field or 2 for something that doesn't fit into any binding, then we should consider whether a binding is needed. As you don't have the client side of any of this defined, I can't really tell. Rob