From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F37EEC433DF for ; Mon, 1 Jun 2020 14:06:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CDA5E20772 for ; Mon, 1 Jun 2020 14:06:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591020374; bh=HdEiBnB7+tQ9qOLsBO+VIuGgbzGS+nEOR7e+a6BDJ1k=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=rnh5D+ZzEvZ/Dwv29TfWy9qouq4kXKrR386BdSsR+wA5aB6Ee+jyQFjXOvisVYShg bXwnOwPASCTL3b3eyF/jc6RB6wCtuDPttAuYoXuCpZFIEl41nhfQRjxtHdibxHWbcf ZPCfq2ME/ISsQ8JUnBw9AJ5AtXDuBc+5x+4p6HG4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727068AbgFAOGN (ORCPT ); Mon, 1 Jun 2020 10:06:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:57784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726067AbgFAOGM (ORCPT ); Mon, 1 Jun 2020 10:06:12 -0400 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A5CA32077D; Mon, 1 Jun 2020 14:06:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591020371; bh=HdEiBnB7+tQ9qOLsBO+VIuGgbzGS+nEOR7e+a6BDJ1k=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=iPOTMoAQuEhw9rn2x+5jyMCfrGMrX4nn2q9HOAOopbSYbD0dWKBdh98jPKllE++Dw ajyHFSW0nxmFLgSuKbb8Mw6ME9mpVBTnZFE1CX6mpzAFybI6ca9hCpyYKb9gbwuTI/ lSfyt0QQ4XtXfStOdBPAWIi3C1ihyvXpT8xj1HBw= Received: by mail-ot1-f49.google.com with SMTP id v17so8096436ote.0; Mon, 01 Jun 2020 07:06:11 -0700 (PDT) X-Gm-Message-State: AOAM531IeLsww+t5oP7i6yG+och0wgpMPC99eBDQjc+OTVvDha1DRwTi 3u5v+J0HLkk5rkS/HkypTM9BL9/kUfaadMpUpA== X-Google-Smtp-Source: ABdhPJyX88CyvywA3XTgs8DQkY5wx0NzlC3EosrdeTaDozuT1YyKjbMpm5TyNHRfFoPJyPPCubtQ+TfIP6qUFoKcCFQ= X-Received: by 2002:a05:6830:3104:: with SMTP id b4mr17181691ots.192.1591020370946; Mon, 01 Jun 2020 07:06:10 -0700 (PDT) MIME-Version: 1.0 References: <0f8140c1-da6f-ef04-0809-252d6de6a5d7@xilinx.com> <5dfa98df-8955-59fd-1d65-c0a988190acb@xilinx.com> In-Reply-To: From: Rob Herring Date: Mon, 1 Jun 2020 08:05:59 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 00/10] Hi, To: Bharat Kumar Gogada Cc: Michal Simek , "linux-kernel@vger.kernel.org" , "monstr@monstr.eu" , git , Arnd Bergmann , Andrew Morton , "Aneesh Kumar K.V" , Arvind Sankar , Borislav Petkov , Cornelia Huck , Geert Uytterhoeven , Greg Kroah-Hartman , Greg Ungerer , Heiko Carstens , Kees Cook , Masahiro Yamada , Mike Rapoport , Mubin Usman Sayyed , Nicholas Piggin , Oleg Nesterov , Palmer Dabbelt , Paolo Bonzini , Peter Zijlstra , Randy Dunlap , Shubhrajyoti Datta , Siva Durga Prasad Paladugu , Stefan Asserhall , Vladimir Murzin , Will Deacon , "open list:GENERIC INCLUDE/ASM HEADER FILES" , "linux-mm@kvack.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 31, 2020 at 10:22 PM Bharat Kumar Gogada wrote: > > > On 25. 02. 20 17:32, Rob Herring wrote: > > > On Mon, Feb 17, 2020 at 8:28 AM Michal Simek > > wrote: > > >> > > >> Hi Rob, > > >> > > >> On 14. 02. 20 0:47, Rob Herring wrote: > > >>> On Wed, Feb 12, 2020 at 2:58 AM Michal Simek > > wrote: > > >>>> > > >>>> > > >>>> I am sending this series as before SMP support. > > >>>> Most of these patches are clean ups and should be easy to review > > >>>> them. I expect there will be more discussions about SMP support. > > >>> > > >>> While not really related to adding SMP, any chance you or someone > > >>> could look at moving microblaze PCI support to drivers/pci/? I > > >>> suspect much of the code should drop out as we have common helpers > > >>> for much of it now. That would leave only powerpc and mips for DT+PCI > > platforms. > > >> > > >> can you please suggest changes which could be done? > > >> I have CC Bharat and he could look at it. > > > > > > Look at the host controller drivers in drivers/pci/controller/. > > > pci-host-{generic,common}.c is a good template to start with as that's > > > a controller with standard config space accesses and no h/w setup > > > needed. Essentially you need to call devm_pci_alloc_host_bridge(), > > > pci_parse_request_of_pci_ranges() and pci_host_probe() with whatever > > > h/w setup you need in between those calls. > > > > > > Looking at the microblaze PCI code, looks like you may need custom > > > config space accessors which is quite common. Probably all the > > > resource and device scanning can be removed. If you look at arm64, all > > > the arch PCI code is just for ACPI. > Hi Rob, > > Can you please let us know why we might need custom config space accessors ? > We tested pci_generic_config_read/write accessors on microblaze, and we > did not see any issues. I was thinking maybe the indirect code might have to be custom, but maybe everything can be handled in .map_bus(). Rob