From: Rob Herring <robh@kernel.org>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Vinod Koul <vkoul@kernel.org>,
Alex Dewar <alex.dewar90@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Yu Chen <chenyu56@huawei.com>,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] phy: phy-hi3670-usb3: move driver from staging into phy
Date: Fri, 22 Jan 2021 08:51:37 -0600 [thread overview]
Message-ID: <CAL_JsqKyMy010vOjSdbDPXs13ygvfHpK5pb_1TN0pLM9pwL97w@mail.gmail.com> (raw)
In-Reply-To: <20210119112653.46f26ce3@coco.lan>
On Tue, Jan 19, 2021 at 4:26 AM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:
>
> Em Thu, 14 Jan 2021 19:47:31 -0600
> Rob Herring <robh@kernel.org> escreveu:
>
> > On Thu, Jan 14, 2021 at 06:35:44PM +0100, Mauro Carvalho Chehab wrote:
> > > The phy USB3 driver for Hisilicon 970 (hi3670) is ready
> > > for mainstream. Mode it from staging into the main driver's
> > > phy/ directory.
> > >
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> > > ---
> > > .../bindings/phy/phy-hi3670-usb3.yaml | 72 ++
> > > MAINTAINERS | 9 +-
> > > drivers/phy/hisilicon/Kconfig | 10 +
> > > drivers/phy/hisilicon/Makefile | 1 +
> > > drivers/phy/hisilicon/phy-hi3670-usb3.c | 668 ++++++++++++++++++
> > > drivers/staging/hikey9xx/Kconfig | 11 -
> > > drivers/staging/hikey9xx/Makefile | 2 -
> > > drivers/staging/hikey9xx/phy-hi3670-usb3.c | 668 ------------------
> > > drivers/staging/hikey9xx/phy-hi3670-usb3.yaml | 72 --
> > > 9 files changed, 759 insertions(+), 754 deletions(-)
> > > create mode 100644 Documentation/devicetree/bindings/phy/phy-hi3670-usb3.yaml
> > > create mode 100644 drivers/phy/hisilicon/phy-hi3670-usb3.c
> > > delete mode 100644 drivers/staging/hikey9xx/phy-hi3670-usb3.c
> > > delete mode 100644 drivers/staging/hikey9xx/phy-hi3670-usb3.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.yaml b/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.yaml
> > > new file mode 100644
> > > index 000000000000..125a5d6546ae
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.yaml
> > > @@ -0,0 +1,72 @@
> > > +# SPDX-License-Identifier: GPL-2.0
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/phy/hisilicon,hi3670-usb3.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Hisilicon Kirin970 USB PHY
> > > +
> > > +maintainers:
> > > + - Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> >
> > Blank line.
>
> Ok.
>
> >
> > > +description: |+
> > > + Bindings for USB3 PHY on HiSilicon Kirin 970.
> > > +
> > > +properties:
> > > + compatible:
> > > + const: hisilicon,hi3670-usb-phy
> > > +
> > > + "#phy-cells":
> > > + const: 0
> > > +
> > > + hisilicon,pericrg-syscon:
> > > + $ref: '/schemas/types.yaml#/definitions/phandle'
> > > + description: phandle of syscon used to control iso refclk.
> > > +
> > > + hisilicon,pctrl-syscon:
> > > + $ref: '/schemas/types.yaml#/definitions/phandle'
> > > + description: phandle of syscon used to control usb tcxo.
> > > +
> > > + hisilicon,sctrl-syscon:
> > > + $ref: '/schemas/types.yaml#/definitions/phandle'
> > > + description: phandle of syscon used to control phy deep sleep.
> > > +
> > > + hisilicon,eye-diagram-param:
> > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > + description: Eye diagram for phy.
> > > +
> > > + hisilicon,tx-vboost-lvl:
> > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > + description: TX level vboost for phy.
> > > +
> > > +required:
> > > + - compatible
> > > + - hisilicon,pericrg-syscon
> > > + - hisilicon,pctrl-syscon
> > > + - hisilicon,sctrl-syscon
> > > + - hisilicon,eye-diagram-param
> > > + - hisilicon,tx-vboost-lvl
> > > + - "#phy-cells"
> > > +
> > > +additionalProperties: false
> > > +
> > > +examples:
> > > + - |
> > > + bus {
> > > + #address-cells = <2>;
> > > + #size-cells = <2>;
> > > +
> > > + usb3_otg_bc: usb3_otg_bc@ff200000 {
> > > + compatible = "syscon", "simple-mfd";
> > > + reg = <0x0 0xff200000 0x0 0x1000>;
> > > +
> > > + usb_phy {
> >
> > Is there a contiguous register region for this sub-block? If so, add
> > 'reg' even though Linux doesn't need it currently.
>
> No. The driver uses 4 syscon regions in order to access the needed
> registers:
I meant just for the parent device node. I assume these are the 'main'
registers? If not, then maybe it should be a child of one of the other
syscons.
'reg' would just be for documentation ATM. However, if the subblock
was reused on another chip, but at a different offset then reg would
become useful. You could handle that with a fixed offset when 'reg' is
missing, but adding it later would be too late.
Rob
next prev parent reply other threads:[~2021-01-22 15:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 17:35 [PATCH v2 0/4] Promote Hikey 970 USB phy out of staging Mauro Carvalho Chehab
2021-01-14 17:35 ` [PATCH v2 1/4] staging: hikey9xx: phy-hi3670-usb3.c: use bitfield macros Mauro Carvalho Chehab
2021-01-14 17:35 ` [PATCH v2 2/4] staging: hikey9xx: phy-hi3670-usb3.c: adjust retry logic Mauro Carvalho Chehab
2021-01-14 17:35 ` [PATCH v2 3/4] staging: hikey9xx: phy-hi3670-usb3.c: hi3670_is_abbclk_seleted() returns bool Mauro Carvalho Chehab
2021-01-14 17:56 ` Joe Perches
2021-01-19 6:56 ` Dan Carpenter
2021-01-14 17:35 ` [PATCH v2 4/4] phy: phy-hi3670-usb3: move driver from staging into phy Mauro Carvalho Chehab
2021-01-14 22:54 ` Rob Herring
2021-01-15 1:47 ` Rob Herring
2021-01-19 10:26 ` Mauro Carvalho Chehab
2021-01-22 14:51 ` Rob Herring [this message]
2021-01-22 15:57 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKyMy010vOjSdbDPXs13ygvfHpK5pb_1TN0pLM9pwL97w@mail.gmail.com \
--to=robh@kernel.org \
--cc=alex.dewar90@gmail.com \
--cc=chenyu56@huawei.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).