From: Rob Herring <robh+dt@kernel.org>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 2/2] Documentation: devictree: Add ipq806x mdio bindings
Date: Tue, 25 Feb 2020 10:57:00 -0600 [thread overview]
Message-ID: <CAL_JsqL7hAX81hDg8L24n-xpJGzZLEu+kAvJfw=g2pzEo_LPOw@mail.gmail.com> (raw)
In-Reply-To: <20200224211035.16897-2-ansuelsmth@gmail.com>
On Mon, Feb 24, 2020 at 3:10 PM Ansuel Smith <ansuelsmth@gmail.com> wrote:
>
typo in the subject. Use 'dt-bindings: net: ...' for the subject prefix.
> Add documentations for ipq806x mdio driver.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> Changes in v7:
> - Fix dt_binding_check problem
Um, no you didn't...
>
> .../bindings/net/qcom,ipq8064-mdio.yaml | 55 +++++++++++++++++++
> 1 file changed, 55 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml
> new file mode 100644
> index 000000000000..3178cbfdc661
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later
Dual license new bindings please:
(GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/qcom,ipq8064-mdio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm ipq806x MDIO bus controller
> +
> +maintainers:
> + - Ansuel Smith <ansuelsmth@gmail.com>
> +
> +description: |+
Don't need '|+' unless you need specific formatting.
> + The ipq806x soc have a MDIO dedicated controller that is
> + used to comunicate with the gmac phy conntected.
> + Child nodes of this MDIO bus controller node are standard
> + Ethernet PHY device nodes as described in
> + Documentation/devicetree/bindings/net/phy.txt
> +
> +allOf:
> + - $ref: "mdio.yaml#"
> +
> +properties:
> + compatible:
> + const: qcom,ipq8064-mdio
blank line between properties please.
> + reg:
> + maxItems: 1
> + description: address and length of the register set for the device
That's every 'reg', you can drop this.
> + clocks:
> + maxItems: 1
> + description: A reference to the clock supplying the MDIO bus controller
That's every 'clocks', you can drop this.
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - "#address-cells"
> + - "#size-cells"
> +
> +examples:
> + - |
> + mdio0: mdio@37000000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + compatible = "qcom,ipq8064-mdio", "syscon";
'syscon' doesn't match the schema and is wrong.
> + reg = <0x37000000 0x200000>;
> + resets = <&gcc GMAC_CORE1_RESET>;
> + reset-names = "stmmaceth";
Not documented.
> + clocks = <&gcc GMAC_CORE1_CLK>;
You need to include the header for these defines.
> +
> + switch@10 {
> + compatible = "qca,qca8337";
> + /* ... */
> + };
> + };
> --
> 2.25.0
>
next prev parent reply other threads:[~2020-02-25 16:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 21:10 [PATCH v7 1/2] net: mdio: add ipq8064 mdio driver Ansuel Smith
2020-02-24 21:10 ` [PATCH v7 2/2] Documentation: devictree: Add ipq806x mdio bindings Ansuel Smith
2020-02-25 1:39 ` Andrew Lunn
2020-02-25 16:57 ` Rob Herring [this message]
2020-02-25 18:39 ` R: " ansuelsmth
2020-02-26 13:57 ` Rob Herring
2020-02-25 1:45 ` [PATCH v7 1/2] net: mdio: add ipq8064 mdio driver Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqL7hAX81hDg8L24n-xpJGzZLEu+kAvJfw=g2pzEo_LPOw@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=agross@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).