linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh+dt@kernel.org>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>
Cc: Frank Rowand <frowand.list@gmail.com>,
	kernel@axis.com, Mitchel Humpherys <mitchelh@codeaurora.org>,
	devicetree@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] of: Fix reserved-memory overlap detection
Date: Tue, 20 Oct 2020 08:00:14 -0500	[thread overview]
Message-ID: <CAL_JsqL=mpw9KxiYe_bMa+y4mU8ybrRnJ2LcO8jRco9C3N_n_w@mail.gmail.com> (raw)
In-Reply-To: <20201020073558.3582-1-vincent.whitchurch@axis.com>

On Tue, Oct 20, 2020 at 2:36 AM Vincent Whitchurch
<vincent.whitchurch@axis.com> wrote:
>
> The reserved-memory overlap detection code fails to detect overlaps if
> either of the regions starts at address 0x0.  For some reason the code
> explicitly checks for and ignores such regions, but this check looks
> invalid.  Remove the check and fix this detection.

Wouldn't 'base' be 0 for nodes that have a 'size' and no address? The
base in those cases isn't set until later when
__reserved_mem_alloc_size() is called.

>
> For example, no overlap is currently reported for this case:
>
>         foo@0 {
>                 reg = <0x0000 0x2000>;
>         };
>
>         bar@1000 {
>                 reg = <0x1000 0x1000>;
>         };
>
> but it is after this patch:
>
>  OF: reserved mem: OVERLAP DETECTED!
>  foo@0 (0x00000000--0x00002000) overlaps with bar@1000 (0x00001000--0x00002000)
>
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
> ---
>  drivers/of/of_reserved_mem.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
> index 46b9371c8a33..1c5259e3e81f 100644
> --- a/drivers/of/of_reserved_mem.c
> +++ b/drivers/of/of_reserved_mem.c
> @@ -217,8 +217,7 @@ static void __init __rmem_check_for_overlap(void)
>
>                 this = &reserved_mem[i];
>                 next = &reserved_mem[i + 1];
> -               if (!(this->base && next->base))
> -                       continue;
> +
>                 if (this->base + this->size > next->base) {
>                         phys_addr_t this_end, next_end;
>
> --
> 2.28.0
>

  reply	other threads:[~2020-10-20 13:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-20  7:35 [PATCH] of: Fix reserved-memory overlap detection Vincent Whitchurch
2020-10-20 13:00 ` Rob Herring [this message]
2020-10-20 13:46   ` Vincent Whitchurch
2020-10-20 14:17     ` Rob Herring
2020-10-21  9:58       ` Vincent Whitchurch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL_JsqL=mpw9KxiYe_bMa+y4mU8ybrRnJ2LcO8jRco9C3N_n_w@mail.gmail.com' \
    --to=robh+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=kernel@axis.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mitchelh@codeaurora.org \
    --cc=vincent.whitchurch@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).