From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1F22C4361B for ; Mon, 7 Dec 2020 14:24:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6ABD320784 for ; Mon, 7 Dec 2020 14:24:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726146AbgLGOYk (ORCPT ); Mon, 7 Dec 2020 09:24:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:37768 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725803AbgLGOYk (ORCPT ); Mon, 7 Dec 2020 09:24:40 -0500 X-Gm-Message-State: AOAM532vBmgLr02Cs4jrkuIiGiI+C0Oqpo1AKIEiqpJGXwguTvLcjYlc GFVznSy0DSYsnYqBkniDkqnDY07w3mFEwLlDiw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607351039; bh=a7lRSAu8t586Y7OhUkO8LXnMc7m/RnNg6gX+ZTBRNrM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=jb7WQMCFbP/dqWuZVhv88Al19PMduTFP5DqS7xlT4Ao02ezjg1Y6BJQ2W4HZ2ts7Z cV8A4aS6fDblr1fTZcSzLtdABqAtN+qxMWdlo5jHXlJS9fywD69hCTdmzcNooAHxBz PjYd6x96+Mdbe4l9L6qiIKgjJOzzMLeRFkR70JbladDdVm68ripimz87yPhMKl3M6E ZWb+8CHDmb7jzTN01xsxZSfdKjGe2jjz4Hokm37os57y0b+ddoTkJWbpVfr8rdSo33 +2cHQyq6xOanr/IhBVPpvz/izHVwx2JMTXAjKZedW2i+xD2lTWoudCkfiZVihMFKkn 13v0qtVUXD9vw== X-Google-Smtp-Source: ABdhPJyCK+XPyYjI3rGvm9cg99s5jJTla3Nw8Zty8yN5frd+1OrtkBIrpss0IimDx7gT2okOUEQ743lh0FHKXgZNnWg= X-Received: by 2002:a50:f404:: with SMTP id r4mr20217224edm.62.1607351037965; Mon, 07 Dec 2020 06:23:57 -0800 (PST) MIME-Version: 1.0 References: <20201204165841.3845589-1-arnd@kernel.org> In-Reply-To: <20201204165841.3845589-1-arnd@kernel.org> From: Rob Herring Date: Mon, 7 Dec 2020 08:23:46 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] PCI: dwc: exynos: add back MSI dependency To: Arnd Bergmann Cc: Lorenzo Pieralisi , Bjorn Helgaas , Jaehoon Chung , Jingoo Han , Krzysztof Kozlowski , Arnd Bergmann , Andrew Murray , Dilip Kota , Vidya Sagar , Kunihiko Hayashi , Alex Dewar , PCI , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 4, 2020 at 10:58 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > While the exynos driver does not always need MSI, the generic > deisgnware host code it uses fails to build without it: > > WARNING: unmet direct dependencies detected for PCIE_DW_HOST > Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n] > Selected by [y]: > - PCI_EXYNOS [=y] && PCI [=y] && (ARCH_EXYNOS [=n] || COMPILE_TEST [=y]) > drivers/pci/controller/dwc/pcie-designware-host.c:247:19: error: implicit declaration of function 'pci_msi_create_irq_domain' [-Werror,-Wimplicit-function-declaration] > pp->msi_domain = pci_msi_create_irq_domain(fwnode, > ^ > > Add back the dependency that all other designware controllers have. > > Fixes: f0a6743028f9 ("PCI: dwc: exynos: Rework the driver to support Exynos5433 variant") > Signed-off-by: Arnd Bergmann > --- > drivers/pci/controller/dwc/Kconfig | 1 + > 1 file changed, 1 insertion(+) Seems like we should rework this to avoid select on options with depends, but that's a separate change. > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig > index 020101b58155..e403bb2eeb4c 100644 > --- a/drivers/pci/controller/dwc/Kconfig > +++ b/drivers/pci/controller/dwc/Kconfig > @@ -85,6 +85,7 @@ config PCIE_DW_PLAT_EP > config PCI_EXYNOS > tristate "Samsung Exynos PCIe controller" > depends on ARCH_EXYNOS || COMPILE_TEST > + depends on PCI && PCI_MSI_IRQ_DOMAIN PCI isn't needed here. > select PCIE_DW_HOST > help > Enables support for the PCIe controller in the Samsung Exynos SoCs > -- > 2.27.0 >