From: Rob Herring <robh@kernel.org>
To: Xu Yilun <yilun.xu@linux.intel.com>
Cc: Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
Michal Simek <michal.simek@amd.com>,
kernel test robot <lkp@intel.com>,
linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fpga: xilinx-pr-decoupler: Fix unused xlnx_pr_decoupler_of_match warning for !CONFIG_OF
Date: Fri, 13 Oct 2023 08:15:51 -0500 [thread overview]
Message-ID: <CAL_JsqLHKTQi0i-V4C5UA6WJjnMeen0WR4jjcA4YSRXOYZOrZA@mail.gmail.com> (raw)
In-Reply-To: <ZSkPjRp/xPfVQ/NB@yilunxu-OptiPlex-7050>
On Fri, Oct 13, 2023 at 4:37 AM Xu Yilun <yilun.xu@linux.intel.com> wrote:
>
> On Thu, Oct 12, 2023 at 02:21:48PM -0500, Rob Herring wrote:
> > Commit 8c966aadcc02 ("fpga: Use device_get_match_data()") dropped the
>
> Hi rob:
>
> Unfortunately I re-applied Commit 8c966aadcc02 and the previous commit
> id is lost.
>
> Since the 2 patches are not upstreamed yet, could I just merge them into
> one?
Yes, that's fine.
Rob
>
> Thanks,
> Yilun
>
> > unconditional use of xlnx_pr_decoupler_of_match resulting in this
> > warning:
> >
> > drivers/fpga/xilinx-pr-decoupler.c:94:34: warning: unused variable 'xlnx_pr_decoupler_of_match' [-Wunused-const-variable]
> >
> > The fix is to drop of_match_ptr() which is not necessary because DT is
> > always used for this driver.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202310100247.Y7BFcalX-lkp@intel.com/
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > drivers/fpga/xilinx-pr-decoupler.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
> > index 0c012d0f616d..68835896f180 100644
> > --- a/drivers/fpga/xilinx-pr-decoupler.c
> > +++ b/drivers/fpga/xilinx-pr-decoupler.c
> > @@ -167,7 +167,7 @@ static struct platform_driver xlnx_pr_decoupler_driver = {
> > .remove = xlnx_pr_decoupler_remove,
> > .driver = {
> > .name = "xlnx_pr_decoupler",
> > - .of_match_table = of_match_ptr(xlnx_pr_decoupler_of_match),
> > + .of_match_table = xlnx_pr_decoupler_of_match,
> > },
> > };
> >
> > --
> > 2.42.0
> >
next prev parent reply other threads:[~2023-10-13 13:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 19:21 [PATCH] fpga: xilinx-pr-decoupler: Fix unused xlnx_pr_decoupler_of_match warning for !CONFIG_OF Rob Herring
2023-10-13 9:36 ` Xu Yilun
2023-10-13 13:15 ` Rob Herring [this message]
2023-10-13 18:36 ` Rob Herring
2023-10-16 3:17 ` Xu Yilun
2023-10-20 0:37 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqLHKTQi0i-V4C5UA6WJjnMeen0WR4jjcA4YSRXOYZOrZA@mail.gmail.com \
--to=robh@kernel.org \
--cc=hao.wu@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mdf@kernel.org \
--cc=michal.simek@amd.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
--cc=yilun.xu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).