From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753404AbaCKPO1 (ORCPT ); Tue, 11 Mar 2014 11:14:27 -0400 Received: from mail-ve0-f170.google.com ([209.85.128.170]:33597 "EHLO mail-ve0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbaCKPOY (ORCPT ); Tue, 11 Mar 2014 11:14:24 -0400 MIME-Version: 1.0 In-Reply-To: <5EE98053-31B8-4679-AAE2-4F026C61D1D4@codeaurora.org> References: <1393629520-12713-1-git-send-email-santosh.shilimkar@ti.com> <1393629520-12713-3-git-send-email-santosh.shilimkar@ti.com> <531E2C55.70702@ti.com> <5EE98053-31B8-4679-AAE2-4F026C61D1D4@codeaurora.org> Date: Tue, 11 Mar 2014 10:14:23 -0500 Message-ID: Subject: Re: [PATCH 2/3] soc: keystone: add QMSS driver From: Rob Herring To: Kumar Gala Cc: Santosh Shilimkar , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Sandeep Nair , Greg Kroah-Hartman , Olof Johansson , Arnd Bergmann , Grant Likely , Rob Herring , Mark Rutland Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 11, 2014 at 9:04 AM, Kumar Gala wrote: > > On Mar 10, 2014, at 4:19 PM, Santosh Shilimkar wrote: > >>>> + -- reg-names : Names for the above register regions. The name to be >>>> + used is as follows: >>>> + - "config" : Queue configuration region. >>>> + - "status" : Queue status RAM. >>>> + - "region" : Descriptor memory setup region. >>>> + - "push" : Queue Management/Queue Proxy region. >>>> + - "pop" : Queue Management/Queue Proxy region. >>>> + - "peek" : Queue Peek region. >>> >>> reg-names should be optional. Also you have the order different from >>> reg. Be consistent as to what is the correct order. >>> >> We thought of using reg-names to remove the ordering to index >> the regs. So if we make the reg-names optional, then indexing >> by order will be used. We can do that. > > We keep having this conversation, why does reg-names need to be optional for new bindings? Because order is a fundamental part of the reg and interrupts properties and has been since the beginning of DT. Adding auxiliary data does not change that. We just discussed this in our weekly DT meeting[1]. In many cases defining the order is not a burden. For the exceptions, the binding needs to spell out why the order can't be fixed. Rob [1] http://irclogs.linaro.org/meeting-logs/devicetree/2014/devicetree.2014-03-11-14.09.log.html