From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758255AbeD0SoJ (ORCPT ); Fri, 27 Apr 2018 14:44:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:36188 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758007AbeD0SoH (ORCPT ); Fri, 27 Apr 2018 14:44:07 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE93621894 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh@kernel.org X-Google-Smtp-Source: AB8JxZqn03xuIeT99cW4SeFFngSJkdtbAfEPMloRxoBiaxf+xDldy+6KP0B29PQihKSDYCbyfoPmHM872EIVDA+SIWc= MIME-Version: 1.0 In-Reply-To: References: <20180411015948.19562-1-andrew.smirnov@gmail.com> <20180411015948.19562-2-andrew.smirnov@gmail.com> <20180416150507.2wm4s7opgr242v6a@rob-hp-laptop> From: Rob Herring Date: Fri, 27 Apr 2018 13:43:45 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/2] dt-bindings: nvmem: Add binding for RAVE SP EEPROM driver To: Andrey Smirnov Cc: Srinivas Kandagatla , linux-kernel , Chris Healy , Lucas Stach , Aleksander Morgado , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 27, 2018 at 1:05 AM, Andrey Smirnov wrote: > On Mon, Apr 16, 2018 at 8:05 AM, Rob Herring wrote: >> On Tue, Apr 10, 2018 at 06:59:47PM -0700, Andrey Smirnov wrote: >>> Add Device Tree bindings for RAVE SP EEPROM driver - an MFD cell of >>> parent RAVE SP driver (documented in >>> Documentation/devicetree/bindings/mfd/zii,rave-sp.txt). >>> >>> Cc: Srinivas Kandagatla >>> Cc: linux-kernel@vger.kernel.org >>> Cc: Chris Healy >>> Cc: Lucas Stach >>> Cc: Aleksander Morgado >>> Cc: Rob Herring >>> Cc: Mark Rutland >>> Cc: devicetree@vger.kernel.org >>> Signed-off-by: Andrey Smirnov >>> --- >>> .../bindings/nvmem/zii,rave-sp-eeprom.txt | 29 ++++++++++++++++++++++ >>> 1 file changed, 29 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt >>> >>> diff --git a/Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt b/Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt >>> new file mode 100644 >>> index 000000000000..a4e838c30b67 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt >>> @@ -0,0 +1,29 @@ >>> +Zodiac Inflight Innovations RAVE EEPROM Bindings >>> + >>> +RAVE SP EEPROM device is a "MFD cell" device exposing physical EEPROM >>> +attached to RAVE Supervisory Processor. It is expected that its Device >>> +Tree node is specified as a child of the node corresponding to the >>> +parent RAVE SP device (as documented in >>> +Documentation/devicetree/bindings/mfd/zii,rave-sp.txt) >>> + >>> +Required properties: >>> + >>> +- compatible: Should be "zii,rave-sp-eeprom" >> >> Need to state somewhere this follows the bindings/nvmem/nvmem.txt >> binding. >> > > OK, will fix in v3. > >>> + >>> +Example: >>> + >>> + rave-sp { >>> + compatible = "zii,rave-sp-rdu1"; >>> + current-speed = <38400>; >>> + >>> + main-eeprom { >> >> eeprom@a4 > > Any chance I can keep it as is? I am asking because this node name is > used by the driver as device name which is how it also appears in > sysfs. Reason for that being that "main-eeprom" and "dds-eeprom" > (second EEPROM in the system) are easier to rembmer and tell apart > than "eeprom@a4" and "eeprom@a5". Granted, I can divorce naming scheme > in the driver from device node name, but then I'd have to keep a > "address -> deivce name" lookup table which I was hoping to avoid. It generates a dtc warning if you don't fix it. Rob