From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E282C4727C for ; Tue, 22 Sep 2020 17:30:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00AF12388B for ; Tue, 22 Sep 2020 17:30:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600795844; bh=h/Ld3B+y9ti44HaX9WBK4umuicsG2Hw4yBOtkCQsXm0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=VgR/RRSeSZE/gWDSEIMiUZYGRxFrPq048pCSC94cj8i4FX/xB9ad874VCAYCU5pmE 7Qyf7vJ6J2BCXcs0s9O8IS+yE8Vhz4TcooCq6ldoQGJdca/pXNFm3WE8zZdJr5+10g 6mM9C2B2JTYRLIsOmbuwwy8ACHEsSPYaz6eeqnUQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726632AbgIVRan (ORCPT ); Tue, 22 Sep 2020 13:30:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:39008 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726526AbgIVRam (ORCPT ); Tue, 22 Sep 2020 13:30:42 -0400 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 429FF22206; Tue, 22 Sep 2020 17:30:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600795842; bh=h/Ld3B+y9ti44HaX9WBK4umuicsG2Hw4yBOtkCQsXm0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=hA8Xdhw2USh4kEEPqjKDIT0mhCkpZpCochvP0DjCFvzxc+vAhm+YpgHLL9mZu5HeU GakRDxsjIPzPj53y2Za7Fwa3UN8BOj34bJ5v+X1TB8hzlE1YanZlO80Qyx0G018TVo vmRBRRVaboUuhyQvTKIIuBkvUDsfzT07l4CyQb6Y= Received: by mail-oi1-f176.google.com with SMTP id v20so21914043oiv.3; Tue, 22 Sep 2020 10:30:42 -0700 (PDT) X-Gm-Message-State: AOAM532VnlAaIX+rJmpqHBcv+D/A4hGgmVZj4YvK30PBIo+3WFDGnDoF X8mvKEtdsnrX308ALJ7Cdf9we5pNIjiGYIYTLA== X-Google-Smtp-Source: ABdhPJyR6TOz5P3635ttyIAV8HOhgZ+lkgMa2lt2O2qCFj7x8E0qhcXa056jzEwtzQMukGxjEo9dw8CwafWjv0lsZfM= X-Received: by 2002:aca:1711:: with SMTP id j17mr3427994oii.152.1600795841602; Tue, 22 Sep 2020 10:30:41 -0700 (PDT) MIME-Version: 1.0 References: <20200921074953.25289-1-narmstrong@baylibre.com> In-Reply-To: <20200921074953.25289-1-narmstrong@baylibre.com> From: Rob Herring Date: Tue, 22 Sep 2020 11:30:30 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] PCI: dwc/meson: do not fail on wait linkup timeout To: Neil Armstrong Cc: Lorenzo Pieralisi , Yue Wang , PCI , "open list:ARM/Amlogic Meson..." , linux-arm-kernel , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2020 at 1:50 AM Neil Armstrong wrote: > > When establish link timeouts, probe fails but the error is unrelated since > the PCIe controller has been probed succesfully. > > Align with most of the other dw-pcie drivers and ignore return of > dw_pcie_wait_for_link() in the host_init callback. I think all, not most DWC drivers should be aligned. Plus the code here is pretty much the same, so I'm working on moving all this to the common DWC code. Drivers that need to bring up the link will need to implement .start_link() (currently only used for EP mode). Most of the time that is just setting the LTSSM bit which Synopsys thought letting every vendor do their own register for was a good idea. Sigh. Rob