From: Rob Herring <robh@kernel.org>
To: Li Yang <leoyang.li@nxp.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
lkml <linux-kernel@vger.kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/5] dt-bindings: memory: fsl: convert ifc binding to yaml schema
Date: Fri, 1 Oct 2021 11:35:05 -0500 [thread overview]
Message-ID: <CAL_JsqL_M2Y+CDfK95BmFJYxT2h4q8rd0BaHLk2Wth3u_U6YMQ@mail.gmail.com> (raw)
In-Reply-To: <CADRPPNQBR63pS60nmfUQx02GbBoWEbgroU5Zw-iY62TodmB91Q@mail.gmail.com>
On Fri, Oct 1, 2021 at 11:29 AM Li Yang <leoyang.li@nxp.com> wrote:
>
> On Fri, Oct 1, 2021 at 8:18 AM Rob Herring <robh@kernel.org> wrote:
> >
> > On Thu, 30 Sep 2021 19:09:20 -0500, Li Yang wrote:
> > > Convert the txt binding to yaml format and add description. Drop the
> > > "simple-bus" compatible string from the example and not allowed by the
> > > binding any more. This will help to enforce the correct probe order
> > > between parent device and child devices, but will require the ifc driver
> > > to probe the child devices to work properly.
> > >
> > > Signed-off-by: Li Yang <leoyang.li@nxp.com>
> > > ---
> > > updates from previous submission:
> > > - Drop "simple-bus" from binding and only "fsl,ifc" as compatible
> > > - Fix one identiation problem of "reg"
> > > - Add type restriction to "little-endian" property
> > >
> > > .../bindings/memory-controllers/fsl/ifc.txt | 82 -----------
> > > .../bindings/memory-controllers/fsl/ifc.yaml | 137 ++++++++++++++++++
> > > 2 files changed, 137 insertions(+), 82 deletions(-)
> > > delete mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
> > > create mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/ifc.yaml
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > Documentation/devicetree/bindings/memory-controllers/fsl/ifc.example.dt.yaml:0:0: /example-0/soc/ifc@ffe1e000/flash@1,0: failed to match any schema with compatible: ['fsl,ifc-nand']
> > Documentation/devicetree/bindings/memory-controllers/fsl/ifc.example.dt.yaml:0:0: /example-0/soc/ifc@ffe1e000/cpld@3,0: failed to match any schema with compatible: ['fsl,p1010rdb-cpld']
>
> These are defined in other bindings, but unfortunately they are not
> converted to yaml format yet.
Yes, I know. I'm trying to turn on this check by default and adding
more cases here doesn't help. And often, when those other bindings get
converted, it's the example here that has errors and has to get fixed.
So either convert those bindings too or drop them from the example.
Rob
next prev parent reply other threads:[~2021-10-01 16:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 0:09 [PATCH 0/5] convert ifc binding to yaml and drop "simple-bus" Li Yang
2021-10-01 0:09 ` [PATCH 1/5] dt-bindings: memory: fsl: convert ifc binding to yaml schema Li Yang
2021-10-01 9:59 ` Krzysztof Kozlowski
2021-10-01 16:17 ` Li Yang
2021-10-04 9:31 ` Krzysztof Kozlowski
2021-10-08 21:50 ` Li Yang
2021-10-14 12:46 ` Rob Herring
2021-10-01 13:16 ` Rob Herring
2021-10-01 16:29 ` Li Yang
2021-10-01 16:35 ` Rob Herring [this message]
2021-10-01 0:09 ` [PATCH 2/5] memory: fsl_ifc: populate child devices without relying on simple-bus Li Yang
2021-10-04 16:27 ` Rob Herring
2021-10-09 3:12 ` Li Yang
2021-10-01 0:09 ` [PATCH 3/5] ARM: dts: ls1021a: remove "simple-bus" compatible from ifc node Li Yang
2021-10-01 0:09 ` [PATCH 4/5] arm64: dts: " Li Yang
2021-10-01 0:09 ` [PATCH 5/5] powerpc/mpc85xx: " Li Yang
2021-10-01 9:45 ` [PATCH 0/5] convert ifc binding to yaml and drop "simple-bus" Krzysztof Kozlowski
2021-10-01 19:51 ` Li Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqL_M2Y+CDfK95BmFJYxT2h4q8rd0BaHLk2Wth3u_U6YMQ@mail.gmail.com \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).