From: Rob Herring <email@example.com> To: Paul Walmsley <firstname.lastname@example.org> Cc: "open list:SERIAL DRIVERS" <email@example.com>, firstname.lastname@example.org, email@example.com, "firstname.lastname@example.org" <email@example.com>, Greg Kroah-Hartman <firstname.lastname@example.org>, Mark Rutland <email@example.com>, Palmer Dabbelt <firstname.lastname@example.org>, Paul Walmsley <email@example.com> Subject: Re: [PATCH v2 1/2] dt-bindings: serial: add documentation for the SiFive UART driver Date: Sat, 20 Oct 2018 09:21:42 -0500 [thread overview] Message-ID: <CAL_JsqLagTgjDhZ02X=wPFDB4WF2bR7=LyzSW9D=ooo_XB_zOg@mail.gmail.com> (raw) In-Reply-To: <firstname.lastname@example.org> On Fri, Oct 19, 2018 at 5:06 PM Paul Walmsley <email@example.com> wrote: > > > On 10/19/18 1:45 PM, Rob Herring wrote: > > On Fri, Oct 19, 2018 at 1:48 PM Paul Walmsley <firstname.lastname@example.org> wrote: > >> Add DT binding documentation for the Linux driver for the SiFive > >> asynchronous serial IP block. Nothing too exotic. > >> > >> Cc: email@example.com > >> Cc: firstname.lastname@example.org > >> Cc: email@example.com > >> Cc: firstname.lastname@example.org > >> Cc: Greg Kroah-Hartman <email@example.com> > >> Cc: Rob Herring <firstname.lastname@example.org> > >> Cc: Mark Rutland <email@example.com> > >> Cc: Palmer Dabbelt <firstname.lastname@example.org> > >> Reviewed-by: Palmer Dabbelt <email@example.com> > >> Signed-off-by: Paul Walmsley <firstname.lastname@example.org> > >> Signed-off-by: Paul Walmsley <email@example.com> > >> --- > >> .../bindings/serial/sifive-serial.txt | 21 +++++++++++++++++++ > >> 1 file changed, 21 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/serial/sifive-serial.txt > >> > >> diff --git a/Documentation/devicetree/bindings/serial/sifive-serial.txt b/Documentation/devicetree/bindings/serial/sifive-serial.txt > >> new file mode 100644 > >> index 000000000000..8982338512f5 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/serial/sifive-serial.txt > >> @@ -0,0 +1,21 @@ > >> +SiFive asynchronous serial interface (UART) > >> + > >> +Required properties: > >> + > >> +- compatible: should be "sifive,fu540-c000-uart0" or "sifive,uart0" > > I assume once again, the last '0' is a version? > > > Yes. > > > > Palmer mentioned the > > compatible string is part of the IP block repository? > > > It is, but there's no guarantee that the compatible string from the RTL > will make it into a ROM for any given chip. For example, a customer may > want the UART, but not want to take the DT ROM to keep area down. Optional? Well, that's pointless to have then. > This is one of the reasons why we'll likely switch to the usual > software-maintained DTS files for Linux, just like the rest of arch/arm, > arch/powerpc, etc. Then you should probably just follow normal conventions. I don't think DT in the h/w is the best strategy anyways. Ideally, what the h/w should have are version and capabilities (assuming there are configuration options) registers which aren't optional and can't be forgotten to be updated. The version should probably have a vendor too. > > As I mentioned for the > > intc and now the pwm block bindings, if you are going to do version > > numbers please document the versioning scheme. > > > Will add that to the binding document. I don't seem to be making my point clear. I don't want any of this added to a binding doc for particular IP blocks. Write a common doc that explains the scheme and addresses the questions I asked. Then just reference that doc here. Maybe this is documented somewhere already? Otherwise, if one is creating a new IP block, how do they know what the versioning scheme is or what goes in the DT ROM? > > > > Where does the > > number come from? > > > It comes from the RTL, which is public: > > https://github.com/sifive/sifive-blocks/blob/master/src/main/scala/devices/uart/UART.scala#L43 I'm not going to go read your RTL, sorry. Rob
next prev parent reply other threads:[~2018-10-20 14:21 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-19 18:48 [PATCH v2 0/2] tty: serial: add DT bindings and serial driver for the SiFive FU540 UART Paul Walmsley 2018-10-19 18:48 ` [PATCH v2 1/2] dt-bindings: serial: add documentation for the SiFive UART driver Paul Walmsley 2018-10-19 20:45 ` Rob Herring 2018-10-19 22:05 ` Paul Walmsley 2018-10-20 14:21 ` Rob Herring [this message] 2018-10-23 17:05 ` Paul Walmsley 2018-10-24 17:32 ` Rob Herring 2018-11-16 23:10 ` Paul Walmsley 2018-10-22 16:41 ` Palmer Dabbelt 2018-10-24 16:53 ` Rob Herring 2018-10-19 18:48 ` [PATCH v2 2/2] tty: serial: add driver for the SiFive UART Paul Walmsley
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAL_JsqLagTgjDhZ02X=wPFDB4WF2bR7=LyzSW9D=ooo_XB_zOg@mail.gmail.com' \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v2 1/2] dt-bindings: serial: add documentation for the SiFive UART driver' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).